From: Michael Jones <michael.jones@matrix-vision.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: grammar fix in Kconfig
Date: Thu, 26 Jul 2012 17:00:02 +0200 [thread overview]
Message-ID: <50115B72.2070604@matrix-vision.de> (raw)
In-Reply-To: <20120726144812.GN3099@opensource.wolfsonmicro.com>
On 07/26/2012 04:48 PM, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 04:07:24PM +0200, Michael Jones wrote:
>
>> - constraints then the regulator core will provide an always
>> - enabled dummy regulator will be provided, allowing consumer
>> - drivers to continue.
>> + constraints, the regulator core will provide an always-
>> + enabled dummy regulator, allowing consumer drivers to continue.
>
> This appears to be making the grammar worse, it's just removing a "then"
> and inserting, random commas which don't make, much sense.
>
What I was trying to fix was the double "provide" in "will provide an...
will be provided." I agree that the if...then... was ugly, too.
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier
prev parent reply other threads:[~2012-07-26 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 14:07 [PATCH 0/2] regulator: Kconfig grammar & whitespace Michael Jones
2012-07-26 14:07 ` [PATCH 1/2] regulator: whitespace Michael Jones
2012-07-26 14:44 ` Mark Brown
2012-07-26 15:12 ` Michael Jones
2012-07-26 15:15 ` Mark Brown
2012-07-26 15:29 ` Michael Jones
2012-07-26 15:32 ` Mark Brown
2012-08-04 11:19 ` Mark Brown
2012-07-26 14:07 ` [PATCH 2/2] regulator: grammar fix in Kconfig Michael Jones
2012-07-26 14:48 ` Mark Brown
2012-07-26 15:00 ` Michael Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50115B72.2070604@matrix-vision.de \
--to=michael.jones@matrix-vision.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.