All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Jones <michael.jones@matrix-vision.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: whitespace
Date: Thu, 26 Jul 2012 17:29:14 +0200	[thread overview]
Message-ID: <5011624A.4040309@matrix-vision.de> (raw)
In-Reply-To: <20120726151546.GQ3099@opensource.wolfsonmicro.com>

On 07/26/2012 05:15 PM, Mark Brown wrote:
> On Thu, Jul 26, 2012 at 05:12:59PM +0200, Michael Jones wrote:
>> On 07/26/2012 04:44 PM, Mark Brown wrote:
>
>>> Your changelog says "whitespace" and is otherwise blank...  what is the
>>> problem you think you are fixing here?
>
>> I don't see what you're seeing.
>
> I'm not seeing anything at all.  That's the problem.
>
>> Here:
>> https://lkml.org/lkml/2012/7/26/255
>> I see the patch which replaces non-uniform spaces with tabs.
>
> ...and only has a one word changelog.
>

Sorry, I misunderstood.  I thought you saw _only_ a one word change log, 
and not even the patch.  I think I answered your question above now, right?
Q: what is the problem you think you are fixing here?
A: some lines were indented with spaces, while most of them are indented 
with tabs.

So I suppose the changelog should have been something like:
regulator: whitespace- indent with tabs not spaces

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

  reply	other threads:[~2012-07-26 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 14:07 [PATCH 0/2] regulator: Kconfig grammar & whitespace Michael Jones
2012-07-26 14:07 ` [PATCH 1/2] regulator: whitespace Michael Jones
2012-07-26 14:44   ` Mark Brown
2012-07-26 15:12     ` Michael Jones
2012-07-26 15:15       ` Mark Brown
2012-07-26 15:29         ` Michael Jones [this message]
2012-07-26 15:32           ` Mark Brown
2012-08-04 11:19   ` Mark Brown
2012-07-26 14:07 ` [PATCH 2/2] regulator: grammar fix in Kconfig Michael Jones
2012-07-26 14:48   ` Mark Brown
2012-07-26 15:00     ` Michael Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5011624A.4040309@matrix-vision.de \
    --to=michael.jones@matrix-vision.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.