All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: Huang Shijie <shijie8@gmail.com>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Richard Zhao <richard.zhao@freescale.com>
Cc: "Artem.Bityutskiy@linux.intel.com"
	<Artem.Bityutskiy@linux.intel.com>,
	"b32955@freescale.com" <b32955@freescale.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	Fabio Estevam <festevam@gmail.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA
Date: Fri, 27 Jul 2012 11:30:43 +0200	[thread overview]
Message-ID: <50125FC3.4040603@de.bosch.com> (raw)
In-Reply-To: <CAMiH66E9gJJ7f=wKJ8Ondegj=+WUYYuDA0iB8mhNoWBRNWXKsQ@mail.gmail.com>

On 26.07.2012 13:32, Huang Shijie wrote:
> On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie <shijie8@gmail.com> wrote:
>>> On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie <shijie8@gmail.com> wrote:
>>>>
>>>>> But you have added "depend on MXS_DMA". So If you do not select the
>>>>> mxs-dma, you can not see the
>>>>> gpmi-nand.
>>>>> that's why i think this patch is not needed.
>>>> So how CONFIG_MXS_DMA would be selected if not via defconfig?
>>> Use the make menuconfig ARCH=arm:
>>>
>>> "device drivers"-->"DMA engine support" -->"mxs dma support"
>> I prefer to have selected in the defconfig by default instead.
>>
>> It is not obvious for the end user that they need to manually select
>> this option.
>>
>> mxs_defconfig also selects CONFIG_MXS_DMA.
> In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
> 
>> Can't we do the same here and let imx_v6_v7_defconfig be built again?
> Shawn, do you have any opinion about this?

First, I think Shawn is on holiday at the moment.

Second, recent kernel mainline from today building imx_v6_v7_defconfig 
is broken due to this.

So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As 
it seems that GPMI_NAND needs it to build, I would vote for the

depends on MXS_DMA

fix proposed by Richard

http://www.spinics.net/lists/arm-kernel/msg186111.html

Anyhow, any chance to get the kernel mainline fixed asap?

Many thanks and best regards

Dirk

WARNING: multiple messages have this Message-ID (diff)
From: dirk.behme@de.bosch.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA
Date: Fri, 27 Jul 2012 11:30:43 +0200	[thread overview]
Message-ID: <50125FC3.4040603@de.bosch.com> (raw)
In-Reply-To: <CAMiH66E9gJJ7f=wKJ8Ondegj=+WUYYuDA0iB8mhNoWBRNWXKsQ@mail.gmail.com>

On 26.07.2012 13:32, Huang Shijie wrote:
> On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie <shijie8@gmail.com> wrote:
>>> On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie <shijie8@gmail.com> wrote:
>>>>
>>>>> But you have added "depend on MXS_DMA". So If you do not select the
>>>>> mxs-dma, you can not see the
>>>>> gpmi-nand.
>>>>> that's why i think this patch is not needed.
>>>> So how CONFIG_MXS_DMA would be selected if not via defconfig?
>>> Use the make menuconfig ARCH=arm:
>>>
>>> "device drivers"-->"DMA engine support" -->"mxs dma support"
>> I prefer to have selected in the defconfig by default instead.
>>
>> It is not obvious for the end user that they need to manually select
>> this option.
>>
>> mxs_defconfig also selects CONFIG_MXS_DMA.
> In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
> 
>> Can't we do the same here and let imx_v6_v7_defconfig be built again?
> Shawn, do you have any opinion about this?

First, I think Shawn is on holiday at the moment.

Second, recent kernel mainline from today building imx_v6_v7_defconfig 
is broken due to this.

So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As 
it seems that GPMI_NAND needs it to build, I would vote for the

depends on MXS_DMA

fix proposed by Richard

http://www.spinics.net/lists/arm-kernel/msg186111.html

Anyhow, any chance to get the kernel mainline fixed asap?

Many thanks and best regards

Dirk

  parent reply	other threads:[~2012-07-27  9:30 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 11:18 [PATCH v2 1/3] mtd: nand: Include IMX6 in the list of supported SoCs Fabio Estevam
2012-07-25 11:18 ` Fabio Estevam
2012-07-25 11:18 ` [PATCH v2 2/3] mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA Fabio Estevam
2012-07-25 11:18   ` Fabio Estevam
2012-07-26  2:27   ` Huang Shijie
2012-07-26  2:27     ` Huang Shijie
2012-07-26 10:35     ` Fabio Estevam
2012-07-26 10:35       ` Fabio Estevam
2012-07-27  9:28   ` Richard Zhao
2012-07-27  9:28     ` Richard Zhao
2012-08-03 10:07   ` Sascha Hauer
2012-08-03 10:07     ` Sascha Hauer
2012-08-05  6:36     ` Dirk Behme
2012-08-05  6:36       ` Dirk Behme
2012-07-25 11:18 ` [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA Fabio Estevam
2012-07-25 11:18   ` Fabio Estevam
2012-07-25 15:05   ` Huang Shijie
2012-07-25 15:05     ` Huang Shijie
2012-07-25 15:23     ` Fabio Estevam
2012-07-25 15:23       ` Fabio Estevam
2012-07-26  2:24       ` Huang Shijie
2012-07-26  2:24         ` Huang Shijie
2012-07-26  2:29         ` Dong Aisheng
2012-07-26  2:29           ` Dong Aisheng
2012-07-26 10:38           ` Fabio Estevam
2012-07-26 10:38             ` Fabio Estevam
2012-07-28 13:02             ` Shawn Guo
2012-07-28 13:02               ` Shawn Guo
2012-07-26 10:45         ` David Woodhouse
2012-07-26 10:45           ` David Woodhouse
2012-07-26 10:53         ` Fabio Estevam
2012-07-26 10:53           ` Fabio Estevam
2012-07-26 10:56           ` Huang Shijie
2012-07-26 10:56             ` Huang Shijie
2012-07-26 11:08             ` Fabio Estevam
2012-07-26 11:08               ` Fabio Estevam
2012-07-26 11:32               ` Huang Shijie
2012-07-26 11:32                 ` Huang Shijie
2012-07-27  9:26                 ` Richard Zhao
2012-07-27  9:26                   ` Richard Zhao
2012-07-27  9:30                 ` Dirk Behme [this message]
2012-07-27  9:30                   ` Dirk Behme
2012-07-27 10:21                   ` Huang Shijie
2012-07-27 10:21                     ` Huang Shijie
2012-07-26 11:54               ` David Woodhouse
2012-07-26 11:54                 ` David Woodhouse
2012-08-03  8:40   ` Dirk Behme
2012-08-03  8:40     ` Dirk Behme
2012-08-03  8:59     ` Huang Shijie
2012-08-03  8:59       ` Huang Shijie
2012-07-27  9:30 ` [PATCH v2 1/3] mtd: nand: Include IMX6 in the list of supported SoCs Richard Zhao
2012-07-27  9:30   ` Richard Zhao
2012-07-27 10:12   ` Huang Shijie
2012-07-27 10:12     ` Huang Shijie
2012-08-17 15:52 ` Artem Bityutskiy
2012-08-17 15:52   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50125FC3.4040603@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=Artem.Bityutskiy@linux.intel.com \
    --cc=b32955@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.zhao@freescale.com \
    --cc=shawn.guo@linaro.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.