From: jgarzik@pobox.com (Jeff Garzik)
Subject: [PATCH] NVMe: Add a character device for each nvme device
Date: Fri, 27 Jul 2012 16:42:01 -0400 [thread overview]
Message-ID: <5012FD19.5090100@pobox.com> (raw)
In-Reply-To: <20120727202655.GP22985@linux.intel.com>
On 07/27/2012 04:26 PM, Matthew Wilcox wrote:
> Maybe we should design such a mechanism, but maybe we shouldn't ... as we
> find common things to do, we tend to move those to sysfs, not ioctls,
> and the kinds of commands that are being sent here are essentially
> vendor-specific NVMe commands; it's not clear they'd fit neatly into a
> generic mechanism.
You're delivering arbitrary packets to the device from userspace, and it
is returning arbitrary packets to userspace.
This is a familiar pattern... It is quite analagous to "send
vendor-specific commands from userspace to a drive"
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Keith Busch <keith.busch@intel.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] NVMe: Add a character device for each nvme device
Date: Fri, 27 Jul 2012 16:42:01 -0400 [thread overview]
Message-ID: <5012FD19.5090100@pobox.com> (raw)
In-Reply-To: <20120727202655.GP22985@linux.intel.com>
On 07/27/2012 04:26 PM, Matthew Wilcox wrote:
> Maybe we should design such a mechanism, but maybe we shouldn't ... as we
> find common things to do, we tend to move those to sysfs, not ioctls,
> and the kinds of commands that are being sent here are essentially
> vendor-specific NVMe commands; it's not clear they'd fit neatly into a
> generic mechanism.
You're delivering arbitrary packets to the device from userspace, and it
is returning arbitrary packets to userspace.
This is a familiar pattern... It is quite analagous to "send
vendor-specific commands from userspace to a drive"
Jeff
next prev parent reply other threads:[~2012-07-27 20:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 16:44 [PATCH] NVMe: Add a character device for each nvme device Keith Busch
2012-07-27 18:12 ` Matthew Wilcox
2012-07-27 18:12 ` Matthew Wilcox
2012-07-27 18:25 ` Greg KH
2012-07-27 18:25 ` Greg KH
2012-07-27 19:08 ` Matthew Wilcox
2012-07-27 19:08 ` Matthew Wilcox
2012-07-27 19:21 ` Greg KH
2012-07-27 19:21 ` Greg KH
2012-07-27 20:30 ` Matthew Wilcox
2012-07-27 20:30 ` Matthew Wilcox
2012-07-27 19:28 ` Jeff Garzik
2012-07-27 19:28 ` Jeff Garzik
2012-07-27 20:26 ` Matthew Wilcox
2012-07-27 20:26 ` Matthew Wilcox
2012-07-27 20:42 ` Jeff Garzik [this message]
2012-07-27 20:42 ` Jeff Garzik
2012-07-27 20:44 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2012-08-02 19:10 Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5012FD19.5090100@pobox.com \
--to=jgarzik@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.