From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
ben-linux@fluff.org, inki.dae@samsung.com, kgene.kim@samsung.com,
joshi@samsung.com, jg1.han@samsung.com
Subject: Re: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Mon, 30 Jul 2012 08:49:15 +0000 [thread overview]
Message-ID: <50164A8B.3070907@samsung.com> (raw)
In-Reply-To: <1343637905-17764-2-git-send-email-l.krishna@samsung.com>
Hi,
On 07/30/2012 10:45 AM, Leela Krishna Amudala wrote:
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 -------
> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 -----------------
> include/video/samsung_fimd.h | 533 +++++++++++++++++++++++
> 3 files changed, 533 insertions(+), 562 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> create mode 100644 include/video/samsung_fimd.h
Thanks for taking care if this. However you might need to split this
patch in two, so there is no build and git bisection breakage. In the
first patch a new header file would be added, then the patch updating
users of the FIMD headers would be applied, and finally the regs-fb*.h
files would be removed.
Also it helps to use -M option to git format-patch when creating patches
that mainly move files.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
ben-linux@fluff.org, inki.dae@samsung.com, kgene.kim@samsung.com,
joshi@samsung.com, jg1.han@samsung.com
Subject: Re: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Mon, 30 Jul 2012 10:49:15 +0200 [thread overview]
Message-ID: <50164A8B.3070907@samsung.com> (raw)
In-Reply-To: <1343637905-17764-2-git-send-email-l.krishna@samsung.com>
Hi,
On 07/30/2012 10:45 AM, Leela Krishna Amudala wrote:
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 -------
> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 -----------------
> include/video/samsung_fimd.h | 533 +++++++++++++++++++++++
> 3 files changed, 533 insertions(+), 562 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> create mode 100644 include/video/samsung_fimd.h
Thanks for taking care if this. However you might need to split this
patch in two, so there is no build and git bisection breakage. In the
first patch a new header file would be added, then the patch updating
users of the FIMD headers would be applied, and finally the regs-fb*.h
files would be removed.
Also it helps to use -M option to git format-patch when creating patches
that mainly move files.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Mon, 30 Jul 2012 10:49:15 +0200 [thread overview]
Message-ID: <50164A8B.3070907@samsung.com> (raw)
In-Reply-To: <1343637905-17764-2-git-send-email-l.krishna@samsung.com>
Hi,
On 07/30/2012 10:45 AM, Leela Krishna Amudala wrote:
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 -------
> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 -----------------
> include/video/samsung_fimd.h | 533 +++++++++++++++++++++++
> 3 files changed, 533 insertions(+), 562 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> create mode 100644 include/video/samsung_fimd.h
Thanks for taking care if this. However you might need to split this
patch in two, so there is no build and git bisection breakage. In the
first patch a new header file would be added, then the patch updating
users of the FIMD headers would be applied, and finally the regs-fb*.h
files would be removed.
Also it helps to use -M option to git format-patch when creating patches
that mainly move files.
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-07-30 8:49 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 8:45 [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-30 8:57 ` Leela Krishna Amudala
2012-07-30 8:45 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 1/3] Move FIMD register " Leela Krishna Amudala
2012-07-30 8:57 ` Leela Krishna Amudala
2012-07-30 8:45 ` Leela Krishna Amudala
2012-07-30 8:46 ` Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:49 ` Sylwester Nawrocki [this message]
2012-07-30 8:49 ` Sylwester Nawrocki
2012-07-30 8:49 ` Sylwester Nawrocki
2012-07-30 11:05 ` Leela Krishna Amudala
2012-07-30 11:17 ` Leela Krishna Amudala
2012-07-30 11:05 ` Leela Krishna Amudala
2012-07-30 8:53 ` Jingoo Han
2012-07-30 8:53 ` Jingoo Han
2012-07-30 8:53 ` Jingoo Han
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 11:16 ` Leela Krishna Amudala
2012-07-30 11:28 ` Leela Krishna Amudala
2012-07-30 11:16 ` Leela Krishna Amudala
2012-07-30 14:32 ` Tomasz Figa
2012-07-30 14:32 ` Tomasz Figa
2012-07-30 14:32 ` Tomasz Figa
2012-07-31 0:47 ` Jingoo Han
2012-07-31 0:47 ` Jingoo Han
2012-07-31 0:47 ` Jingoo Han
2012-07-31 6:28 ` Marek Szyprowski
2012-07-31 6:28 ` Marek Szyprowski
2012-07-31 6:28 ` Marek Szyprowski
2012-07-31 7:12 ` Leela Krishna Amudala
2012-07-31 7:24 ` Leela Krishna Amudala
2012-07-31 7:12 ` Leela Krishna Amudala
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:32 ` Marek Szyprowski
2012-07-31 8:32 ` Marek Szyprowski
2012-07-31 8:32 ` Marek Szyprowski
2012-08-01 1:56 ` Kukjin Kim
2012-08-01 1:56 ` Kukjin Kim
2012-08-01 1:56 ` Kukjin Kim
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 8:09 ` Jingoo Han
2012-07-31 8:09 ` Jingoo Han
2012-07-31 8:09 ` Jingoo Han
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim
2012-07-30 8:45 ` [PATCH 2/3] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-07-30 8:57 ` Leela Krishna Amudala
2012-07-30 8:45 ` Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 3/3] driver: " Leela Krishna Amudala
2012-07-30 8:57 ` Leela Krishna Amudala
2012-07-30 8:45 ` Leela Krishna Amudala
2012-07-30 8:48 ` Leela Krishna Amudala
2012-07-30 8:48 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-30 8:46 ` Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50164A8B.3070907@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.