From: Brian King <brking@linux.vnet.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Brian King <brking@us.ibm.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] [SCSI] ipr: missing unlock before a return
Date: Mon, 30 Jul 2012 12:33:33 +0000 [thread overview]
Message-ID: <50167F1D.5030406@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120730081635.GE15702@elgon.mountain>
On 07/30/2012 03:16 AM, Dan Carpenter wrote:
> We recently changed the locking in this function, but this return was
> missed. It needs an unlock and the IRQs need to be restored.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks for catching this.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Brian King <brking@linux.vnet.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Brian King <brking@us.ibm.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] [SCSI] ipr: missing unlock before a return
Date: Mon, 30 Jul 2012 07:33:33 -0500 [thread overview]
Message-ID: <50167F1D.5030406@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120730081635.GE15702@elgon.mountain>
On 07/30/2012 03:16 AM, Dan Carpenter wrote:
> We recently changed the locking in this function, but this return was
> missed. It needs an unlock and the IRQs need to be restored.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks for catching this.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2012-07-30 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 8:16 [patch 1/2] [SCSI] ipr: missing unlock before a return Dan Carpenter
2012-07-30 8:16 ` Dan Carpenter
2012-07-30 12:33 ` Brian King [this message]
2012-07-30 12:33 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50167F1D.5030406@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=JBottomley@parallels.com \
--cc=brking@us.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.