All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: <qiang.liu@freescale.com>
Cc: <linux-crypto@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
	"Ira W. Snyder" <iws@ovro.caltech.edu>,
	Vinod Koul <vinod.koul@intel.com>, <herbert@gondor.hengli.com.au>,
	Dan Williams <dan.j.williams@intel.com>,
	Li Yang <leoli@freescale.com>, <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self test interface
Date: Mon, 30 Jul 2012 12:48:41 -0500	[thread overview]
Message-ID: <5016C8F9.7070801@freescale.com> (raw)
In-Reply-To: <1343380616-12126-1-git-send-email-qiang.liu@freescale.com>

qiang.liu@freescale.com wrote:
> 
> Add memory copy self test when probe device, fsl-dma will be disabled
> if self test failed.

Is this a real problem that can occur?  The DMA driver used to have a
self-test, but I removed it a long time ago because it was pointless.  I
don't see why we need to add another one back in.

-- 
Timur Tabi
Linux kernel developer at Freescale

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: <qiang.liu@freescale.com>
Cc: "Ira W. Snyder" <iws@ovro.caltech.edu>,
	Vinod Koul <vinod.koul@intel.com>,
	herbert@gondor.hengli.com.au, linux-crypto@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [linuxppc-release] [PATCH v4 7/7] fsl-dma: add memcpy self test interface
Date: Mon, 30 Jul 2012 12:48:41 -0500	[thread overview]
Message-ID: <5016C8F9.7070801@freescale.com> (raw)
In-Reply-To: <1343380616-12126-1-git-send-email-qiang.liu@freescale.com>

qiang.liu@freescale.com wrote:
> 
> Add memory copy self test when probe device, fsl-dma will be disabled
> if self test failed.

Is this a real problem that can occur?  The DMA driver used to have a
self-test, but I removed it a long time ago because it was pointless.  I
don't see why we need to add another one back in.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-07-30 17:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27  9:16 [PATCH v4 7/7] fsl-dma: add memcpy self test interface qiang.liu
2012-07-27  9:16 ` qiang.liu
2012-07-30 17:48 ` Timur Tabi [this message]
2012-07-30 17:48   ` [linuxppc-release] " Timur Tabi
2012-07-30 18:33   ` Ira W. Snyder
2012-07-30 18:33     ` Ira W. Snyder
2012-07-31  2:47     ` Liu Qiang-B32616
2012-07-31  2:47       ` Liu Qiang-B32616

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5016C8F9.7070801@freescale.com \
    --to=timur@freescale.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=iws@ovro.caltech.edu \
    --cc=leoli@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=qiang.liu@freescale.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.