From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
kgene.kim@samsung.com, jg1.han@samsung.com, joshi@samsung.com,
dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
ben-linux@fluff.org, m.szyprowski@samsung.com
Subject: Re: [PATCH V2 2/5] include/video: Add Exynos5 specific FIMD register offsets
Date: Tue, 31 Jul 2012 13:03:47 +0000 [thread overview]
Message-ID: <5017D7B3.1080001@samsung.com> (raw)
In-Reply-To: <5017D4D7.3040303@mvista.com>
Hi,
On 07/31/2012 02:51 PM, Sergei Shtylyov wrote:
>> +/*EXYNOS5 FIMD REG OFFSET */
How about changing it to, e.g.
/* EXYNOS5 specific register offset definitions */
(but just in case you happen to resend this patch series)
>> +#define EXYNOS5_VIDTCON0 (0x20010)
>> +#define EXYNOS5_VIDTCON1 (0x20014)
>> +#define EXYNOS5_VIDTCON2 (0x20018)
>> +#define EXYNOS5_VIDTCON3 (0x2001C)
>> +#define EXYNOS5_VIDCON1 (0x20004)
>
> Parens not needed around simple literals.
Yes, I agree it looks insane. But, I think we could allow
this for consistency with the remaining definitions.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
kgene.kim@samsung.com, jg1.han@samsung.com, joshi@samsung.com,
dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
ben-linux@fluff.org, m.szyprowski@samsung.com
Subject: Re: [PATCH V2 2/5] include/video: Add Exynos5 specific FIMD register offsets
Date: Tue, 31 Jul 2012 15:03:47 +0200 [thread overview]
Message-ID: <5017D7B3.1080001@samsung.com> (raw)
In-Reply-To: <5017D4D7.3040303@mvista.com>
Hi,
On 07/31/2012 02:51 PM, Sergei Shtylyov wrote:
>> +/*EXYNOS5 FIMD REG OFFSET */
How about changing it to, e.g.
/* EXYNOS5 specific register offset definitions */
(but just in case you happen to resend this patch series)
>> +#define EXYNOS5_VIDTCON0 (0x20010)
>> +#define EXYNOS5_VIDTCON1 (0x20014)
>> +#define EXYNOS5_VIDTCON2 (0x20018)
>> +#define EXYNOS5_VIDTCON3 (0x2001C)
>> +#define EXYNOS5_VIDCON1 (0x20004)
>
> Parens not needed around simple literals.
Yes, I agree it looks insane. But, I think we could allow
this for consistency with the remaining definitions.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/5] include/video: Add Exynos5 specific FIMD register offsets
Date: Tue, 31 Jul 2012 15:03:47 +0200 [thread overview]
Message-ID: <5017D7B3.1080001@samsung.com> (raw)
In-Reply-To: <5017D4D7.3040303@mvista.com>
Hi,
On 07/31/2012 02:51 PM, Sergei Shtylyov wrote:
>> +/*EXYNOS5 FIMD REG OFFSET */
How about changing it to, e.g.
/* EXYNOS5 specific register offset definitions */
(but just in case you happen to resend this patch series)
>> +#define EXYNOS5_VIDTCON0 (0x20010)
>> +#define EXYNOS5_VIDTCON1 (0x20014)
>> +#define EXYNOS5_VIDTCON2 (0x20018)
>> +#define EXYNOS5_VIDTCON3 (0x2001C)
>> +#define EXYNOS5_VIDCON1 (0x20004)
>
> Parens not needed around simple literals.
Yes, I agree it looks insane. But, I think we could allow
this for consistency with the remaining definitions.
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-07-31 13:03 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 12:23 [PATCH V2 0/5] arm: samsung: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-07-31 12:23 ` [PATCH V2 1/5] include/video: Add samsung FIMD register header Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-08-01 2:10 ` Kukjin Kim
2012-08-01 2:10 ` Kukjin Kim
2012-08-01 2:10 ` Kukjin Kim
2012-07-31 12:23 ` [PATCH V2 2/5] include/video: Add Exynos5 specific FIMD register offsets Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-07-31 12:51 ` Sergei Shtylyov
2012-07-31 12:51 ` Sergei Shtylyov
2012-07-31 12:51 ` Sergei Shtylyov
2012-07-31 13:03 ` Sylwester Nawrocki [this message]
2012-07-31 13:03 ` Sylwester Nawrocki
2012-07-31 13:03 ` Sylwester Nawrocki
2012-08-01 1:49 ` Jingoo Han
2012-08-01 1:49 ` Jingoo Han
2012-08-01 1:49 ` Jingoo Han
2012-08-01 2:14 ` Kukjin Kim
2012-08-01 2:14 ` Kukjin Kim
2012-08-01 2:14 ` Kukjin Kim
2012-07-31 12:23 ` [PATCH V2 3/5] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-08-01 1:42 ` Jingoo Han
2012-08-01 1:42 ` Jingoo Han
2012-08-01 1:42 ` Jingoo Han
2012-08-01 2:19 ` Kukjin Kim
2012-08-01 2:19 ` Kukjin Kim
2012-08-01 2:19 ` Kukjin Kim
2012-07-31 12:23 ` [PATCH V2 4/5] driver: " Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-08-01 1:36 ` Jingoo Han
2012-08-01 1:36 ` Jingoo Han
2012-08-01 1:36 ` Jingoo Han
2012-08-01 2:20 ` Kukjin Kim
2012-08-01 2:20 ` Kukjin Kim
2012-08-01 2:20 ` Kukjin Kim
2012-07-31 12:23 ` [PATCH V2 5/5] arm: samsung: delete frame buffer header files from platform Leela Krishna Amudala
2012-07-31 12:35 ` Leela Krishna Amudala
2012-07-31 12:23 ` Leela Krishna Amudala
2012-08-01 2:04 ` Kukjin Kim
2012-08-01 2:04 ` Kukjin Kim
2012-08-01 2:04 ` Kukjin Kim
2012-08-01 3:20 ` Leela Krishna Amudala
2012-08-01 3:32 ` Leela Krishna Amudala
2012-08-01 3:20 ` Leela Krishna Amudala
2012-08-01 9:39 ` Kukjin Kim
2012-08-01 9:39 ` Kukjin Kim
2012-08-01 9:39 ` Kukjin Kim
2012-08-01 10:00 ` Sylwester Nawrocki
2012-08-01 10:00 ` Sylwester Nawrocki
2012-08-01 10:00 ` Sylwester Nawrocki
2012-08-01 10:09 ` Kukjin Kim
2012-08-01 10:09 ` Kukjin Kim
2012-08-01 10:09 ` Kukjin Kim
2012-08-01 2:28 ` [PATCH V2 0/5] arm: samsung: Move FIMD headers to include/video/ Kukjin Kim
2012-08-01 2:28 ` Kukjin Kim
2012-08-01 2:28 ` Kukjin Kim
2012-08-01 9:59 ` Florian Tobias Schandinat
2012-08-01 9:59 ` Florian Tobias Schandinat
2012-08-01 10:03 ` Kukjin Kim
2012-08-01 10:03 ` Kukjin Kim
2012-08-01 10:03 ` Kukjin Kim
2012-08-23 9:55 ` Kukjin Kim
2012-08-23 9:55 ` Kukjin Kim
2012-08-23 9:55 ` Kukjin Kim
2012-09-23 19:26 ` Florian Tobias Schandinat
2012-09-23 19:26 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017D7B3.1080001@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.