From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28
Date: Wed, 01 Aug 2012 09:46:45 +0000 [thread overview]
Message-ID: <5018FB05.3020902@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5AaLB5m7TYPC03wTSFTDUTFrtV4Xr6gHrvKuGnpyUsf8Q@mail.gmail.com>
Hi,
Le 31/07/2012 14:02, Fabio Estevam a écrit :
> On Tue, Jul 31, 2012 at 7:29 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>
>> + i2c0_pins_b: i2c0@1 {
>> + reg = <1>;
>> + fsl,pinmux-ids = <0x3001 0x3011>;
>
> Can you please also list the name of the pin as comment (just like you
> did for pwm4)?
>
> This would allow us to quickly identify the muxing option without the
> need of looking at the mxs pinctrl doc.
You're right, this will be in the next version.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28
Date: Wed, 01 Aug 2012 11:46:45 +0200 [thread overview]
Message-ID: <5018FB05.3020902@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5AaLB5m7TYPC03wTSFTDUTFrtV4Xr6gHrvKuGnpyUsf8Q@mail.gmail.com>
Hi,
Le 31/07/2012 14:02, Fabio Estevam a ?crit :
> On Tue, Jul 31, 2012 at 7:29 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>
>> + i2c0_pins_b: i2c0 at 1 {
>> + reg = <1>;
>> + fsl,pinmux-ids = <0x3001 0x3011>;
>
> Can you please also list the name of the pin as comment (just like you
> did for pwm4)?
>
> This would allow us to quickly identify the muxing option without the
> need of looking at the mxs pinctrl doc.
You're right, this will be in the next version.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-08-01 9:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 10:29 [PATCHv2 0/4] Add support for the OLED in the CFA10036 Maxime Ripard
2012-07-31 10:29 ` Maxime Ripard
2012-07-31 10:29 ` [PATCH 1/4] video: Add support for the Solomon SSD1307 OLED Controller Maxime Ripard
2012-07-31 10:29 ` Maxime Ripard
2012-07-31 15:41 ` Amarnath Revanna
2012-08-01 5:24 ` Shawn Guo
2012-08-01 5:24 ` Shawn Guo
2012-08-01 10:28 ` Maxime Ripard
2012-08-01 10:28 ` Maxime Ripard
2012-08-02 0:34 ` Shawn Guo
2012-08-02 0:34 ` Shawn Guo
2012-08-02 13:35 ` Maxime Ripard
2012-08-02 13:35 ` Maxime Ripard
2012-08-01 5:44 ` Jingoo Han
2012-08-01 5:44 ` Jingoo Han
2012-07-31 10:29 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-07-31 10:29 ` Maxime Ripard
2012-07-31 12:02 ` Fabio Estevam
2012-07-31 12:02 ` Fabio Estevam
2012-08-01 9:46 ` Maxime Ripard [this message]
2012-08-01 9:46 ` Maxime Ripard
2012-07-31 10:29 ` [PATCH 3/4] ARM: dts: mxs: Add pwm4 " Maxime Ripard
2012-07-31 10:29 ` Maxime Ripard
2012-07-31 10:29 ` [PATCH 4/4] ARM: dts: mxs: add oled support for the cfa-10036 Maxime Ripard
2012-07-31 10:29 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2012-08-23 8:42 [PATCHv3 0/4] Maxime Ripard
2012-08-23 8:42 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-08-23 8:42 ` Maxime Ripard
2012-08-23 14:33 ` Shawn Guo
2012-08-23 14:33 ` Shawn Guo
2012-07-17 15:59 [PATCH 0/4] Add support for the OLED in the CFA10036 Maxime Ripard
2012-07-17 15:59 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-07-17 15:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018FB05.3020902@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.