From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Tyler Hall <tylerwhall@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage
Date: Wed, 01 Aug 2012 16:03:17 +0300 [thread overview]
Message-ID: <50192915.8080203@redhat.com> (raw)
In-Reply-To: <CAJSP0QV_aZLQ37M0+d-8aVoru_w7kgLpg2Bi1qR-1b5VzUFLKg@mail.gmail.com>
On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote:
> On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 07/26/2012 01:45 AM, Tyler Hall wrote:
>>> subpage_register() expects "end" to be the last byte in the mapping.
>>> Registering a non-page-aligned memory region that extends up to or
>>> beyond a page boundary causes subpage_register() to silently fail
>>> through the (end >= PAGE_SIZE) check.
>>>
>>> This bug does not cause noticeable problems for mappings that do not
>>> extend to a page boundary, though they do register an extra byte.
>>
>> Reviewed-by: Avi Kivity <avi@redhat.com>
>
> Thanks Avi. Does this include Patch 2/2 too?
I reviewed that as well with similar results.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Tyler Hall <tylerwhall@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage
Date: Wed, 01 Aug 2012 16:03:17 +0300 [thread overview]
Message-ID: <50192915.8080203@redhat.com> (raw)
In-Reply-To: <CAJSP0QV_aZLQ37M0+d-8aVoru_w7kgLpg2Bi1qR-1b5VzUFLKg@mail.gmail.com>
On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote:
> On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 07/26/2012 01:45 AM, Tyler Hall wrote:
>>> subpage_register() expects "end" to be the last byte in the mapping.
>>> Registering a non-page-aligned memory region that extends up to or
>>> beyond a page boundary causes subpage_register() to silently fail
>>> through the (end >= PAGE_SIZE) check.
>>>
>>> This bug does not cause noticeable problems for mappings that do not
>>> extend to a page boundary, though they do register an extra byte.
>>
>> Reviewed-by: Avi Kivity <avi@redhat.com>
>
> Thanks Avi. Does this include Patch 2/2 too?
I reviewed that as well with similar results.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-01 13:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 22:45 [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Tyler Hall
2012-07-25 22:45 ` [Qemu-devel] " Tyler Hall
2012-07-25 22:45 ` [Qemu-trivial] [PATCH 2/2] exec.c: Use subpages for large unaligned mappings Tyler Hall
2012-07-25 22:45 ` [Qemu-devel] " Tyler Hall
2012-08-01 13:02 ` [Qemu-trivial] " Avi Kivity
2012-08-01 13:02 ` Avi Kivity
2012-08-01 10:42 ` [Qemu-trivial] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage Stefan Hajnoczi
2012-08-01 10:42 ` [Qemu-devel] " Stefan Hajnoczi
2012-08-01 12:52 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2012-08-01 12:52 ` [Qemu-devel] [Qemu-trivial] " Peter Maydell
2012-08-01 12:56 ` [Qemu-trivial] [Qemu-devel] " Avi Kivity
2012-08-01 12:56 ` Avi Kivity
2012-08-01 13:01 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-01 13:01 ` Stefan Hajnoczi
2012-08-01 13:03 ` Avi Kivity [this message]
2012-08-01 13:03 ` Avi Kivity
2012-08-03 9:55 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-03 9:55 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50192915.8080203@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.