Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On 07/31/2012 10:51 AM, Dong Xu Wang wrote:
> In add-cow file format, we will use path_has_protocol and we will read
> a NUL-terminated string from image , qed_read_string has done the samething,

s/image ,/image,/
s/samething/same thing/

> so make the two functions public, then we will reuse them directly.
> 
> While creating images files, if no size is specified, will use size of backing
> file. If no backing file is specified, we will use the size of image file.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
>  block.c     |   37 +++++++++++++++++++++++++++++++++----
>  block.h     |    3 +++
>  block/qed.c |   29 +----------------------------
>  3 files changed, 37 insertions(+), 32 deletions(-)
> 
> +    /* The size for the image must always be specified, with one exception:
> +     If we are using a backing file, we can obtain the size from there,
> +     but if not, and we are using an image file, we will obtain the size from it.*/

grammar:
The size for the image must be known, either by direct specification, or
by reading it from a backing file or image file.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]