Re: [Qemu-devel] [PATCH 3/6] add-cow file format

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On 07/31/2012 10:51 AM, Dong Xu Wang wrote:
> This is the implementation code for add-cow file format. Because image_file
> might be very huge, then we can't read entire bitmap into memory, we must use
> a cache. Since qcow-cache.c has implemted cache code, we can create our cache

s/implemted/implemented/

> code based on it.

Just wondering if Paolo's HBitmap code for drive-mirror might be a more
efficient way to implement your caching.

> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
>  block/Makefile.objs   |    1 +
>  block/add-cow-cache.c |  206 +++++++++++++++++
>  block/add-cow.c       |  599 +++++++++++++++++++++++++++++++++++++++++++++++++
>  block/add-cow.h       |  101 +++++++++
>  block_int.h           |    2 +

Rather than adding a new implementation for code duplication, can you
refactor the existing implementation to be reusable, and update
qcow-cache.c to call into the common refactored code?

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]