From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] exec.c: Remove out of date comment
Date: Wed, 01 Aug 2012 17:05:15 +0300 [thread overview]
Message-ID: <5019379B.5080206@redhat.com> (raw)
In-Reply-To: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org>
On 08/01/2012 04:35 PM, Peter Maydell wrote:
> Remove an out of date comment: this comment used to be attached to
> cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally
> inserted a couple of other functions between the comment and its function.
> It is in any case obsolete since (a) the function arguments it refers
> to have been replaced with a single MemoryRegionSection* argument and
> (b) the inability to handle regions whose offset_within_address_space
> and offset_within_region aren't equally aligned was fixed as part of
> the rewrite of this code.
(c) it doesn't use the conventional block comment style.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Pretty sure my analysis is right and this comment is out of date --
> Avi, could you confirm that please?
Yes, you are correct.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] exec.c: Remove out of date comment
Date: Wed, 01 Aug 2012 17:05:15 +0300 [thread overview]
Message-ID: <5019379B.5080206@redhat.com> (raw)
In-Reply-To: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org>
On 08/01/2012 04:35 PM, Peter Maydell wrote:
> Remove an out of date comment: this comment used to be attached to
> cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally
> inserted a couple of other functions between the comment and its function.
> It is in any case obsolete since (a) the function arguments it refers
> to have been replaced with a single MemoryRegionSection* argument and
> (b) the inability to handle regions whose offset_within_address_space
> and offset_within_region aren't equally aligned was fixed as part of
> the rewrite of this code.
(c) it doesn't use the conventional block comment style.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Pretty sure my analysis is right and this comment is out of date --
> Avi, could you confirm that please?
Yes, you are correct.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-01 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 13:35 [Qemu-trivial] [PATCH] exec.c: Remove out of date comment Peter Maydell
2012-08-01 13:35 ` [Qemu-devel] " Peter Maydell
2012-08-01 14:05 ` Avi Kivity [this message]
2012-08-01 14:05 ` Avi Kivity
2012-08-01 14:17 ` [Qemu-trivial] " Peter Maydell
2012-08-01 14:17 ` [Qemu-devel] " Peter Maydell
2012-08-01 14:20 ` [Qemu-trivial] " Avi Kivity
2012-08-01 14:20 ` [Qemu-devel] " Avi Kivity
2012-08-03 9:56 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-03 9:56 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5019379B.5080206@redhat.com \
--to=avi@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.