All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: mingo@elte.hu, gorcunov@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: don't bother tracking is_dir
Date: Wed, 01 Aug 2012 20:10:00 +0200	[thread overview]
Message-ID: <501970F8.8060705@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1207310924410.2405@tux.localdomain>

On 07/31/2012 08:24 AM, Pekka Enberg wrote:
> On Sun, 22 Jul 2012, Sasha Levin wrote:
>> This is something we can calculate on the fly, and doesn't justify the overhead
>> of tracking it all over fid transitions.
>>
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> 
> What kind of overhead are you talking about?

Having to carry it between fids when they are copied/created.

This flag is required in only about 2-3 spots, and I've stumbled on a bunch of issues when writing the dynamic fid allocation due to failure to copy this flag over only when required.


      reply	other threads:[~2012-08-01 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 16:29 [PATCH] kvm tools: dynamically allocate p9 fids Sasha Levin
2012-07-22 16:29 ` [PATCH] kvm tools: support injecting arbitrary sysrqs Sasha Levin
2012-07-22 16:29 ` [PATCH] kvm tools: remove unused field from virtio-blk Sasha Levin
2012-07-22 16:29 ` [PATCH] kvm tools: use correct error value for virtio-9p RLERROR Sasha Levin
2012-07-22 16:29 ` [PATCH] kvm tools: don't bother tracking is_dir Sasha Levin
2012-07-31  6:24   ` Pekka Enberg
2012-08-01 18:10     ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501970F8.8060705@gmail.com \
    --to=levinsasha928@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.