[uml-devel] [PATCH] um: fix missing include with glibc 2.16

[uml-devel] [PATCH] um: fix missing include with glibc 2.16

[Vianney le Clément de Saint-Marcq]

From: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>

As of glibc 2.16, sys/wait.h does no longer include sys/resource.h,
which is needed for getrlimit(). This patch fixes compiling UML with
glibc 2.16.

Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
---
--- linux-3.5/arch/um/os-Linux/start_up.c.orig	2012-07-21 22:58:29.000000000 +0200
+++ linux-3.5/arch/um/os-Linux/start_up.c	2012-07-30 15:39:22.771190664 +0200
@@ -13,6 +13,7 @@
 #include <signal.h>
 #include <string.h>
 #include <sys/mman.h>
+#include <sys/resource.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <asm/unistd.h>

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um: fix missing include with glibc 2.16

[Richard Weinberger]

On 31.07.2012 10:28, Vianney le Clément de Saint-Marcq wrote:
> From: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
>
> As of glibc 2.16, sys/wait.h does no longer include sys/resource.h,
> which is needed for getrlimit(). This patch fixes compiling UML with
> glibc 2.16.
>
> Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>

Sorry, I cannot apply this patch.
It's base64 encoded.

Can you please send it using git?

Thanks,
//richard


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um: fix missing include with glibc 2.16

[Vianney le Clément]

On Thu, Aug 2, 2012 at 12:51 AM, Richard Weinberger
<richard@sigma-star.at> wrote:
> On 31.07.2012 10:28, Vianney le Clément de Saint-Marcq wrote:
>>
>> From: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
>>
>> As of glibc 2.16, sys/wait.h does no longer include sys/resource.h,
>> which is needed for getrlimit(). This patch fixes compiling UML with
>> glibc 2.16.
>>
>> Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
>
>
> Sorry, I cannot apply this patch.
> It's base64 encoded.
>
> Can you please send it using git?

Weird, I used heirloom-mailx to try to avoid such problems. I'll try
to resend the patch using git and another smtp server.

Vianney

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um: fix missing include with glibc 2.16

[richard -rw- weinberger]

On Thu, Aug 2, 2012 at 8:53 AM, Vianney le Clément <vleclement@gmail.com> wrote:
> On Thu, Aug 2, 2012 at 12:51 AM, Richard Weinberger
> <richard@sigma-star.at> wrote:
>> On 31.07.2012 10:28, Vianney le Clément de Saint-Marcq wrote:
>>>
>>> From: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
>>>
>>> As of glibc 2.16, sys/wait.h does no longer include sys/resource.h,
>>> which is needed for getrlimit(). This patch fixes compiling UML with
>>> glibc 2.16.
>>>
>>> Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
>>
>>
>> Sorry, I cannot apply this patch.
>> It's base64 encoded.
>>
>> Can you please send it using git?
>
> Weird, I used heirloom-mailx to try to avoid such problems. I'll try
> to resend the patch using git and another smtp server.

As it's a trivial patch you can also send it s attachment.
(If nothing else works)

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um: fix missing include with glibc 2.16

[Vianney le Clément]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Thu, Aug 2, 2012 at 9:42 AM, richard -rw- weinberger
<richard.weinberger@gmail.com> wrote:
> As it's a trivial patch you can also send it s attachment.
> (If nothing else works)

Hi Richard,

Did you receive the patch sent by git? In any case, I have attached it
to this mail.

Vianney

[-- Attachment #2: glibc2.16.patch --]
[-- Type: application/octet-stream, Size: 727 bytes --]

The POSIX manpage for getrlimit(3) requires sys/resource.h to be
included. This header used to be included by sys/wait.h in glibc.
As of glibc 2.16 however, this is not the case anymore, thus breaking
the compilation.

Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
---
 arch/um/os-Linux/start_up.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/os-Linux/start_up.c b/arch/um/os-Linux/start_up.c
index 425162e..67704ab 100644
--- a/arch/um/os-Linux/start_up.c
+++ b/arch/um/os-Linux/start_up.c
@@ -13,6 +13,7 @@
 #include <signal.h>
 #include <string.h>
 #include <sys/mman.h>
+#include <sys/resource.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <asm/unistd.h>
-- 
1.7.11.4

[-- Attachment #3: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #4: Type: text/plain, Size: 194 bytes --]

_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [PATCH] um: fix missing include with glibc 2.16

[richard -rw- weinberger]

On Fri, Aug 3, 2012 at 3:51 PM, Vianney le Clément <vleclement@gmail.com> wrote:
> On Thu, Aug 2, 2012 at 9:42 AM, richard -rw- weinberger
> <richard.weinberger@gmail.com> wrote:
>> As it's a trivial patch you can also send it s attachment.
>> (If nothing else works)
>
> Hi Richard,
>
> Did you receive the patch sent by git? In any case, I have attached it
> to this mail.
>

Yep. :)
So far I had no time to test it, but it's already in my local patch queue.

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[uml-devel] [PATCH] um: fix missing include with glibc 2.16

[Vianney le Clément de Saint-Marcq]

The POSIX manpage for getrlimit(3) requires sys/resource.h to be
included. This header used to be included by sys/wait.h in glibc.
As of glibc 2.16 however, this is not the case anymore, thus breaking
the compilation.

Signed-off-by: Vianney le Clément de Saint-Marcq <vleclement@gmail.com>
---
 arch/um/os-Linux/start_up.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/um/os-Linux/start_up.c b/arch/um/os-Linux/start_up.c
index 425162e..67704ab 100644
--- a/arch/um/os-Linux/start_up.c
+++ b/arch/um/os-Linux/start_up.c
@@ -13,6 +13,7 @@
 #include <signal.h>
 #include <string.h>
 #include <sys/mman.h>
+#include <sys/resource.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <asm/unistd.h>
-- 
1.7.11.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel