All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fan Du <fan.du@windriver.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Fan Du <fdu@windriver.com>, <ralf@linux-mips.org>,
	<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>,
	vincent wen <vincentwenlinux@gmail.com>
Subject: Re: [PATCH] MIPS: oops when show backtrace of all active cpu
Date: Thu, 2 Aug 2012 12:45:11 +0800	[thread overview]
Message-ID: <501A05D7.5060005@windriver.com> (raw)
In-Reply-To: <CAJiQ=7Abc2sR2E2FXmeTr_Hc+CWH+J25=juB3wL172Tn6-PYuA@mail.gmail.com>



On 2012年08月02日 12:18, Kevin Cernekee wrote:
> On Wed, Aug 1, 2012 at 8:31 PM, Fan Du<fdu@windriver.com>  wrote:
>> show_backtrace must have an valid task when calling unwind_stack,
>> so fix it by checking first.
> [...]
>> --- a/arch/mips/kernel/traps.c
>> +++ b/arch/mips/kernel/traps.c
>> @@ -151,6 +151,10 @@ static void show_backtrace(struct task_struct *task, const struct pt_regs *regs)
>>                  show_raw_backtrace(sp);
>>                  return;
>>          }
>> +
>> +       if (task == NULL)
>> +               task = current;
>> +
>>          printk("Call Trace:\n");
>>          do {
>>                  print_ip_sym(pc);
>
> FYI, a slightly different version of this change was accepted:
>
> https://patchwork.linux-mips.org/patch/3524/
>
>

Oh, Looks like I'm late :)
thanks anyway.


-- 

Love each day!
--fan

WARNING: multiple messages have this Message-ID (diff)
From: Fan Du <fan.du@windriver.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Fan Du <fdu@windriver.com>,
	ralf@linux-mips.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org,
	vincent wen <vincentwenlinux@gmail.com>
Subject: Re: [PATCH] MIPS: oops when show backtrace of all active cpu
Date: Thu, 2 Aug 2012 12:45:11 +0800	[thread overview]
Message-ID: <501A05D7.5060005@windriver.com> (raw)
Message-ID: <20120802044511.1kzH_Tv9ihzDeNDk3OQDlBr_2EHGtTC9a8JenIqiyE8@z> (raw)
In-Reply-To: <CAJiQ=7Abc2sR2E2FXmeTr_Hc+CWH+J25=juB3wL172Tn6-PYuA@mail.gmail.com>



On 2012年08月02日 12:18, Kevin Cernekee wrote:
> On Wed, Aug 1, 2012 at 8:31 PM, Fan Du<fdu@windriver.com>  wrote:
>> show_backtrace must have an valid task when calling unwind_stack,
>> so fix it by checking first.
> [...]
>> --- a/arch/mips/kernel/traps.c
>> +++ b/arch/mips/kernel/traps.c
>> @@ -151,6 +151,10 @@ static void show_backtrace(struct task_struct *task, const struct pt_regs *regs)
>>                  show_raw_backtrace(sp);
>>                  return;
>>          }
>> +
>> +       if (task == NULL)
>> +               task = current;
>> +
>>          printk("Call Trace:\n");
>>          do {
>>                  print_ip_sym(pc);
>
> FYI, a slightly different version of this change was accepted:
>
> https://patchwork.linux-mips.org/patch/3524/
>
>

Oh, Looks like I'm late :)
thanks anyway.


-- 

Love each day!
--fan

  reply	other threads:[~2012-08-02  4:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02  3:31 [PATCH] MIPS: oops when show backtrace of all active cpu Fan Du
2012-08-02  3:31 ` Fan Du
2012-08-02  4:18 ` Kevin Cernekee
2012-08-02  4:45   ` Fan Du [this message]
2012-08-02  4:45     ` Fan Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501A05D7.5060005@windriver.com \
    --to=fan.du@windriver.com \
    --cc=cernekee@gmail.com \
    --cc=fdu@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=vincentwenlinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.