From: Asias He <asias@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk
Date: Thu, 02 Aug 2012 14:28:16 +0800 [thread overview]
Message-ID: <501A1E00.2010605@redhat.com> (raw)
In-Reply-To: <20120730134424.GC6041@lst.de>
On 07/30/2012 09:44 PM, Christoph Hellwig wrote:
> On Mon, Jul 30, 2012 at 09:31:06AM +0200, Paolo Bonzini wrote:
>> You only need to add REQ_FLUSH support. The virtio-blk protocol does
>> not support REQ_FUA, because there's no easy way to do it in userspace.
>
> A bio-based driver needs to handle both REQ_FLUSH and REQ_FUA as it does
> not get the sequencing of REQ_FUA into REQ_FLUSH that request based drivers
> can request. To what the REQ_FUA request gets translated is a different story.
I just sent out V5 to support both REQ_FLUSH AND REQ_FUA.
Thanks, Christoph!
--
Asias
WARNING: multiple messages have this Message-ID (diff)
From: Asias He <asias@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk
Date: Thu, 02 Aug 2012 14:28:16 +0800 [thread overview]
Message-ID: <501A1E00.2010605@redhat.com> (raw)
In-Reply-To: <20120730134424.GC6041@lst.de>
On 07/30/2012 09:44 PM, Christoph Hellwig wrote:
> On Mon, Jul 30, 2012 at 09:31:06AM +0200, Paolo Bonzini wrote:
>> You only need to add REQ_FLUSH support. The virtio-blk protocol does
>> not support REQ_FUA, because there's no easy way to do it in userspace.
>
> A bio-based driver needs to handle both REQ_FLUSH and REQ_FUA as it does
> not get the sequencing of REQ_FUA into REQ_FLUSH that request based drivers
> can request. To what the REQ_FUA request gets translated is a different story.
I just sent out V5 to support both REQ_FLUSH AND REQ_FUA.
Thanks, Christoph!
--
Asias
next prev parent reply other threads:[~2012-08-02 6:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 8:38 [PATCH V3 0/3] Improve virtio-blk performance Asias He
2012-07-13 8:38 ` Asias He
2012-07-13 8:38 ` [PATCH V3 1/3] block: Introduce __blk_segment_map_sg() helper Asias He
2012-07-13 8:38 ` [PATCH V3 2/3] block: Add blk_bio_map_sg() helper Asias He
2012-07-13 8:38 ` Asias He
2012-07-13 8:38 ` [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk Asias He
2012-07-13 8:38 ` Asias He
2012-07-27 0:33 ` Rusty Russell
2012-07-27 0:33 ` Rusty Russell
2012-07-28 2:38 ` Asias He
2012-07-28 2:38 ` Asias He
2012-07-28 6:42 ` Paolo Bonzini
2012-07-28 6:42 ` Paolo Bonzini
2012-07-30 4:43 ` Asias He
2012-07-30 4:43 ` Asias He
2012-07-30 7:31 ` Paolo Bonzini
2012-07-30 7:31 ` Paolo Bonzini
2012-07-30 13:44 ` Christoph Hellwig
2012-07-30 13:44 ` Christoph Hellwig
2012-08-02 6:28 ` Asias He [this message]
2012-08-02 6:28 ` Asias He
2012-07-30 13:43 ` Christoph Hellwig
2012-07-30 13:43 ` Christoph Hellwig
2012-07-31 8:43 ` Asias He
2012-07-31 8:43 ` Asias He
2012-07-29 12:59 ` Michael S. Tsirkin
2012-07-29 12:59 ` Michael S. Tsirkin
2012-07-30 0:26 ` Asias He
2012-07-30 0:26 ` Asias He
2012-07-27 6:29 ` Rusty Russell
2012-07-27 6:29 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A1E00.2010605@redhat.com \
--to=asias@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.