From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH] regulator: tps6586x: add support for SYS rail
Date: Thu, 02 Aug 2012 10:44:05 -0600 [thread overview]
Message-ID: <501AAE55.3080504@wwwdotorg.org> (raw)
In-Reply-To: <1343906193-8309-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 08/02/2012 05:16 AM, Laxman Dewangan wrote:
> Device have SYS rail which is always ON. It is system
> power bus. LDO5 and LDO_RTC get powered through this rail
> internally. Add support for this rail and make the
> LDO5/LDO_RTC input supply to "sys".
> Update document accordingly.
I believe you need to following patch on top of this, or the sys-supply
property is not used:
> diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
> index 0c15ef8..a0ddc9f 100644
> --- a/drivers/regulator/tps6586x-regulator.c
> +++ b/drivers/regulator/tps6586x-regulator.c
> @@ -258,6 +258,7 @@ static const unsigned int tps6586x_dvm_voltages[] = {
> #define TPS6586X_SYS_REGULATOR() \
> { \
> .desc = { \
> + .supply_name = "sys", \
> .name = "REG-SYS", \
> .ops = &tps6586x_sys_regulator_ops, \
> .type = REGULATOR_VOLTAGE, \
BTW, this patch touches both the regulator and MFD trees. I'm not sure
who will apply it. I think it relies on the patch to this driver Mark
recently applied in the regulator tree (for 3.7 I think) doesn't it, at
least for context?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
swarren@nvidia.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] regulator: tps6586x: add support for SYS rail
Date: Thu, 02 Aug 2012 10:44:05 -0600 [thread overview]
Message-ID: <501AAE55.3080504@wwwdotorg.org> (raw)
In-Reply-To: <1343906193-8309-1-git-send-email-ldewangan@nvidia.com>
On 08/02/2012 05:16 AM, Laxman Dewangan wrote:
> Device have SYS rail which is always ON. It is system
> power bus. LDO5 and LDO_RTC get powered through this rail
> internally. Add support for this rail and make the
> LDO5/LDO_RTC input supply to "sys".
> Update document accordingly.
I believe you need to following patch on top of this, or the sys-supply
property is not used:
> diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
> index 0c15ef8..a0ddc9f 100644
> --- a/drivers/regulator/tps6586x-regulator.c
> +++ b/drivers/regulator/tps6586x-regulator.c
> @@ -258,6 +258,7 @@ static const unsigned int tps6586x_dvm_voltages[] = {
> #define TPS6586X_SYS_REGULATOR() \
> { \
> .desc = { \
> + .supply_name = "sys", \
> .name = "REG-SYS", \
> .ops = &tps6586x_sys_regulator_ops, \
> .type = REGULATOR_VOLTAGE, \
BTW, this patch touches both the regulator and MFD trees. I'm not sure
who will apply it. I think it relies on the patch to this driver Mark
recently applied in the regulator tree (for 3.7 I think) doesn't it, at
least for context?
next prev parent reply other threads:[~2012-08-02 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 11:16 [PATCH] regulator: tps6586x: add support for SYS rail Laxman Dewangan
2012-08-02 11:16 ` Laxman Dewangan
2012-08-02 11:40 ` Mark Brown
2012-08-02 11:51 ` Laxman Dewangan
2012-08-02 16:10 ` Mark Brown
[not found] ` <1343906193-8309-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-08-02 16:44 ` Stephen Warren [this message]
2012-08-02 16:44 ` Stephen Warren
2012-08-03 6:09 ` Laxman Dewangan
2012-08-04 0:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501AAE55.3080504@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.