Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table

["Andreas Färber" <afaerber@suse.de>]

Am 03.08.2012 15:32, schrieb Luiz Capitulino:
> On Fri,  3 Aug 2012 10:48:40 +0800
> Amos Kong <akong@redhat.com> wrote:
> 
>> key_defs[] in monitor.c is a mapping table of keys and keycodes,
>> this patch added a QKeyCode enum and a new key_defs table,
>> Key's index in the enmu is same as keycode's index in new key_defs[].
>>
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> ---
>>  input.c          |  146 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  qapi-schema.json |   26 ++++++++++
>>  2 files changed, 172 insertions(+), 0 deletions(-)
>>
>> diff --git a/input.c b/input.c
>> index 6968b31..680d756 100644
>> --- a/input.c
>> +++ b/input.c
>> @@ -37,6 +37,152 @@ static QTAILQ_HEAD(, QEMUPutMouseEntry) mouse_handlers =
>>  static NotifierList mouse_mode_notifiers = 
>>      NOTIFIER_LIST_INITIALIZER(mouse_mode_notifiers);
>>  
>> +static const int key_defs[] = {
> 
> Weird, I expected this would brake the build, as the new table is unused.

That's a side effect of 'const'.

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg