All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: torvalds@linux-foundation.org, tj@kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, paul.gortmaker@windriver.com,
	davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu,
	ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [RFC v2 7/7] net,9p: use new hashtable implementation
Date: Fri, 03 Aug 2012 23:14:19 +0200	[thread overview]
Message-ID: <501C3F2B.7080004@gmail.com> (raw)
In-Reply-To: <1344016851.9299.1415.camel@edumazet-glaptop>

On 08/03/2012 08:00 PM, Eric Dumazet wrote:
> On Fri, 2012-08-03 at 16:23 +0200, Sasha Levin wrote:
>>  	/* initialize hash table */
>> -	for (bucket = 0; bucket < ERRHASHSZ; bucket++)
>> -		INIT_HLIST_HEAD(&hash_errmap[bucket]);
>> +	hash_init(&hash_errmap, ERRHASHSZ);
> 
> Why is hash_init() even needed ?
> 
> If hash is "DEFINE_STATIC_HASHTABLE(...)", its already ready for use !

Indeed it is.

I've removed it, and then decided to put it back since the definition of the hashtable isn't fully cooked yet, and I didn't want to miss this initialization point if it turn out we need to initialize that hashtable afterall.

I will remove it once the hashtable definitions are clear.

The rest of the review comments will be addressed.

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <levinsasha928@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: torvalds@linux-foundation.org, tj@kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, paul.gortmaker@windriver.com,
	davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu,
	ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [RFC v2 7/7] net,9p: use new hashtable implementation
Date: Fri, 03 Aug 2012 23:14:19 +0200	[thread overview]
Message-ID: <501C3F2B.7080004@gmail.com> (raw)
In-Reply-To: <1344016851.9299.1415.camel@edumazet-glaptop>

On 08/03/2012 08:00 PM, Eric Dumazet wrote:
> On Fri, 2012-08-03 at 16:23 +0200, Sasha Levin wrote:
>>  	/* initialize hash table */
>> -	for (bucket = 0; bucket < ERRHASHSZ; bucket++)
>> -		INIT_HLIST_HEAD(&hash_errmap[bucket]);
>> +	hash_init(&hash_errmap, ERRHASHSZ);
> 
> Why is hash_init() even needed ?
> 
> If hash is "DEFINE_STATIC_HASHTABLE(...)", its already ready for use !

Indeed it is.

I've removed it, and then decided to put it back since the definition of the hashtable isn't fully cooked yet, and I didn't want to miss this initialization point if it turn out we need to initialize that hashtable afterall.

I will remove it once the hashtable definitions are clear.

The rest of the review comments will be addressed.

Thanks!

  reply	other threads:[~2012-08-03 21:13 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 14:23 [RFC v2 0/7] generic hashtable implementation Sasha Levin
2012-08-03 14:23 ` Sasha Levin
2012-08-03 14:23 ` [RFC v2 1/7] hashtable: introduce a small and naive hashtable Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-03 17:15   ` Tejun Heo
2012-08-03 17:15     ` Tejun Heo
2012-08-03 17:16     ` Tejun Heo
2012-08-03 17:16       ` Tejun Heo
2012-08-03 21:19     ` Sasha Levin
2012-08-03 21:19       ` Sasha Levin
2012-08-03 21:30       ` Tejun Heo
2012-08-03 21:30         ` Tejun Heo
2012-08-03 21:36         ` Sasha Levin
2012-08-03 21:36           ` Sasha Levin
2012-08-03 21:44           ` Tejun Heo
2012-08-03 21:44             ` Tejun Heo
2012-08-03 21:41         ` Sasha Levin
2012-08-03 21:41           ` Sasha Levin
2012-08-03 21:48           ` Tejun Heo
2012-08-03 21:48             ` Tejun Heo
2012-08-03 22:20             ` Sasha Levin
2012-08-03 22:20               ` Sasha Levin
2012-08-03 22:23               ` Tejun Heo
2012-08-03 22:23                 ` Tejun Heo
2012-08-03 22:26                 ` Sasha Levin
2012-08-03 22:26                   ` Sasha Levin
2012-08-03 22:29                 ` Linus Torvalds
2012-08-03 22:29                   ` Linus Torvalds
2012-08-03 22:36                   ` Tejun Heo
2012-08-03 22:36                     ` Tejun Heo
2012-08-03 23:47                     ` Linus Torvalds
2012-08-03 23:47                       ` Linus Torvalds
2012-08-04  0:03                       ` Sasha Levin
2012-08-04  0:03                         ` Sasha Levin
2012-08-04  0:05                         ` Linus Torvalds
2012-08-04  0:05                           ` Linus Torvalds
2012-08-04  0:33                           ` Sasha Levin
2012-08-04  0:33                             ` Sasha Levin
2012-08-04  0:05                       ` Tejun Heo
2012-08-04  0:05                         ` Tejun Heo
2012-08-03 17:39   ` Eric Dumazet
2012-08-03 17:39     ` Eric Dumazet
2012-08-03 14:23 ` [RFC v2 2/7] user_ns: use new hashtable implementation Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-05  0:58   ` Eric W. Biederman
2012-08-05  0:58     ` Eric W. Biederman
2012-08-03 14:23 ` [RFC v2 3/7] mm,ksm: " Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-03 14:23 ` [RFC v2 4/7] workqueue: " Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-03 14:23 ` [RFC v2 5/7] mm/huge_memory: " Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-03 14:23 ` [RFC v2 6/7] tracepoint: " Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-05  0:36   ` Steven Rostedt
2012-08-05  0:36     ` Steven Rostedt
2012-08-05 16:31     ` Mathieu Desnoyers
2012-08-05 16:31       ` Mathieu Desnoyers
2012-08-05 17:03       ` Sasha Levin
2012-08-05 17:03         ` Sasha Levin
2012-08-05 17:12         ` Mathieu Desnoyers
2012-08-05 17:12           ` Mathieu Desnoyers
2012-08-03 14:23 ` [RFC v2 7/7] net,9p: " Sasha Levin
2012-08-03 14:23   ` Sasha Levin
2012-08-03 18:00   ` Eric Dumazet
2012-08-03 18:00     ` Eric Dumazet
2012-08-03 21:14     ` Sasha Levin [this message]
2012-08-03 21:14       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501C3F2B.7080004@gmail.com \
    --to=levinsasha928@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ericvh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.