All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gstreamer: gst-ffmpeg: fix build issues for libav
Date: Sat, 04 Aug 2012 14:57:20 -0400	[thread overview]
Message-ID: <501D7090.2040500@gmail.com> (raw)
In-Reply-To: <1343942157-15997-1-git-send-email-yao.zhao@windriver.com>

On 02/08/2012 5:15 PM, Yao Zhao wrote:
> 1.The included libav configure is not generated by autotools
>   patch use-correct-toolchain.patch patched its configure to
> use correct toolchain wrapper.

Why are you patching the toolchain instead of passing the correct parameters
to configure (--enable-cross-compile, --cross-prefix-..., etc)?

> 2.add bzip2 dependency explicitly.
>   or configure will detect whether libbz2 is installed, if bzip2
> is triggered earlier then it will be detected, if not then won't

Looks OK.

> 3.detect whether toolchain supports altivec, if not then add
> disable-altivec to libav's configure line or configure will fail

Wrong fix.

http://git.libav.org/?p=libav.git;a=blob;f=configure;h=b139008d2b1aa5faea3f33c2a1922d0e1cb1fa5c;hb=HEAD#l2318

It should be fixed by passing the proper CPU to libav's configure as an argument.

> 4.move the GSTREAMER_DEBUG to libav's configure, it is not the
> option for the main configure.

OK.

- Derek



  reply	other threads:[~2012-08-04 19:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 21:15 [PATCH] gstreamer: gst-ffmpeg: fix build issues for libav Yao Zhao
2012-08-04 18:57 ` Derek Buitenhuis [this message]
2012-08-05 11:52   ` Koen Kooi
2012-08-05 16:27     ` Derek Buitenhuis
2012-08-05 17:31       ` Koen Kooi
2012-08-05 19:11         ` Khem Raj
2012-08-05 22:16           ` Derek Buitenhuis
2012-08-07 15:24   ` Yao Zhao
2012-08-07 17:00     ` Derek Buitenhuis
2012-08-07 20:06       ` Derek Buitenhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501D7090.2040500@gmail.com \
    --to=derek.buitenhuis@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.