Re: [PATCH] gstreamer: gst-ffmpeg: fix build issues for libav

[Yao Zhao <yao.zhao@windriver.com>]

On 12-08-04 02:57 PM, Derek Buitenhuis wrote:
> On 02/08/2012 5:15 PM, Yao Zhao wrote:
>> 1.The included libav configure is not generated by autotools
>>    patch use-correct-toolchain.patch patched its configure to
>> use correct toolchain wrapper.
> Why are you patching the toolchain instead of passing the correct parameters
> to configure (--enable-cross-compile, --cross-prefix-..., etc)?
in the configure,
ar_default="${cross_prefix}${ar_default}"
cc_default="${cross_prefix}${cc_default}"
nm_default="${cross_prefix}${nm_default}"
pkg_config_default="${cross_prefix}${pkg_config_default}"
ranlib="${cross_prefix}${ranlib}"

cc_default is the gcc so cc_default will be for example: 
powerpc-xxx-gcc, it won't use the toolcain wrapper.

I will try whether command line will solve these too.

>> 2.add bzip2 dependency explicitly.
>>    or configure will detect whether libbz2 is installed, if bzip2
>> is triggered earlier then it will be detected, if not then won't
> Looks OK.
>
>> 3.detect whether toolchain supports altivec, if not then add
>> disable-altivec to libav's configure line or configure will fail
> Wrong fix.
>
> http://git.libav.org/?p=libav.git;a=blob;f=configure;h=b139008d2b1aa5faea3f33c2a1922d0e1cb1fa5c;hb=HEAD#l2318
>
> It should be fixed by passing the proper CPU to libav's configure as an argument.

         e500v2)
             cpuflags="-mcpu=8548 -mhard-float -mfloat-gprs=double"
             disable altivec
         ;;
         e500)
             cpuflags="-mcpu=8540 -mhard-float"
             disable altivec
         ;;

I am fixing for e500mc which is not a case here and I am not sure what 
exactly the cpuflags should be.
Any idea?

yao
>> 4.move the GSTREAMER_DEBUG to libav's configure, it is not the
>> option for the main configure.
> OK.
>
> - Derek
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core