From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Antti Palosaari <crope@iki.fi>
Subject: Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2
Date: Sun, 05 Aug 2012 11:36:06 -0300 [thread overview]
Message-ID: <501E84D6.1040402@redhat.com> (raw)
In-Reply-To: <1344175824.18047.7.camel@router7789>
Em 05-08-2012 11:10, Malcolm Priestley escreveu:
> Conversion of lmedm04 to dvb-usb-v2
>
> functional changes are that callbacks have been moved to fe_ioctl_override.
Don't do that: fe_ioctl_override has a broken design and only handles DVBv3
ioctl's. So, if userspace is using DVBv5, this will cause a regression.
Antti,
IMO, the best thing to do is to either remove fe_ioctl_override or to print
a warning when a driver calls it, in order to warn developers that they're
using a legacy callback that could cause the driver to not work properly.
Regards,
Mauro
next prev parent reply other threads:[~2012-08-05 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 14:10 [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2 Malcolm Priestley
2012-08-05 14:36 ` Mauro Carvalho Chehab [this message]
2012-08-06 12:11 ` Antti Palosaari
2012-08-06 19:25 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501E84D6.1040402@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.