All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2
Date: Mon, 06 Aug 2012 22:25:37 +0300	[thread overview]
Message-ID: <50201A31.7000607@iki.fi> (raw)
In-Reply-To: <1344175824.18047.7.camel@router7789>

On 08/05/2012 05:10 PM, Malcolm Priestley wrote:
> Conversion of lmedm04 to dvb-usb-v2
>
> functional changes are that callbacks have been moved to fe_ioctl_override.
>
> This patch is applied on top of [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000)
> http://patchwork.linuxtv.org/patch/13584/
>
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>

I reviewed it quickly and didn't see any dvb-usb-v2 issues. Anyhow, that 
driver look quite complex overall and maybe there is room for cleaning. 
There is even own urb handling routines for both data streaming and 
control messages, why? (due to that it is not possible to use dvb-usb 
power-management)

regards
Antti

-- 
http://palosaari.fi/

      parent reply	other threads:[~2012-08-06 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05 14:10 [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2 Malcolm Priestley
2012-08-05 14:36 ` Mauro Carvalho Chehab
2012-08-06 12:11   ` Antti Palosaari
2012-08-06 19:25 ` Antti Palosaari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50201A31.7000607@iki.fi \
    --to=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.