From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: peterz@infradead.org, daniel.santos@pobox.com,
aarcange@redhat.com, dwmw2@infradead.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation
Date: Sun, 05 Aug 2012 22:12:34 -0400 [thread overview]
Message-ID: <501F2812.70303@redhat.com> (raw)
In-Reply-To: <1343946858-8170-9-git-send-email-walken@google.com>
On 08/02/2012 06:34 PM, Michel Lespinasse wrote:
> Introduce new augmented rbtree APIs that allow minimal recalculation of
> augmented node information.
>
> A new callback is added to the rbtree insertion and erase rebalancing
> functions, to be called on each tree rotations. Such rotations preserve
> the subtree's root augmented value, but require recalculation of the one
> child that was previously located at the subtree root.
>
> In the insertion case, the handcoded search phase must be updated to
> maintain the augmented information on insertion, and then the rbtree
> coloring/rebalancing algorithms keep it up to date.
>
> In the erase case, things are more complicated since it is library
> code that manipulates the rbtree in order to remove internal nodes.
> This requires a couple additional callbacks to copy a subtree's
> augmented value when a new root is stitched in, and to recompute
> augmented values down the ancestry path when a node is removed from
> the tree.
>
> In order to preserve maximum speed for the non-augmented case,
> we provide two versions of each tree manipulation function.
> rb_insert_augmented() is the augmented equivalent of rb_insert_color(),
> and rb_erase_augmented() is the augmented equivalent of rb_erase().
>
> Signed-off-by: Michel Lespinasse<walken@google.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: peterz@infradead.org, daniel.santos@pobox.com,
aarcange@redhat.com, dwmw2@infradead.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation
Date: Sun, 05 Aug 2012 22:12:34 -0400 [thread overview]
Message-ID: <501F2812.70303@redhat.com> (raw)
In-Reply-To: <1343946858-8170-9-git-send-email-walken@google.com>
On 08/02/2012 06:34 PM, Michel Lespinasse wrote:
> Introduce new augmented rbtree APIs that allow minimal recalculation of
> augmented node information.
>
> A new callback is added to the rbtree insertion and erase rebalancing
> functions, to be called on each tree rotations. Such rotations preserve
> the subtree's root augmented value, but require recalculation of the one
> child that was previously located at the subtree root.
>
> In the insertion case, the handcoded search phase must be updated to
> maintain the augmented information on insertion, and then the rbtree
> coloring/rebalancing algorithms keep it up to date.
>
> In the erase case, things are more complicated since it is library
> code that manipulates the rbtree in order to remove internal nodes.
> This requires a couple additional callbacks to copy a subtree's
> augmented value when a new root is stitched in, and to recompute
> augmented values down the ancestry path when a node is removed from
> the tree.
>
> In order to preserve maximum speed for the non-augmented case,
> we provide two versions of each tree manipulation function.
> rb_insert_augmented() is the augmented equivalent of rb_insert_color(),
> and rb_erase_augmented() is the augmented equivalent of rb_erase().
>
> Signed-off-by: Michel Lespinasse<walken@google.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2012-08-06 2:13 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 22:34 [PATCH v2 0/9] faster augmented rbtree interface Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 1/9] rbtree test: fix sparse warning about 64-bit constant Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-05 20:47 ` Rik van Riel
2012-08-05 20:47 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 2/9] rbtree: optimize fetching of sibling node Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-05 23:20 ` Rik van Riel
2012-08-05 23:20 ` Rik van Riel
2012-08-06 14:23 ` Peter Zijlstra
2012-08-06 14:23 ` Peter Zijlstra
2012-08-06 20:46 ` Michel Lespinasse
2012-08-06 20:46 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 3/9] rbtree: add __rb_change_child() helper function Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 1:00 ` Rik van Riel
2012-08-06 1:00 ` Rik van Riel
2012-08-06 14:22 ` Peter Zijlstra
2012-08-06 14:22 ` Peter Zijlstra
2012-08-07 0:04 ` Michel Lespinasse
2012-08-07 0:04 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 4/9] rbtree: place easiest case first in rb_erase() Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 1:13 ` Rik van Riel
2012-08-06 1:13 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 5/9] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 1:27 ` Rik van Riel
2012-08-06 1:27 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 6/9] rbtree: low level optimizations in rb_erase() Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 1:41 ` Rik van Riel
2012-08-06 1:41 ` Rik van Riel
2012-08-06 14:21 ` Peter Zijlstra
2012-08-06 14:21 ` Peter Zijlstra
2012-08-06 20:50 ` Michel Lespinasse
2012-08-06 20:50 ` Michel Lespinasse
2012-08-06 20:58 ` Peter Zijlstra
2012-08-06 20:58 ` Peter Zijlstra
2012-08-06 21:20 ` Michel Lespinasse
2012-08-06 21:20 ` Michel Lespinasse
2012-08-06 21:21 ` Michel Lespinasse
2012-08-06 21:21 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 7/9] rbtree: augmented rbtree test Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 2:11 ` Rik van Riel
2012-08-06 2:11 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-06 2:12 ` Rik van Riel [this message]
2012-08-06 2:12 ` Rik van Riel
2012-08-06 14:17 ` Peter Zijlstra
2012-08-06 14:17 ` Peter Zijlstra
2012-08-06 15:38 ` Peter Zijlstra
2012-08-06 15:38 ` Peter Zijlstra
2012-08-06 21:55 ` Michel Lespinasse
2012-08-06 21:55 ` Michel Lespinasse
2012-08-07 7:12 ` [PATCH] rbtree: add RB_DECLARE_CALLBACKS() macro Michel Lespinasse
2012-08-07 7:12 ` Michel Lespinasse
2012-08-06 14:25 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Peter Zijlstra
2012-08-06 14:25 ` Peter Zijlstra
2012-08-06 21:34 ` Michel Lespinasse
2012-08-06 21:34 ` Michel Lespinasse
2012-08-06 21:36 ` Peter Zijlstra
2012-08-06 21:36 ` Peter Zijlstra
2012-08-06 14:29 ` Peter Zijlstra
2012-08-06 14:29 ` Peter Zijlstra
2012-08-06 21:38 ` Michel Lespinasse
2012-08-06 21:38 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 9/9] rbtree: remove prior augmented rbtree implementation Michel Lespinasse
2012-08-02 22:34 ` Michel Lespinasse
2012-08-02 22:41 ` Joe Perches
2012-08-02 22:41 ` Joe Perches
2012-08-06 2:13 ` Rik van Riel
2012-08-06 2:13 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501F2812.70303@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.