[PATCH_v3 0/2] Add scripts for GCF testing

[PATCH_v3 0/2] Add scripts for GCF testing

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Change log from v2:
	- Replace hangup-call-state by hangup-multiparty
	- Use call path instead of index to clear a specific call

Guillaume Zajac (2):
  test: Add hangup-multiparty script for GCF testing
  test: Add hangup-call script for GCF testing

 Makefile.am            |    4 +++-
 test/hangup-call       |   36 ++++++++++++++++++++++++++++++++++++
 test/hangup-multiparty |   20 ++++++++++++++++++++
 3 files changed, 59 insertions(+), 1 deletions(-)
 create mode 100755 test/hangup-call
 create mode 100755 test/hangup-multiparty

-- 
1.7.5.4

[PATCH_v3 1/2] test: Add hangup-multiparty script for GCF testing

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

---
 Makefile.am            |    3 ++-
 test/hangup-multiparty |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletions(-)
 create mode 100755 test/hangup-multiparty

diff --git a/Makefile.am b/Makefile.am
index 99d4ab0..7e8f12c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -624,7 +624,8 @@ test_scripts = test/backtrace \
 		test/test-gnss \
 		test/swap-calls \
 		test/release-and-answer \
-		test/hold-and-answer
+		test/hold-and-answer \
+		test/hangup-multiparty
 
 if TEST
 testdir = $(pkglibdir)/test
diff --git a/test/hangup-multiparty b/test/hangup-multiparty
new file mode 100755
index 0000000..48fe342
--- /dev/null
+++ b/test/hangup-multiparty
@@ -0,0 +1,20 @@
+#!/usr/bin/python
+
+import sys
+import dbus
+
+bus = dbus.SystemBus()
+
+manager = dbus.Interface(bus.get_object('org.ofono', '/'),
+						'org.ofono.Manager')
+
+modems = manager.GetModems()
+modem = modems[0][0]
+
+if (len(sys.argv) == 2):
+	modem = sys.argv[1]
+
+manager = dbus.Interface(bus.get_object('org.ofono', modem),
+						'org.ofono.VoiceCallManager')
+
+manager.HangupMultiparty()
-- 
1.7.5.4

[PATCH_v3 2/2] test: Add hangup-call script for GCF testing

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

---
 Makefile.am      |    3 ++-
 test/hangup-call |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletions(-)
 create mode 100755 test/hangup-call

diff --git a/Makefile.am b/Makefile.am
index 7e8f12c..8cf6920 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -625,7 +625,8 @@ test_scripts = test/backtrace \
 		test/swap-calls \
 		test/release-and-answer \
 		test/hold-and-answer \
-		test/hangup-multiparty
+		test/hangup-multiparty \
+		test/hangup-call
 
 if TEST
 testdir = $(pkglibdir)/test
diff --git a/test/hangup-call b/test/hangup-call
new file mode 100755
index 0000000..bc77acf
--- /dev/null
+++ b/test/hangup-call
@@ -0,0 +1,36 @@
+#!/usr/bin/python
+
+import sys
+import dbus
+
+bus = dbus.SystemBus()
+
+manager = dbus.Interface(bus.get_object('org.ofono', '/'),
+						'org.ofono.Manager')
+
+modems = manager.GetModems()
+path = modems[0][0]
+
+manager = dbus.Interface(bus.get_object('org.ofono', path),
+						'org.ofono.VoiceCallManager')
+
+calls = manager.GetCalls()
+if (len(calls) == 0):
+	print "No calls available"
+	sys.exit(1)
+
+if (len(sys.argv) < 2):
+	i = 0
+	for path, properties in calls:
+		multi = properties["Multiparty"]
+		print "Call Path [ %s ] Multiparty %d" % (path, multi)
+		print
+		i += 1
+
+	print "Usage: %s [ Call Path ]" % (sys.argv[0])
+	print
+	sys.exit(1)
+
+call = dbus.Interface(bus.get_object('org.ofono', sys.argv[1]),
+						'org.ofono.VoiceCall')
+call.Hangup()
-- 
1.7.5.4

Re: [PATCH_v3 1/2] test: Add hangup-multiparty script for GCF testing

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Hi Guillaume,

>  Makefile.am            |    3 ++-
>  test/hangup-multiparty |   20 ++++++++++++++++++++
>  2 files changed, 22 insertions(+), 1 deletions(-)
>  create mode 100755 test/hangup-multiparty

patch has been applied.

Regards

Marcel

Re: [PATCH_v3 2/2] test: Add hangup-call script for GCF testing

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

Hi Guillaume,

>  Makefile.am      |    3 ++-
>  test/hangup-call |   36 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+), 1 deletions(-)
>  create mode 100755 test/hangup-call
> 
> diff --git a/Makefile.am b/Makefile.am
> index 7e8f12c..8cf6920 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -625,7 +625,8 @@ test_scripts = test/backtrace \
>  		test/swap-calls \
>  		test/release-and-answer \
>  		test/hold-and-answer \
> -		test/hangup-multiparty
> +		test/hangup-multiparty \
> +		test/hangup-call
>  
>  if TEST
>  testdir = $(pkglibdir)/test
> diff --git a/test/hangup-call b/test/hangup-call
> new file mode 100755
> index 0000000..bc77acf
> --- /dev/null
> +++ b/test/hangup-call
> @@ -0,0 +1,36 @@
> +#!/usr/bin/python
> +
> +import sys
> +import dbus
> +
> +bus = dbus.SystemBus()
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', '/'),
> +						'org.ofono.Manager')
> +
> +modems = manager.GetModems()
> +path = modems[0][0]
> +
> +manager = dbus.Interface(bus.get_object('org.ofono', path),
> +						'org.ofono.VoiceCallManager')
> +
> +calls = manager.GetCalls()
> +if (len(calls) == 0):
> +	print "No calls available"
> +	sys.exit(1)
> +
> +if (len(sys.argv) < 2):
> +	i = 0
> +	for path, properties in calls:
> +		multi = properties["Multiparty"]
> +		print "Call Path [ %s ] Multiparty %d" % (path, multi)
> +		print
> +		i += 1
> +
> +	print "Usage: %s [ Call Path ]" % (sys.argv[0])
> +	print
> +	sys.exit(1)

we have list-calls for this. So why not make this really simple and and
require the call object path as input.

Regards

Marcel

Re: [PATCH_v3 2/2] test: Add hangup-call script for GCF testing

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

Hi Marcel,

On 03/08/2012 18:58, Marcel Holtmann wrote:
> Hi Guillaume,
>
>>   Makefile.am      |    3 ++-
>>   test/hangup-call |   36 ++++++++++++++++++++++++++++++++++++
>>   2 files changed, 38 insertions(+), 1 deletions(-)
>>   create mode 100755 test/hangup-call
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 7e8f12c..8cf6920 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -625,7 +625,8 @@ test_scripts = test/backtrace \
>>   		test/swap-calls \
>>   		test/release-and-answer \
>>   		test/hold-and-answer \
>> -		test/hangup-multiparty
>> +		test/hangup-multiparty \
>> +		test/hangup-call
>>   
>>   if TEST
>>   testdir = $(pkglibdir)/test
>> diff --git a/test/hangup-call b/test/hangup-call
>> new file mode 100755
>> index 0000000..bc77acf
>> --- /dev/null
>> +++ b/test/hangup-call
>> @@ -0,0 +1,36 @@
>> +#!/usr/bin/python
>> +
>> +import sys
>> +import dbus
>> +
>> +bus = dbus.SystemBus()
>> +
>> +manager = dbus.Interface(bus.get_object('org.ofono', '/'),
>> +						'org.ofono.Manager')
>> +
>> +modems = manager.GetModems()
>> +path = modems[0][0]
>> +
>> +manager = dbus.Interface(bus.get_object('org.ofono', path),
>> +						'org.ofono.VoiceCallManager')
>> +
>> +calls = manager.GetCalls()
>> +if (len(calls) == 0):
>> +	print "No calls available"
>> +	sys.exit(1)
>> +
>> +if (len(sys.argv) < 2):
>> +	i = 0
>> +	for path, properties in calls:
>> +		multi = properties["Multiparty"]
>> +		print "Call Path [ %s ] Multiparty %d" % (path, multi)
>> +		print
>> +		i += 1
>> +
>> +	print "Usage: %s [ Call Path ]" % (sys.argv[0])
>> +	print
>> +	sys.exit(1)
> we have list-calls for this. So why not make this really simple and and
> require the call object path as input.

Ok, I will only check if there is an argument and don't list the call.

Kind regards,
Guillaume