All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, Hans Verkuil <hverkuil@xs4all.nl>,
	alsa-devel@alsa-project.org,
	Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v7] media: Add stk1160 new driver
Date: Mon, 06 Aug 2012 09:42:25 -0300	[thread overview]
Message-ID: <501FBBB1.1030802@redhat.com> (raw)
In-Reply-To: <CALF0-+XEStNrfdqYecKQHr=qkcFPtC5CyDC4DWWy_7+_oA0h=g@mail.gmail.com>

Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> This driver adds support for stk1160 usb bridge as used in some
>> video/audio usb capture devices.
>> It is a complete rewrite of staging/media/easycap driver and
>> it's expected as a future replacement.
>>
>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Cc: Takashi Iwai <tiwai@suse.de>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
>> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>> ---
>>
> 
> Did you take a look at this?

Patchwork didn't get it[1]. Maybe the patch got mangled?
If so, could you please re-post?

[1] http://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=stk1160

Thanks!
Mauro

> 
> Perhaps we can discuss now you're previous comments:
> 
> 1. Place for ac97 code: media or alsa? (see Takashis' comments)
> 2. current_norm usage (see Hans' comments)
> 3. vb2_dqbuf and O_NONBLOCK flag (also see Hans' comments)
> 
> I know it's a big patch*, so there is no need to rush.
> I just wanted to discuss a bit about this before my brain-cache
> flushes completely :-)
> 
> Thanks,
> Ezequiel.
> 
> * Actually it's huge (12k lines) since I'm removing staging/easycap.
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-media@vger.kernel.org,
	Takashi Iwai <tiwai@suse.de>, Hans Verkuil <hverkuil@xs4all.nl>,
	Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH v7] media: Add stk1160 new driver
Date: Mon, 06 Aug 2012 09:42:25 -0300	[thread overview]
Message-ID: <501FBBB1.1030802@redhat.com> (raw)
In-Reply-To: <CALF0-+XEStNrfdqYecKQHr=qkcFPtC5CyDC4DWWy_7+_oA0h=g@mail.gmail.com>

Em 06-08-2012 09:28, Ezequiel Garcia escreveu:
> Hi Mauro,
> 
> On Sat, Jul 28, 2012 at 11:18 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> This driver adds support for stk1160 usb bridge as used in some
>> video/audio usb capture devices.
>> It is a complete rewrite of staging/media/easycap driver and
>> it's expected as a future replacement.
>>
>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Cc: Takashi Iwai <tiwai@suse.de>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
>> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>> ---
>>
> 
> Did you take a look at this?

Patchwork didn't get it[1]. Maybe the patch got mangled?
If so, could you please re-post?

[1] http://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=stk1160

Thanks!
Mauro

> 
> Perhaps we can discuss now you're previous comments:
> 
> 1. Place for ac97 code: media or alsa? (see Takashis' comments)
> 2. current_norm usage (see Hans' comments)
> 3. vb2_dqbuf and O_NONBLOCK flag (also see Hans' comments)
> 
> I know it's a big patch*, so there is no need to rush.
> I just wanted to discuss a bit about this before my brain-cache
> flushes completely :-)
> 
> Thanks,
> Ezequiel.
> 
> * Actually it's huge (12k lines) since I'm removing staging/easycap.
> 


  reply	other threads:[~2012-08-06 12:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1343485133-11090-1-git-send-email-elezegarcia@gmail.com>
2012-08-06 12:28 ` [PATCH v7] media: Add stk1160 new driver Ezequiel Garcia
2012-08-06 12:42   ` Mauro Carvalho Chehab [this message]
2012-08-06 12:42     ` Mauro Carvalho Chehab
2012-08-06 12:46     ` Ezequiel Garcia
2012-08-06 12:51       ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501FBBB1.1030802@redhat.com \
    --to=mchehab@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=elezegarcia@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.