* [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/
@ 2012-08-06 7:05 ` Peter A. G. Crosthwaite
0 siblings, 0 replies; 8+ messages in thread
From: Peter A. G. Crosthwaite @ 2012-08-06 7:05 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: Peter A. G. Crosthwaite, peter.maydell
Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
---
target-arm/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 29008a4..494c682 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -9892,7 +9892,7 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
} else {
/* While branches must always occur at the end of an IT block,
there are a few other things that can cause us to terminate
- the TB in the middel of an IT block:
+ the TB in the middle of an IT block:
- Exception generating instructions (bkpt, swi, undefined).
- Page boundaries.
- Hardware watchpoints.
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/
2012-08-06 7:05 ` [Qemu-devel] " Peter A. G. Crosthwaite
@ 2012-08-06 14:12 ` Andreas Färber
-1 siblings, 0 replies; 8+ messages in thread
From: Andreas Färber @ 2012-08-06 14:12 UTC (permalink / raw)
To: Peter A. G. Crosthwaite
Cc: qemu-trivial, peter.maydell, qemu-devel, Stefan Weil
Am 06.08.2012 09:05, schrieb Peter A. G. Crosthwaite:
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> target-arm/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 29008a4..494c682 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9892,7 +9892,7 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> } else {
> /* While branches must always occur at the end of an IT block,
> there are a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> - Hardware watchpoints.
FWIW
Reviewed-by: Andreas Färber <afaerber@suse.de>
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/
@ 2012-08-06 14:12 ` Andreas Färber
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Färber @ 2012-08-06 14:12 UTC (permalink / raw)
To: Peter A. G. Crosthwaite
Cc: qemu-trivial, peter.maydell, qemu-devel, Stefan Weil
Am 06.08.2012 09:05, schrieb Peter A. G. Crosthwaite:
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> target-arm/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 29008a4..494c682 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9892,7 +9892,7 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> } else {
> /* While branches must always occur at the end of an IT block,
> there are a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> - Hardware watchpoints.
FWIW
Reviewed-by: Andreas Färber <afaerber@suse.de>
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] arm: translate: comment typo - s/middel/middle/
2012-08-06 7:05 ` [Qemu-devel] " Peter A. G. Crosthwaite
@ 2012-08-06 14:17 ` Peter Maydell
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2012-08-06 14:17 UTC (permalink / raw)
To: Peter A. G. Crosthwaite; +Cc: qemu-trivial, qemu-devel
On 6 August 2012 08:05, Peter A. G. Crosthwaite
<peter.crosthwaite@petalogix.com> wrote:
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> target-arm/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 29008a4..494c682 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9892,7 +9892,7 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> } else {
> /* While branches must always occur at the end of an IT block,
> there are a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> - Hardware watchpoints.
> --
> 1.7.0.4
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Happy for this to go via the trivial queue.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] arm: translate: comment typo - s/middel/middle/
@ 2012-08-06 14:17 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2012-08-06 14:17 UTC (permalink / raw)
To: Peter A. G. Crosthwaite; +Cc: qemu-trivial, qemu-devel
On 6 August 2012 08:05, Peter A. G. Crosthwaite
<peter.crosthwaite@petalogix.com> wrote:
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> target-arm/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 29008a4..494c682 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9892,7 +9892,7 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> } else {
> /* While branches must always occur at the end of an IT block,
> there are a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> - Hardware watchpoints.
> --
> 1.7.0.4
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Happy for this to go via the trivial queue.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] arm: translate: comment typo - s/middel/middle/
2012-08-06 7:05 ` [Qemu-devel] " Peter A. G. Crosthwaite
@ 2012-08-10 13:35 ` Stefan Hajnoczi
-1 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2012-08-10 13:35 UTC (permalink / raw)
To: Peter A. G. Crosthwaite; +Cc: qemu-trivial, peter.maydell, qemu-devel
On Mon, Aug 06, 2012 at 05:05:56PM +1000, Peter A. G. Crosthwaite wrote:
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> target-arm/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Also congrats on getting two Reviewed-bys. That's a rate of 1
Reviewed-by per changed character and the most thorough review a QEMU
patch has ever had! :)
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread