All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Jerome Glisse <j.glisse@gmail.com>
Cc: Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: fence virtual address and free it once idle v3
Date: Mon, 06 Aug 2012 18:55:09 +0200	[thread overview]
Message-ID: <501FF6ED.90605@vodafone.de> (raw)
In-Reply-To: <CAH3drwZDPgh5Uxxjc638oy9VPrLioNJuQGwn4m4CGCqiectE1w@mail.gmail.com>

On 06.08.2012 18:30, Jerome Glisse wrote:
> On Mon, Aug 6, 2012 at 12:06 PM, Christian König
> <deathsimple@vodafone.de> wrote:
>> [SNIP]
>> Additional to that patch we still need a minor fix to mesa (just move
>> freeing the VM range after closing the handle). Going to send that in the
>> next minute to the mesa-dev list.
>>
>> Otherwise the patch indeed fixes the problem, but also isn't the best idea
>> for performance.
>>
>> Cheers,
>> Christian.
>>
> This does not impact performance, it's all about destroying bo/va so
> it's not a performance path. Or am i missing something here ?

radeonsi currently allocates very small BOs (8-32 bytes) for T# 
descriptors, and throws them away immediately after drawing.

That alone of course is insane under a performance aspect, but waiting 
for the last job to finish makes things completely worse.

It just moves my priorities of hacking on radeonsi a bit around.

Christian.

  reply	other threads:[~2012-08-06 16:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 21:26 [PATCH] drm/radeon: fence virtual address and free it once idle v3 j.glisse
2012-08-04  9:07 ` Christian König
2012-08-06 16:06   ` Christian König
2012-08-06 16:30     ` Jerome Glisse
2012-08-06 16:55       ` Christian König [this message]
2012-08-08 13:54         ` Michel Dänzer
2012-08-08 14:06         ` Jerome Glisse
2012-08-04 13:29 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501FF6ED.90605@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j.glisse@gmail.com \
    --cc=jglisse@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.