Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 06-08-2012 17:07, Manu Abraham escreveu:
> On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> As noticed at:
>>         http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034
>>
>> Both drivers are identical, except for the name. So, there's no
>> sense on keeping both. Instead of forking the entire code, just
>> fork the vp3033_config struct, saving some space, and cleaning
>> up the Kernel.
> 
>>
>> Reported-by: Igor M. Liplianin <liplianin@me.by>
>> Cc: Manu Abraham <abraham.manu@gmail.com>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> 
> Nack.
> 
> VP-2033 and 2040 are both different in terms of hardware. If someone
> wants to add
> in additional frontend characteristic differences, he shouldn't have
> to add in this code
> again.

The code are just the same for both! If it ever become different, then
it could be forked again, but for now, it is just duplicating the same
code on both places and wasting 200 lines of useless code.

Mauro.