From: "Bjørn Mork" <bjorn@mork.no>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers
Date: Thu, 16 Aug 2012 15:21:00 +0200 [thread overview]
Message-ID: <87a9xvotvn.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAHFNz9+mcnq5oWJLieN6P9e_gfS5BJZTVZDTGwhZR-dCtVJgcg@mail.gmail.com> (Manu Abraham's message of "Tue, 7 Aug 2012 01:57:20 +0530")
Manu Abraham <abraham.manu@gmail.com> writes:
> That's just peanuts you are talking about. The memory usage appears only
> if you are using the module. 200 lines of .text is nothing.
OK. Deleting 200 completely useless lines of code is nothing? I don't
think we live in the same world.
> That exists to
> differentiate between the 2 devices, not to make both hardware look the same.
Right. And every single USB hard drive out there should have it's own
duplicated usb-storage driver? I don't think so...
I am sure you are right that the cards are different. It just doesn't
matter as long as the drivers are identical.
Thank you Mauro for doing this long awaited cleanup. Getting rid of all
the duplicated and unused code in this driver will make it easier for
others to get involved in fixing the real bugs.
Bjørn
prev parent reply other threads:[~2012-08-16 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 19:02 [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers Mauro Carvalho Chehab
2012-08-06 20:07 ` Manu Abraham
2012-08-06 20:20 ` Mauro Carvalho Chehab
2012-08-06 20:27 ` Manu Abraham
2012-08-16 13:21 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9xvotvn.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.