Re: [PATCH 2/2] test: tweak monitor-ofono to display special characters

Re: [PATCH 2/2] test: tweak monitor-ofono to display special characters

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

Hi Guillaume,

On 08/07/2012 09:02 AM, Guillaume Zajac wrote:
> ---
>   test/monitor-ofono |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>

git show 9f3f5bce6f89045918ae9b7fede66abf0c51d59e.

Just set your terminal encoding to a UTF-8 based locale and be done with 
it.  Quit trying to find python hacks.

The only reason to use str() is to convert non-string types for easy 
printing.  Of course calling str() on utf8 strings is still not going to 
work.  There are plenty of places that still get this wrong, but this is 
not one of them.

Regards,
-Denis

Re: [PATCH 1/2] test: Tweak monitor-ofono to display CSSI/CSSU notifications

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi Guillaume,

On 08/07/2012 09:02 AM, Guillaume Zajac wrote:
> ---
>   test/monitor-ofono |   14 ++++++++++++++
>   1 files changed, 14 insertions(+), 0 deletions(-)
>

I fixed this slightly differently in commit 
46d180e9a3fab69dd3f4f252057aad061d0b0474.

Regards,
-Denis

[PATCH 1/2] test: Tweak monitor-ofono to display CSSI/CSSU notifications

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

---
 test/monitor-ofono |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/test/monitor-ofono b/test/monitor-ofono
index dcc5ff5..1f3fc56 100755
--- a/test/monitor-ofono
+++ b/test/monitor-ofono
@@ -161,6 +161,20 @@ if __name__ == '__main__':
 						path_keyword="path",
 						interface_keyword="interface")
 
+	bus.add_signal_receiver(value,
+				bus_name="org.ofono",
+					signal_name = "Forwarded",
+						member_keyword="member",
+						path_keyword="path",
+						interface_keyword="interface")
+
+	bus.add_signal_receiver(value,
+				bus_name="org.ofono",
+					signal_name = "BarringActive",
+						member_keyword="member",
+						path_keyword="path",
+						interface_keyword="interface")
+
 	for member in ["IncomingBroadcast", "EmergencyBroadcast",
 			"IncomingMessage", "ImmediateMessage"]:
 		bus.add_signal_receiver(message,
-- 
1.7.5.4

[PATCH 2/2] test: tweak monitor-ofono to display special characters

[Guillaume Zajac]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

---
 test/monitor-ofono |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/test/monitor-ofono b/test/monitor-ofono
index 1f3fc56..f3c765a 100755
--- a/test/monitor-ofono
+++ b/test/monitor-ofono
@@ -2,8 +2,10 @@
 
 import gobject
 
+import sys
 import dbus
 import dbus.mainloop.glib
+locale = sys.stdout.encoding
 
 _dbus2py = {
 	dbus.String : unicode,
@@ -73,7 +75,7 @@ def message(msg, args, member, path, interface):
 
 def ussd(msg, member, path, interface):
 	iface = interface[interface.rfind(".") + 1:]
-	print "{%s} [%s] %s %s" % (iface, path, member, msg)
+	print "{%s} [%s] %s %s" % (iface, path, member, str(msg))
 
 def value(value, member, path, interface):
 	iface = interface[interface.rfind(".") + 1:]
-- 
1.7.5.4