All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined
@ 2012-08-07  3:02 Guenter Roeck
  2012-08-07 10:01 ` Simon Budig
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2012-08-07  3:02 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, Guenter Roeck, Simon Budig

Fix:

edt-ft5x06.c: In function edt_ft5x06_ts_remove:
edt-ft5x06.c:846:14: error: struct edt_ft5x06_ts_data has no member named
raw_buffer

Cc: Simon Budig <simon.budig@kernelconcepts.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/input/touchscreen/edt-ft5x06.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 9afc777..b06a5e3 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -602,6 +602,7 @@ edt_ft5x06_ts_teardown_debugfs(struct edt_ft5x06_ts_data *tsdata)
 {
 	if (tsdata->debug_dir)
 		debugfs_remove_recursive(tsdata->debug_dir);
+	kfree(tsdata->raw_buffer);
 }
 
 #else
@@ -843,7 +844,6 @@ static int __devexit edt_ft5x06_ts_remove(struct i2c_client *client)
 	if (gpio_is_valid(pdata->reset_pin))
 		gpio_free(pdata->reset_pin);
 
-	kfree(tsdata->raw_buffer);
 	kfree(tsdata);
 
 	return 0;
-- 
1.7.9.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined
  2012-08-07  3:02 [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined Guenter Roeck
@ 2012-08-07 10:01 ` Simon Budig
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Budig @ 2012-08-07 10:01 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Dmitry Torokhov, linux-input

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/07/2012 05:02 AM, Guenter Roeck wrote:
> Fix:
> 
> edt-ft5x06.c: In function edt_ft5x06_ts_remove: 
> edt-ft5x06.c:846:14: error: struct edt_ft5x06_ts_data has no member
> named raw_buffer

Oops sorry, forgot to test compiling the driver without DEBUGFS. The
change looks correct to me.

Bye,
        Simon
- -- 
       Simon Budig                        kernel concepts GmbH
       simon.budig@kernelconcepts.de      Sieghuetter Hauptweg 48
       +49-271-771091-17                  D-57072 Siegen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlAg52sACgkQO2O/RXesiHC79gCfUyq8IGeS2rau3myvrtU6Bo4O
hiIAniXUa0AIzWJSvJ0gsQMgNA+1hnwd
=JBXZ
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-07 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07  3:02 [PATCH] Input: Fix edt-ft5x06 build error seen if CONFIG_DEBUG_FS is not defined Guenter Roeck
2012-08-07 10:01 ` Simon Budig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.