From: Chandrabhanu Mahapatra <cmahapatra@ti.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 4/6] OMAPDSS: VENC: Remove cpu_is_xxxx checks
Date: Tue, 07 Aug 2012 12:48:31 +0000 [thread overview]
Message-ID: <50210BCF.20100@ti.com> (raw)
In-Reply-To: <20120807085103.GM8468@arwen.pp.htv.fi>
On Tuesday 07 August 2012 02:21 PM, Felipe Balbi wrote:
> On Tue, Aug 07, 2012 at 01:58:17PM +0530, Chandrabhanu Mahapatra wrote:
>> OMAP4 checks are removed from VENC to provide it a cleaner interface. These
>> checks were introduced by patches "HACK: OMAP: DSS2: VENC: disable VENC on OMAP4
>> to prevent crash" (ba02fa37de) by Tomi Valkeinen <tomi.valkeinen@ti.com> and
>> "OMAPDSS: VENC: fix NULL pointer dereference in DSS2 VENC sysfs debug attr on
>> OMAP4" (cc1d3e032d) by Danny Kukawka <danny.kukawka@bisect.de> to prevent VENC
>> from crashing OMAP4 kernel. An alternative approach is used to do the same in
>> later patches.
> in later patches ? This means you're causing a regression here. Just
> swap the patches around to avoid it.
>
Hi! Yes I do agree with you. But as VENC is disabled on omap4, the basic
idea here was to remove unnecessary cpu_is checks and achieve the same
through a better approach.
--
Chandrabhanu Mahapatra
Texas Instruments India Pvt. Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Chandrabhanu Mahapatra <cmahapatra@ti.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 4/6] OMAPDSS: VENC: Remove cpu_is_xxxx checks
Date: Tue, 07 Aug 2012 18:06:31 +0530 [thread overview]
Message-ID: <50210BCF.20100@ti.com> (raw)
In-Reply-To: <20120807085103.GM8468@arwen.pp.htv.fi>
On Tuesday 07 August 2012 02:21 PM, Felipe Balbi wrote:
> On Tue, Aug 07, 2012 at 01:58:17PM +0530, Chandrabhanu Mahapatra wrote:
>> OMAP4 checks are removed from VENC to provide it a cleaner interface. These
>> checks were introduced by patches "HACK: OMAP: DSS2: VENC: disable VENC on OMAP4
>> to prevent crash" (ba02fa37de) by Tomi Valkeinen <tomi.valkeinen@ti.com> and
>> "OMAPDSS: VENC: fix NULL pointer dereference in DSS2 VENC sysfs debug attr on
>> OMAP4" (cc1d3e032d) by Danny Kukawka <danny.kukawka@bisect.de> to prevent VENC
>> from crashing OMAP4 kernel. An alternative approach is used to do the same in
>> later patches.
> in later patches ? This means you're causing a regression here. Just
> swap the patches around to avoid it.
>
Hi! Yes I do agree with you. But as VENC is disabled on omap4, the basic
idea here was to remove unnecessary cpu_is checks and achieve the same
through a better approach.
--
Chandrabhanu Mahapatra
Texas Instruments India Pvt. Ltd.
next prev parent reply other threads:[~2012-08-07 12:48 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 8:27 [PATCH 0/6] OMAPDSS: Remove cpu_is checks Chandrabhanu Mahapatra
2012-08-07 8:39 ` Chandrabhanu Mahapatra
2012-08-07 8:27 ` [PATCH 1/6] OMAPDSS: DISPC: Remove cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-07 8:39 ` Chandrabhanu Mahapatra
2012-08-07 8:48 ` Felipe Balbi
2012-08-07 8:48 ` Felipe Balbi
2012-08-07 9:05 ` Tomi Valkeinen
2012-08-07 9:05 ` Tomi Valkeinen
2012-08-07 9:14 ` Felipe Balbi
2012-08-07 9:14 ` Felipe Balbi
2012-08-07 9:27 ` Tomi Valkeinen
2012-08-07 9:27 ` Tomi Valkeinen
2012-08-07 9:32 ` Felipe Balbi
2012-08-07 9:32 ` Felipe Balbi
2012-08-07 9:57 ` Tomi Valkeinen
2012-08-07 9:57 ` Tomi Valkeinen
2012-08-07 10:27 ` Felipe Balbi
2012-08-07 10:27 ` Felipe Balbi
2012-08-07 10:57 ` Tomi Valkeinen
2012-08-07 10:57 ` Tomi Valkeinen
2012-08-07 11:14 ` Tony Lindgren
2012-08-07 11:14 ` Tony Lindgren
2012-08-07 10:52 ` Tomi Valkeinen
2012-08-07 10:52 ` Tomi Valkeinen
2012-08-07 12:22 ` Chandrabhanu Mahapatra
2012-08-07 12:34 ` Chandrabhanu Mahapatra
2012-08-07 13:00 ` Tomi Valkeinen
2012-08-07 13:00 ` Tomi Valkeinen
2012-08-08 11:37 ` [PATCH 1/6] OMAPDSS: DISPC: cleanup " Chandrabhanu Mahapatra
2012-08-08 11:49 ` Chandrabhanu Mahapatra
2012-08-08 12:36 ` Tomi Valkeinen
2012-08-08 12:36 ` Tomi Valkeinen
2012-08-08 13:01 ` Mahapatra, Chandrabhanu
2012-08-08 13:13 ` Mahapatra, Chandrabhanu
2012-08-08 13:25 ` Tomi Valkeinen
2012-08-08 13:25 ` Tomi Valkeinen
2012-08-13 11:58 ` Chandrabhanu Mahapatra
2012-08-13 12:10 ` Chandrabhanu Mahapatra
2012-08-14 9:58 ` Tomi Valkeinen
2012-08-14 9:58 ` Tomi Valkeinen
2012-08-14 12:03 ` Mahapatra, Chandrabhanu
2012-08-14 12:15 ` Mahapatra, Chandrabhanu
2012-08-14 12:16 ` Tomi Valkeinen
2012-08-14 12:16 ` Tomi Valkeinen
2012-08-16 11:18 ` [PATCH V4 " Chandrabhanu Mahapatra
2012-08-16 11:30 ` Chandrabhanu Mahapatra
2012-08-07 8:27 ` [PATCH 2/6] OMAPDSS: DSS: Remove redundant functions Chandrabhanu Mahapatra
2012-08-07 8:39 ` Chandrabhanu Mahapatra
2012-08-07 8:28 ` [PATCH 3/6] OMAPDSS: DSS: Remove cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-07 8:40 ` Chandrabhanu Mahapatra
2012-08-07 8:49 ` Felipe Balbi
2012-08-07 8:49 ` Felipe Balbi
2012-08-07 13:14 ` Tomi Valkeinen
2012-08-07 13:14 ` Tomi Valkeinen
2012-08-08 11:38 ` [PATCH 3/6] OMAPDSS: DSS: Cleanup " Chandrabhanu Mahapatra
2012-08-08 11:50 ` Chandrabhanu Mahapatra
2012-08-08 13:16 ` Tomi Valkeinen
2012-08-08 13:16 ` Tomi Valkeinen
2012-08-09 11:39 ` Mahapatra, Chandrabhanu
2012-08-09 11:51 ` Mahapatra, Chandrabhanu
2012-08-13 11:59 ` Chandrabhanu Mahapatra
2012-08-13 12:11 ` Chandrabhanu Mahapatra
2012-08-14 9:48 ` Tomi Valkeinen
2012-08-14 9:48 ` Tomi Valkeinen
2012-08-14 12:30 ` Mahapatra, Chandrabhanu
2012-08-14 12:42 ` Mahapatra, Chandrabhanu
2012-08-14 14:34 ` Tomi Valkeinen
2012-08-14 14:34 ` Tomi Valkeinen
2012-08-16 11:18 ` [PATCH V4 " Chandrabhanu Mahapatra
2012-08-16 11:30 ` Chandrabhanu Mahapatra
2012-08-17 13:54 ` Tomi Valkeinen
2012-08-17 13:54 ` Tomi Valkeinen
2012-08-20 8:42 ` Tomi Valkeinen
2012-08-20 8:42 ` Tomi Valkeinen
2012-08-20 10:36 ` Mahapatra, Chandrabhanu
2012-08-20 10:48 ` Mahapatra, Chandrabhanu
2012-08-20 10:46 ` Tomi Valkeinen
2012-08-20 10:46 ` Tomi Valkeinen
2012-08-07 8:28 ` [PATCH 4/6] OMAPDSS: VENC: Remove " Chandrabhanu Mahapatra
2012-08-07 8:40 ` Chandrabhanu Mahapatra
2012-08-07 8:51 ` Felipe Balbi
2012-08-07 8:51 ` Felipe Balbi
2012-08-07 12:36 ` Chandrabhanu Mahapatra [this message]
2012-08-07 12:48 ` Chandrabhanu Mahapatra
2012-08-07 8:28 ` [PATCH 5/6] ARM: OMAP: Disable venc for OMAP4 Chandrabhanu Mahapatra
2012-08-07 8:40 ` Chandrabhanu Mahapatra
2012-08-07 8:28 ` Chandrabhanu Mahapatra
2012-08-07 8:29 ` [PATCH 6/6] OMAPDSS: DPI: Remove cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-07 8:41 ` Chandrabhanu Mahapatra
2012-08-20 13:21 ` [PATCH V5 0/6] OMAPDSS: Cleanup cpu_is checks Chandrabhanu Mahapatra
2012-08-20 13:33 ` Chandrabhanu Mahapatra
2012-08-20 13:22 ` [PATCH V5 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-20 13:34 ` Chandrabhanu Mahapatra
2012-08-21 10:31 ` Tomi Valkeinen
2012-08-21 10:31 ` Tomi Valkeinen
2012-08-21 11:20 ` Mahapatra, Chandrabhanu
2012-08-21 11:32 ` Mahapatra, Chandrabhanu
2012-08-20 13:23 ` [PATCH V5 2/6] OMAPDSS: DSS: Remove redundant functions Chandrabhanu Mahapatra
2012-08-20 13:35 ` Chandrabhanu Mahapatra
2012-08-20 13:23 ` [PATCH V5 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-20 13:35 ` Chandrabhanu Mahapatra
2012-08-21 10:35 ` Tomi Valkeinen
2012-08-21 10:35 ` Tomi Valkeinen
2012-08-21 11:06 ` Mahapatra, Chandrabhanu
2012-08-21 11:18 ` Mahapatra, Chandrabhanu
2012-08-21 11:20 ` Tomi Valkeinen
2012-08-21 11:20 ` Tomi Valkeinen
2012-08-20 13:24 ` [PATCH V5 4/6] OMAPDSS: VENC: Remove " Chandrabhanu Mahapatra
2012-08-20 13:36 ` Chandrabhanu Mahapatra
2012-08-20 13:24 ` [PATCH V5 5/6] ARM: OMAP: Disable venc for OMAP4 Chandrabhanu Mahapatra
2012-08-20 13:36 ` Chandrabhanu Mahapatra
2012-08-21 10:32 ` Tomi Valkeinen
2012-08-21 10:32 ` Tomi Valkeinen
2012-08-21 11:13 ` Mahapatra, Chandrabhanu
2012-08-21 11:25 ` Mahapatra, Chandrabhanu
2012-08-20 13:24 ` [PATCH V5 6/6] OMAPDSS: DPI: Remove cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-20 13:36 ` Chandrabhanu Mahapatra
2012-08-22 6:36 ` [PATCH V6 0/6] OMAPDSS: Cleanup cpu_is checks Chandrabhanu Mahapatra
2012-08-22 6:48 ` Chandrabhanu Mahapatra
2012-08-22 6:36 ` Chandrabhanu Mahapatra
2012-08-22 6:37 ` [PATCH V6 1/6] OMAPDSS: DISPC: Cleanup cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-22 6:49 ` Chandrabhanu Mahapatra
2012-08-22 6:37 ` [PATCH V6 2/6] OMAPDSS: DSS: Remove redundant functions Chandrabhanu Mahapatra
2012-08-22 6:49 ` Chandrabhanu Mahapatra
2012-08-22 6:38 ` [PATCH V6 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-22 6:50 ` Chandrabhanu Mahapatra
2012-08-22 6:38 ` [PATCH V6 4/6] ARM: OMAP: Disable venc for OMAP4 Chandrabhanu Mahapatra
2012-08-22 6:50 ` Chandrabhanu Mahapatra
2012-08-22 6:38 ` Chandrabhanu Mahapatra
2012-08-22 6:38 ` [PATCH V6 5/6] OMAPDSS: VENC: Remove cpu_is_xxxx checks Chandrabhanu Mahapatra
2012-08-22 6:50 ` Chandrabhanu Mahapatra
2012-08-22 6:39 ` [PATCH V6 6/6] OMAPDSS: DPI: " Chandrabhanu Mahapatra
2012-08-22 6:51 ` Chandrabhanu Mahapatra
2012-08-22 8:44 ` [PATCH V6 0/6] OMAPDSS: Cleanup cpu_is checks Tomi Valkeinen
2012-08-22 8:44 ` Tomi Valkeinen
2012-08-22 8:44 ` Tomi Valkeinen
2012-08-30 0:20 ` [PATCH V5 " Tony Lindgren
2012-08-30 0:20 ` Tony Lindgren
2012-08-30 7:34 ` Tomi Valkeinen
2012-08-30 7:34 ` Tomi Valkeinen
2012-08-30 17:19 ` Tony Lindgren
2012-08-30 17:19 ` Tony Lindgren
2012-08-31 11:23 ` Tomi Valkeinen
2012-08-31 11:23 ` Tomi Valkeinen
2012-09-06 20:08 ` Tony Lindgren
2012-09-06 20:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50210BCF.20100@ti.com \
--to=cmahapatra@ti.com \
--cc=balbi@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.