* [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration
@ 2012-08-07 12:37 Peter Ujfalusi
2012-08-07 12:43 ` Jarkko Nikula
2012-08-07 14:04 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2012-08-07 12:37 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, stable, 3.4+, Jarkko Nikula
The check for the mux_signal callback was wrong which prevents us to
configure the 6pin port's FSR/CLKR signal mux.
Reported-by: CF Adad <cfadad@rocketmail.com>
Cc: stable@kernel.org (3.4+)
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Mark,
The omap-mcbsp FSR/CLKR mux configuration code seams to be broken since 3.4.
Would it be possible to apply this patch for the 3.6 release?
CC-ing stable@kernel.org since this part is broken in 3.4 and 3.5 kernels as
well.
Regards,
Peter
sound/soc/omap/mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 1b08d98..5bda7c9 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -766,7 +766,7 @@ int omap_mcbsp_6pin_src_mux(struct omap_mcbsp *mcbsp, u8 mux)
{
const char *signal, *src;
- if (mcbsp->pdata->mux_signal)
+ if (!mcbsp->pdata->mux_signal)
return -EINVAL;
switch (mux) {
--
1.7.8.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration
2012-08-07 12:37 [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration Peter Ujfalusi
@ 2012-08-07 12:43 ` Jarkko Nikula
2012-08-07 14:04 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2012-08-07 12:43 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: stable, Mark Brown, Liam Girdwood, alsa-devel, 3.4+
On 08/07/2012 03:37 PM, Peter Ujfalusi wrote:
> The check for the mux_signal callback was wrong which prevents us to
> configure the 6pin port's FSR/CLKR signal mux.
>
> Reported-by: CF Adad <cfadad@rocketmail.com>
> Cc: stable@kernel.org (3.4+)
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>
> Hi Mark,
>
> The omap-mcbsp FSR/CLKR mux configuration code seams to be broken since 3.4.
> Would it be possible to apply this patch for the 3.6 release?
>
> CC-ing stable@kernel.org since this part is broken in 3.4 and 3.5 kernels as
> well.
>
> Regards,
> Peter
>
> sound/soc/omap/mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 1b08d98..5bda7c9 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -766,7 +766,7 @@ int omap_mcbsp_6pin_src_mux(struct omap_mcbsp *mcbsp, u8 mux)
> {
> const char *signal, *src;
>
> - if (mcbsp->pdata->mux_signal)
> + if (!mcbsp->pdata->mux_signal)
> return -EINVAL;
>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration
2012-08-07 12:37 [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration Peter Ujfalusi
2012-08-07 12:43 ` Jarkko Nikula
@ 2012-08-07 14:04 ` Mark Brown
2012-08-07 14:24 ` Peter Ujfalusi
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2012-08-07 14:04 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, stable, Liam Girdwood, Jarkko Nikula, 3.4+
On Tue, Aug 07, 2012 at 03:37:47PM +0300, Peter Ujfalusi wrote:
> The check for the mux_signal callback was wrong which prevents us to
> configure the 6pin port's FSR/CLKR signal mux.
Applied, thanks.
> Cc: stable@kernel.org (3.4+)
Should be stable@vger.kernel.org these days.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration
2012-08-07 14:04 ` Mark Brown
@ 2012-08-07 14:24 ` Peter Ujfalusi
0 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2012-08-07 14:24 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel@alsa-project.org, Liam Girdwood, Jarkko Nikula
On 08/07/2012 05:04 PM, Mark Brown wrote:
>> Cc: stable@kernel.org (3.4+)
>
> Should be stable@vger.kernel.org these days.
Yes, you are right, I'll send the patch to the correct address for 3.4 and 3.5.
Thank you,
Péter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-07 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07 12:37 [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration Peter Ujfalusi
2012-08-07 12:43 ` Jarkko Nikula
2012-08-07 14:04 ` Mark Brown
2012-08-07 14:24 ` Peter Ujfalusi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.