All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v6 2/3] virtio_balloon: introduce migration primitives to balloon pages
Date: Wed, 08 Aug 2012 21:39:15 -0400	[thread overview]
Message-ID: <502314C3.2020509@redhat.com> (raw)
In-Reply-To: <5f4b30060e252e557882595984a8225ba6e0c9f2.1344463786.git.aquini@redhat.com>

On 08/08/2012 06:53 PM, Rafael Aquini wrote:
> Memory fragmentation introduced by ballooning might reduce significantly
> the number of 2MB contiguous memory blocks that can be used within a guest,
> thus imposing performance penalties associated with the reduced number of
> transparent huge pages that could be used by the guest workload.
>
> Besides making balloon pages movable at allocation time and introducing
> the necessary primitives to perform balloon page migration/compaction,
> this patch also introduces the following locking scheme to provide the
> proper synchronization and protection for struct virtio_balloon elements
> against concurrent accesses due to parallel operations introduced by
> memory compaction / page migration.
>   - balloon_lock (mutex) : synchronizes the access demand to elements of
> 			  struct virtio_balloon and its queue operations;
>   - pages_lock (spinlock): special protection to balloon pages list against
> 			  concurrent list handling operations;
>
> Signed-off-by: Rafael Aquini<aquini@redhat.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	Andi Kleen <andi@firstfloor.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v6 2/3] virtio_balloon: introduce migration primitives to balloon pages
Date: Wed, 08 Aug 2012 21:39:15 -0400	[thread overview]
Message-ID: <502314C3.2020509@redhat.com> (raw)
In-Reply-To: <5f4b30060e252e557882595984a8225ba6e0c9f2.1344463786.git.aquini@redhat.com>

On 08/08/2012 06:53 PM, Rafael Aquini wrote:
> Memory fragmentation introduced by ballooning might reduce significantly
> the number of 2MB contiguous memory blocks that can be used within a guest,
> thus imposing performance penalties associated with the reduced number of
> transparent huge pages that could be used by the guest workload.
>
> Besides making balloon pages movable at allocation time and introducing
> the necessary primitives to perform balloon page migration/compaction,
> this patch also introduces the following locking scheme to provide the
> proper synchronization and protection for struct virtio_balloon elements
> against concurrent accesses due to parallel operations introduced by
> memory compaction / page migration.
>   - balloon_lock (mutex) : synchronizes the access demand to elements of
> 			  struct virtio_balloon and its queue operations;
>   - pages_lock (spinlock): special protection to balloon pages list against
> 			  concurrent list handling operations;
>
> Signed-off-by: Rafael Aquini<aquini@redhat.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

  reply	other threads:[~2012-08-09  1:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 22:53 [PATCH v6 0/3] make balloon pages movable by compaction Rafael Aquini
2012-08-08 22:53 ` Rafael Aquini
2012-08-08 22:53 ` Rafael Aquini
2012-08-08 22:53 ` [PATCH v6 1/3] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini
2012-08-08 22:53 ` Rafael Aquini
2012-08-08 22:53   ` Rafael Aquini
2012-08-09  1:37   ` Rik van Riel
2012-08-09  1:37     ` Rik van Riel
2012-08-09  1:37   ` Rik van Riel
2012-08-09  1:55   ` Minchan Kim
2012-08-09  1:55     ` Minchan Kim
2012-08-09  1:55   ` Minchan Kim
2012-08-09  9:00   ` Mel Gorman
2012-08-09  9:00     ` Mel Gorman
2012-08-09 14:48     ` Rafael Aquini
2012-08-09 14:48       ` Rafael Aquini
2012-08-09 14:48       ` Rafael Aquini
2012-08-09 15:12       ` Rafael Aquini
2012-08-09 15:12         ` Rafael Aquini
2012-08-09 15:12         ` Rafael Aquini
2012-08-10 12:46         ` Mel Gorman
2012-08-10 12:46         ` Mel Gorman
2012-08-10 12:46           ` Mel Gorman
2012-08-09  9:00   ` Mel Gorman
2012-08-08 22:53 ` [PATCH v6 2/3] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-08 22:53   ` Rafael Aquini
2012-08-09  1:39   ` Rik van Riel [this message]
2012-08-09  1:39     ` Rik van Riel
2012-08-09  1:39   ` Rik van Riel
2012-08-08 22:53 ` Rafael Aquini
2012-08-08 22:53 ` [PATCH v6 3/3] mm: add vm event counters for balloon pages compaction Rafael Aquini
2012-08-08 22:53   ` Rafael Aquini
2012-08-09  1:40   ` Rik van Riel
2012-08-09  1:40     ` Rik van Riel
2012-08-09  1:40   ` Rik van Riel
2012-08-08 22:53 ` Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502314C3.2020509@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=aquini@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.