Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

[Igor Mitsyanko <i.mitsyanko@samsung.com>]

On 08/10/2012 08:30 PM, Peter Maydell wrote:
> On 10 August 2012 17:22, Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> On 08/09/2012 03:54 PM, Peter Maydell wrote:
>>> --- a/vmstate.h
>>> +++ b/vmstate.h
>>> @@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64;
>>>    extern const VMStateInfo vmstate_info_timer;
>>>    extern const VMStateInfo vmstate_info_buffer;
>>>    extern const VMStateInfo vmstate_info_unused_buffer;
>>> +extern const VMStateInfo vmstate_info_bitmap;
>>>      #define type_check_array(t1,t2,n) ((t1(*)[n])0 - (t2*)0)
>>>    #define type_check_pointer(t1,t2) ((t1**)0 - (t2*)0)
>>> @@ -411,6 +412,18 @@ extern const VMStateInfo vmstate_info_unused_buffer;
>>>        .flags        = VMS_BUFFER,                                      \
>>>    }
>>>    +/* _field_size should be a uint32_t field in the _state struct giving
>>> the
>>
>> "..should be an int32_t.."
> Er, yes. This patch should probably go in as part of your series
> to add save/load to sd.c -- could you just fix this when you resend
> the patch as part of that, please?
>
> thanks
> -- PMM
>

sure