From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, drivers@analog.com
Subject: Re: [PATCH 22/22] staging:iio:adc: Add AD7791 driver
Date: Sat, 11 Aug 2012 19:37:53 +0200 [thread overview]
Message-ID: <50269871.5030508@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.01.1208111034270.5846@pmeerw.net>
On 08/11/2012 10:41 AM, Peter Meerwald wrote:
>
> two minor comments below
>
Thanks.
>>[...]
>> +static const char * const ad7791_sample_freq_avail[] = {
>> + [AD7791_FILTER_RATE_120] = "120",
>> + [AD7791_FILTER_RATE_100] = "100",
>> + [AD7791_FILTER_RATE_33_3] = "33.3",
>> + [AD7791_FILTER_RATE_20] = "20",
>> + [AD7791_FILTER_RATE_16_6] = "16.6",
>> + [AD7791_FILTER_RATE_16_7] = "16.7",
>
> just curious; why is this not in strictly decreasing order?
> IIO_CONST_ATTR_SAMP_FREQ_AVAIL is...
It doesn't really matter, but to keep the indices in order.
AD7791_FILTER_RATE_16_6 is 0x4 and AD7791_FILTER_RATE_16_7 is 0x5.
>
>> + [AD7791_FILTER_RATE_13_3] = "13.3",
>> + [AD7791_FILTER_RATE_9_5] = "9.5",
>> +};
>> +
next prev parent reply other threads:[~2012-08-11 17:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 16:36 [PATCH 01/22] staging:iio:ad7793: Add missing break in switch statement Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 02/22] staging:iio:ad7793: Mark channels as unsigned Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 03/22] staging:iio:ad7793: Report channel offset Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 04/22] staging:iio:ad7793: Fix temperature scale and offset Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 05/22] staging:iio:ad7793: Follow new IIO naming spec Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 06/22] staging:iio:ad7793: Fix internal reference value Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 07/22] staging:iio:ad7793: Remove unused platform_data from device state struct Lars-Peter Clausen
2012-08-14 19:39 ` Jonathan Cameron
2012-08-14 20:19 ` Jonathan Cameron
2012-08-15 9:03 ` Lars-Peter Clausen
2012-08-15 9:28 ` Jonathan Cameron
[not found] ` <502B6688.6000904@metafoo.de>
2012-09-03 16:39 ` Lars-Peter Clausen
2012-09-03 20:09 ` Jonathan Cameron
2012-08-10 16:36 ` [PATCH 08/22] staging:iio:ad7192: Add missing break in switch statement Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 09/22] staging:iio:ad7192: Fix setting ACX Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 10/22] staging:iio:ad7192: Mark channels as unsigned Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 11/22] staging:iio:ad7192: Report channel offset Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 12/22] staging:iio:ad7192: Report offset and scale for temperature channel Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 13/22] staging:iio:ad7192: Remove unused platform_data from device state struct Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 14/22] staging:iio:ad7780: Mark channels as unsigned Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 15/22] iio: Introduce iio_device_{set,get}_drvdata() Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 16/22] iio:adc: Add common code for ADI Sigma Delta devices Lars-Peter Clausen
2012-08-14 12:03 ` Jonathan Cameron
2012-08-14 20:19 ` Jonathan Cameron
2012-08-10 16:36 ` [PATCH 17/22] staging:iio:ad7780: Use common Sigma Delta library Lars-Peter Clausen
2012-08-14 12:05 ` Jonathan Cameron
2012-08-10 16:36 ` [PATCH 18/22] staging:iio:ad7793: " Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 19/22] staging:iio:ad7192: " Lars-Peter Clausen
2012-08-27 17:07 ` Jonathan Cameron
2012-09-03 8:13 ` Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 20/22] staging:iio:ad7793: Add support for ad7794/ad7795 Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 21/22] staging:iio:ad7793: Add ad7785 support Lars-Peter Clausen
2012-08-10 16:36 ` [PATCH 22/22] staging:iio:adc: Add AD7791 driver Lars-Peter Clausen
2012-08-11 8:41 ` Peter Meerwald
2012-08-11 17:37 ` Lars-Peter Clausen [this message]
2012-08-13 13:12 ` Lars-Peter Clausen
2012-08-14 20:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50269871.5030508@metafoo.de \
--to=lars@metafoo.de \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.