Re: [PATCH 22/22] staging:iio:adc: Add AD7791 driver

[Jonathan Cameron <jic23@kernel.org>]

On 08/13/2012 02:12 PM, Lars-Peter Clausen wrote:
> On 08/10/2012 06:36 PM, Lars-Peter Clausen wrote:
>> This patch adds support for the Analog Devices AD7787, AD7788, AD7789, AD7790
>> and AD7791 Sigma Delta Analog-to-Digital converters.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> ---
>> [...]
>> +	case IIO_CHAN_INFO_SCALE:
>> +		/* The monitor channel uses an internal reference. */
>> +		if (chan->address == AD7791_CH_AVDD_MONITOR) {
>> +			scale_nv = 5850000000ULL;
>> +		} else {
>> +			int voltage_uv;
>> +
>> +			voltage_uv = regulator_get_voltage(st->reg);
>> +			if (voltage_uv < 0)
>> +				return voltage_uv;
>> +			scale_nv = voltage_uv * 1000;
>> +		}
>> +		if (unipolar)
>> +			scale_nv >>= chan->scan_type.realbits;
>> +		else
>> +			scale_nv >>= chan->scan_type.realbits - 1;
>> +		*val2 = do_div(scale_nv, 1000000);
>> +		*val = scale_nv;
>> +
> 
> Just noticed that the scale is off by a factor of 1000. It reports volts
> while we want milli volts.
I'll definitely ignore this driver for now then :)
> 
>> +		return IIO_VAL_INT_PLUS_NANO;
>> +	}
> 
>