* [PATCH] exofs: check for allocation failure in uri_store()
@ 2012-08-08 17:02 Alexey Khoroshilov
2012-08-09 18:54 ` Sachin Bhamare
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2012-08-08 17:02 UTC (permalink / raw)
To: Sachin Bhamare
Cc: Alexey Khoroshilov, Boaz Harrosh, Benny Halevy, osd-dev,
linux-kernel, ldv-project
There is no memory allocation failure check in uri_store().
That can lead to NULL pointer dereference.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
fs/exofs/sys.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c
index 5a7b691..1b4f2f9 100644
--- a/fs/exofs/sys.c
+++ b/fs/exofs/sys.c
@@ -80,8 +80,13 @@ static ssize_t uri_show(struct exofs_dev *edp, char *buf)
static ssize_t uri_store(struct exofs_dev *edp, const char *buf, size_t len)
{
+ uint8_t *new_uri;
+
edp->urilen = strlen(buf) + 1;
- edp->uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
+ new_uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
+ if (new_uri == NULL)
+ return -ENOMEM;
+ edp->uri = new_uri;
strncpy(edp->uri, buf, edp->urilen);
return edp->urilen;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] exofs: check for allocation failure in uri_store()
2012-08-08 17:02 [PATCH] exofs: check for allocation failure in uri_store() Alexey Khoroshilov
@ 2012-08-09 18:54 ` Sachin Bhamare
2012-08-12 18:57 ` Boaz Harrosh
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Bhamare @ 2012-08-09 18:54 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: Boaz Harrosh, Benny Halevy, osd-dev, linux-kernel, ldv-project
On 8/8/12 10:02 AM, Alexey Khoroshilov wrote:
> There is no memory allocation failure check in uri_store().
> That can lead to NULL pointer dereference.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> fs/exofs/sys.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c
> index 5a7b691..1b4f2f9 100644
> --- a/fs/exofs/sys.c
> +++ b/fs/exofs/sys.c
> @@ -80,8 +80,13 @@ static ssize_t uri_show(struct exofs_dev *edp, char *buf)
>
> static ssize_t uri_store(struct exofs_dev *edp, const char *buf, size_t len)
> {
> + uint8_t *new_uri;
> +
> edp->urilen = strlen(buf) + 1;
> - edp->uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
> + new_uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
> + if (new_uri == NULL)
> + return -ENOMEM;
> + edp->uri = new_uri;
> strncpy(edp->uri, buf, edp->urilen);
> return edp->urilen;
> }
Ack-by : Sachin Bhamare <sbhamare@panasas.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] exofs: check for allocation failure in uri_store()
2012-08-09 18:54 ` Sachin Bhamare
@ 2012-08-12 18:57 ` Boaz Harrosh
0 siblings, 0 replies; 3+ messages in thread
From: Boaz Harrosh @ 2012-08-12 18:57 UTC (permalink / raw)
To: Sachin Bhamare
Cc: Alexey Khoroshilov, Benny Halevy, osd-dev, linux-kernel,
ldv-project
On 08/09/2012 09:54 PM, Sachin Bhamare wrote:
> On 8/8/12 10:02 AM, Alexey Khoroshilov wrote:
>> There is no memory allocation failure check in uri_store().
>> That can lead to NULL pointer dereference.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>> ---
>> fs/exofs/sys.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c
>> index 5a7b691..1b4f2f9 100644
>> --- a/fs/exofs/sys.c
>> +++ b/fs/exofs/sys.c
>> @@ -80,8 +80,13 @@ static ssize_t uri_show(struct exofs_dev *edp, char *buf)
>>
>> static ssize_t uri_store(struct exofs_dev *edp, const char *buf, size_t len)
>> {
>> + uint8_t *new_uri;
>> +
>> edp->urilen = strlen(buf) + 1;
>> - edp->uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
>> + new_uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
>> + if (new_uri == NULL)
>> + return -ENOMEM;
>> + edp->uri = new_uri;
>> strncpy(edp->uri, buf, edp->urilen);
>> return edp->urilen;
>> }
> Ack-by : Sachin Bhamare <sbhamare@panasas.com>
Has been pushed to linux-next will be included in the next RCX
push to Linus.
Thanks
Boaz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-12 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-08 17:02 [PATCH] exofs: check for allocation failure in uri_store() Alexey Khoroshilov
2012-08-09 18:54 ` Sachin Bhamare
2012-08-12 18:57 ` Boaz Harrosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.