From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v3 1/2] ARM: shmobile: r8a7778: Use clks as MSTP007 parent
Date: Mon, 14 Apr 2014 09:27:26 +0000 [thread overview]
Message-ID: <5028748.H4m9LDvjIB@avalon> (raw)
In-Reply-To: <1397439698-30123-2-git-send-email-horms+renesas@verge.net.au>
Hi Simon,
Thank you for the patch.
On Monday 14 April 2014 10:41:36 Simon Horman wrote:
> According to the documentation the parent clock of
> MSTP007 should be clks not clkp.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v3
> * Correct changelog to refer to r8a7778 instead of r8a7779
>
> v2
> * First post, as suggested by Laurent Pinchart
> ---
> arch/arm/mach-shmobile/clock-r8a7778.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/clock-r8a7778.c
> b/arch/arm/mach-shmobile/clock-r8a7778.c index 2009a9b..9989b1b 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7778.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7778.c
> @@ -170,7 +170,7 @@ static struct clk mstp_clks[MSTP_NR] = {
> [MSTP010] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 10, 0), /* SSI2 */
> [MSTP009] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 9, 0), /* SSI3 */
> [MSTP008] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 8, 0), /* SRU */
> - [MSTP007] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 7, 0), /* HSPI */
> + [MSTP007] = SH_CLK_MSTP32(&s_clk, MSTPCR0, 7, 0), /* HSPI */
> };
>
> static struct clk_lookup lookups[] = {
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v3 1/2] ARM: shmobile: r8a7778: Use clks as MSTP007 parent
Date: Mon, 14 Apr 2014 11:27:26 +0200 [thread overview]
Message-ID: <5028748.H4m9LDvjIB@avalon> (raw)
In-Reply-To: <1397439698-30123-2-git-send-email-horms+renesas@verge.net.au>
Hi Simon,
Thank you for the patch.
On Monday 14 April 2014 10:41:36 Simon Horman wrote:
> According to the documentation the parent clock of
> MSTP007 should be clks not clkp.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v3
> * Correct changelog to refer to r8a7778 instead of r8a7779
>
> v2
> * First post, as suggested by Laurent Pinchart
> ---
> arch/arm/mach-shmobile/clock-r8a7778.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/clock-r8a7778.c
> b/arch/arm/mach-shmobile/clock-r8a7778.c index 2009a9b..9989b1b 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7778.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7778.c
> @@ -170,7 +170,7 @@ static struct clk mstp_clks[MSTP_NR] = {
> [MSTP010] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 10, 0), /* SSI2 */
> [MSTP009] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 9, 0), /* SSI3 */
> [MSTP008] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 8, 0), /* SRU */
> - [MSTP007] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 7, 0), /* HSPI */
> + [MSTP007] = SH_CLK_MSTP32(&s_clk, MSTPCR0, 7, 0), /* HSPI */
> };
>
> static struct clk_lookup lookups[] = {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-04-14 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 1:41 [PATCH v3 0/2] spi: sh-hspi: Do not specifically request shyway_clk clock Simon Horman
2014-04-14 1:41 ` Simon Horman
[not found] ` <1397439698-30123-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-14 1:41 ` [PATCH v3 1/2] ARM: shmobile: r8a7778: Use clks as MSTP007 parent Simon Horman
2014-04-14 1:41 ` Simon Horman
2014-04-14 9:27 ` Laurent Pinchart [this message]
2014-04-14 9:27 ` Laurent Pinchart
2014-04-14 20:14 ` Mark Brown
2014-04-14 20:14 ` Mark Brown
2014-04-14 1:41 ` [PATCH v2 repost 1/2] ARM: shmobile: r8a7779: " Simon Horman
2014-04-14 1:41 ` Simon Horman
[not found] ` <1397439698-30123-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-14 1:59 ` Simon Horman
2014-04-14 1:59 ` Simon Horman
2014-04-14 1:41 ` [PATCH v3 2/2] spi: sh-hspi: Do not specifically request shyway_clk clock Simon Horman
2014-04-14 1:41 ` Simon Horman
[not found] ` <1397439698-30123-4-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-14 20:15 ` Mark Brown
2014-04-14 20:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5028748.H4m9LDvjIB@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.