All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7
Date: Mon, 13 Aug 2012 07:57:16 -0700	[thread overview]
Message-ID: <502915CC.2020605@ti.com> (raw)
In-Reply-To: <5028B132.5010003@denx.de>

On 08/13/2012 12:48 AM, Stefano Babic wrote:
> On 09/08/2012 18:01, Tom Rini wrote:
>> Hey all,
>>
> 
> Hi Tom,
> 
>> As Allen Martin noted, on tegra platforms a bug is exposed when using
>> certain toolchains that currently calls to lowlevel_init must be calls
>> to another assembly function as the stack is not explicitly setup /
>> saved and thus register corruption can occur.  Over in TI-land Aneesh V
>> wrote a lowlevel_init that sets up the stack and calls s_init which is a
>> C function that does what lowlevel_init does on other platforms.  The
>> code is generic to at least v7, so this series moves it to
>> arch/arm/cpu/armv7.
> 
> Then as far as I can see in your patch, other armv7 can profit as well,
> such as the i.MX5 and i.MX6 ;-)
> 
> The only issue is to generalize the entry point for the function to
> setup PLL and or pinmux. It should be enough to change lowlevel_init to
> s_init in i.MX to do the job.

Yes, anyone could switch to this (and if it makes their code cleaner, a
C rather than asm lowlevel_init).   Just don't want to force the issue
since it requires that CONFIG_SYS_INIT_SP_ADDR be viable at this point
and that's something every platform has to determine for themselves.

-- 
Tom

  reply	other threads:[~2012-08-13 14:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 16:01 [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7 Tom Rini
2012-08-09 16:01 ` [U-Boot] [PATCH 1/2] omap4/5/am33xx: Make lowlevel_init available to all armv7 platforms Tom Rini
2012-08-13  6:28   ` R, Sricharan
2012-08-13 14:55     ` Tom Rini
2012-08-15 18:16   ` Allen Martin
2012-08-09 16:01 ` [U-Boot] [PATCH 2/2] armv7: Make lowlevel_init.S's lowlevel_init do ABI compatible stack Tom Rini
2012-08-15 18:16   ` Allen Martin
2012-08-13  7:48 ` [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7 Stefano Babic
2012-08-13 14:57   ` Tom Rini [this message]
2012-08-15 18:14 ` Allen Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502915CC.2020605@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.