Re: [Powertop] [PATCH] Fix backlight usage reporting when backlight control is not supported

[Chris Ferron <chris.e.ferron at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On 08/13/2012 09:49 AM, Igor Zhbanov wrote:
> On PC file /sys/class/backlight/.../max_brightness can contain 0
> when backlight control is not supported. Added check helps to avoid
> dividing by zero and printing NaN.
> ---
>   src/devices/backlight.cpp |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/devices/backlight.cpp b/src/devices/backlight.cpp
> index b8c9147..82cb1e0 100644
> --- a/src/devices/backlight.cpp
> +++ b/src/devices/backlight.cpp
> @@ -145,6 +145,9 @@ double backlight::utilization(void)
>   {
>   	double p;
>   
> +	if (max_level == 0)
> +		return 0.0;
> +
>   	p = 100.0 * (end_level + start_level) / 2 / max_level;
>   	return p;
>   }
Igor,
    Thank you for the patches, but in the future please send like 
patches in series and be more verbose in your commit messages.

Thanks
Chris Ferron