* [Powertop] [PATCH] Fix backlight usage reporting when backlight control is not supported
@ 2012-08-13 16:49 Igor Zhbanov
0 siblings, 0 replies; 2+ messages in thread
From: Igor Zhbanov @ 2012-08-13 16:49 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On PC file /sys/class/backlight/.../max_brightness can contain 0
when backlight control is not supported. Added check helps to avoid
dividing by zero and printing NaN.
---
src/devices/backlight.cpp | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/devices/backlight.cpp b/src/devices/backlight.cpp
index b8c9147..82cb1e0 100644
--- a/src/devices/backlight.cpp
+++ b/src/devices/backlight.cpp
@@ -145,6 +145,9 @@ double backlight::utilization(void)
{
double p;
+ if (max_level == 0)
+ return 0.0;
+
p = 100.0 * (end_level + start_level) / 2 / max_level;
return p;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Powertop] [PATCH] Fix backlight usage reporting when backlight control is not supported
@ 2012-08-13 17:33 Chris Ferron
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ferron @ 2012-08-13 17:33 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On 08/13/2012 09:49 AM, Igor Zhbanov wrote:
> On PC file /sys/class/backlight/.../max_brightness can contain 0
> when backlight control is not supported. Added check helps to avoid
> dividing by zero and printing NaN.
> ---
> src/devices/backlight.cpp | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/devices/backlight.cpp b/src/devices/backlight.cpp
> index b8c9147..82cb1e0 100644
> --- a/src/devices/backlight.cpp
> +++ b/src/devices/backlight.cpp
> @@ -145,6 +145,9 @@ double backlight::utilization(void)
> {
> double p;
>
> + if (max_level == 0)
> + return 0.0;
> +
> p = 100.0 * (end_level + start_level) / 2 / max_level;
> return p;
> }
Igor,
Thank you for the patches, but in the future please send like
patches in series and be more verbose in your commit messages.
Thanks
Chris Ferron
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-13 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 17:33 [Powertop] [PATCH] Fix backlight usage reporting when backlight control is not supported Chris Ferron
-- strict thread matches above, loose matches on Subject: below --
2012-08-13 16:49 Igor Zhbanov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.