From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Tue, 14 Aug 2012 09:42:59 +0200 [thread overview]
Message-ID: <502A0183.4070303@web.de> (raw)
In-Reply-To: <CAFEAcA_9wmpEy-_x9nUufHA853hWJtDEy39hVe5h=CjzScsj6g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On 2012-08-14 09:40, Peter Maydell wrote:
> On 14 August 2012 08:33, Jan Kiszka <jan.kiszka@web.de> wrote:
>> Either you move both or none.
>
> OK.
>
>> KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e
>> injection with feedback to allow lost-tick compensation) is the current
>> standard that other archs should pick up.
>
> Can it be documented in the kernel api.txt then, please? Nobody
> is going to use it otherwise... (If I'd been paying attention at the
> time I'd have nak'd the qemu patches that added it on the grounds
> they were using an undocumented kernel API :-))
The kernel API's documentation has in fact a much younger history than
KVM support in QEMU. I think we still need to add quite a few standard
IOCTLs to make it complete. Patches always welcome.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Tue, 14 Aug 2012 09:42:59 +0200 [thread overview]
Message-ID: <502A0183.4070303@web.de> (raw)
In-Reply-To: <CAFEAcA_9wmpEy-_x9nUufHA853hWJtDEy39hVe5h=CjzScsj6g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On 2012-08-14 09:40, Peter Maydell wrote:
> On 14 August 2012 08:33, Jan Kiszka <jan.kiszka@web.de> wrote:
>> Either you move both or none.
>
> OK.
>
>> KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e
>> injection with feedback to allow lost-tick compensation) is the current
>> standard that other archs should pick up.
>
> Can it be documented in the kernel api.txt then, please? Nobody
> is going to use it otherwise... (If I'd been paying attention at the
> time I'd have nak'd the qemu patches that added it on the grounds
> they were using an undocumented kernel API :-))
The kernel API's documentation has in fact a much younger history than
KVM support in QEMU. I think we still need to add quite a few standard
IOCTLs to make it complete. Patches always welcome.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-08-14 7:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 17:05 [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Peter Maydell
2012-08-06 17:05 ` [Qemu-devel] " Peter Maydell
2012-08-12 13:13 ` Peter Maydell
2012-08-12 13:13 ` [Qemu-devel] " Peter Maydell
2012-08-13 20:45 ` Marcelo Tosatti
2012-08-13 20:45 ` Marcelo Tosatti
2012-08-13 21:40 ` Peter Maydell
2012-08-13 21:40 ` Peter Maydell
2012-08-14 7:33 ` Jan Kiszka
2012-08-14 7:33 ` [Qemu-devel] " Jan Kiszka
2012-08-14 7:40 ` Peter Maydell
2012-08-14 7:40 ` [Qemu-devel] " Peter Maydell
2012-08-14 7:42 ` Jan Kiszka [this message]
2012-08-14 7:42 ` Jan Kiszka
2012-08-14 7:52 ` Peter Maydell
2012-08-14 7:52 ` [Qemu-devel] " Peter Maydell
2012-08-14 8:09 ` Jan Kiszka
2012-08-14 8:09 ` [Qemu-devel] " Jan Kiszka
2012-08-14 13:10 ` Peter Maydell
2012-08-14 13:10 ` [Qemu-devel] " Peter Maydell
2012-08-14 13:27 ` Jan Kiszka
2012-08-14 13:27 ` [Qemu-devel] " Jan Kiszka
2012-08-14 11:01 ` Avi Kivity
2012-08-14 11:01 ` [Qemu-devel] " Avi Kivity
2012-08-14 11:05 ` Jan Kiszka
2012-08-14 11:05 ` [Qemu-devel] " Jan Kiszka
2012-08-14 13:14 ` Avi Kivity
2012-08-14 13:14 ` [Qemu-devel] " Avi Kivity
2012-08-14 13:36 ` Jan Kiszka
2012-08-14 13:36 ` [Qemu-devel] " Jan Kiszka
2012-08-14 7:36 ` Jan Kiszka
2012-08-14 7:36 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A0183.4070303@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.