* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-07-20 10:38 ` Sourav Poddar
0 siblings, 0 replies; 20+ messages in thread
From: Sourav Poddar @ 2012-07-20 10:38 UTC (permalink / raw)
To: tony, devicetree-discuss
Cc: linux-omap, linux-arm-kernel, kishon, Sourav Poddar,
Benoit Cousson, Rob Herring, Grant Likely, Felipe Balbi
Add keypad data node in omap4 device tree file.
Also fill the device tree binding parameters
with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
Changes since v6:
-remove address from the node since reg property
is not used.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 5 +++
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 72216e9..80cd016 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -113,6 +113,76 @@
"DMic", "Digital Mic",
"Digital Mic", "Digital Mic1 Bias";
};
+
+ keypad {
+ keypad,num-rows = <8>;
+ keypad,num-columns = <8>;
+ linux,keymap = < 0x00000012
+ 0x00010013
+ 0x00020014
+ 0x00030066
+ 0x0004003f
+ 0x000500f0
+ 0x00060017
+ 0x0007002a
+ 0x01000020
+ 0x01010021
+ 0x01020022
+ 0x010300e7
+ 0x01040040
+ 0x010500f0
+ 0x01060025
+ 0x0107001c
+ 0x0200002d
+ 0x0201002e
+ 0x0202002f
+ 0x0203006b
+ 0x02040041
+ 0x020500f0
+ 0x02060034
+ 0x0207003a
+ 0x0300002c
+ 0x0301004e
+ 0x03020030
+ 0x0303003b
+ 0x03040042
+ 0x030500f0
+ 0x03060018
+ 0x03070039
+ 0x04000011
+ 0x04010015
+ 0x04020016
+ 0x0403003c
+ 0x04040073
+ 0x040500f0
+ 0x04060026
+ 0x04070069
+ 0x0500001f
+ 0x05010023
+ 0x05020024
+ 0x0503003d
+ 0x05040043
+ 0x05050072
+ 0x05060032
+ 0x0507006a
+ 0x06000010
+ 0x0601001e
+ 0x06020031
+ 0x0603009e
+ 0x0604000e
+ 0x060500f0
+ 0x06060019
+ 0x06070067
+ 0x07000094
+ 0x07010095
+ 0x070200ca
+ 0x070300cb
+ 0x0704003e
+ 0x070500f0
+ 0x07060160
+ 0x0707006c >;
+ linux,input-no-autorepeat;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 04cbbcb..e78a1f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -296,4 +296,9 @@
ti,hwmods = "dmic";
};
};
+
+ keypad {
+ compatible = "ti,omap4-keypad";
+ ti,hwmods = "kbd";
+ };
};
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-07-20 10:38 ` Sourav Poddar
0 siblings, 0 replies; 20+ messages in thread
From: Sourav Poddar @ 2012-07-20 10:38 UTC (permalink / raw)
To: linux-arm-kernel
Add keypad data node in omap4 device tree file.
Also fill the device tree binding parameters
with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
Changes since v6:
-remove address from the node since reg property
is not used.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 5 +++
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 72216e9..80cd016 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -113,6 +113,76 @@
"DMic", "Digital Mic",
"Digital Mic", "Digital Mic1 Bias";
};
+
+ keypad {
+ keypad,num-rows = <8>;
+ keypad,num-columns = <8>;
+ linux,keymap = < 0x00000012
+ 0x00010013
+ 0x00020014
+ 0x00030066
+ 0x0004003f
+ 0x000500f0
+ 0x00060017
+ 0x0007002a
+ 0x01000020
+ 0x01010021
+ 0x01020022
+ 0x010300e7
+ 0x01040040
+ 0x010500f0
+ 0x01060025
+ 0x0107001c
+ 0x0200002d
+ 0x0201002e
+ 0x0202002f
+ 0x0203006b
+ 0x02040041
+ 0x020500f0
+ 0x02060034
+ 0x0207003a
+ 0x0300002c
+ 0x0301004e
+ 0x03020030
+ 0x0303003b
+ 0x03040042
+ 0x030500f0
+ 0x03060018
+ 0x03070039
+ 0x04000011
+ 0x04010015
+ 0x04020016
+ 0x0403003c
+ 0x04040073
+ 0x040500f0
+ 0x04060026
+ 0x04070069
+ 0x0500001f
+ 0x05010023
+ 0x05020024
+ 0x0503003d
+ 0x05040043
+ 0x05050072
+ 0x05060032
+ 0x0507006a
+ 0x06000010
+ 0x0601001e
+ 0x06020031
+ 0x0603009e
+ 0x0604000e
+ 0x060500f0
+ 0x06060019
+ 0x06070067
+ 0x07000094
+ 0x07010095
+ 0x070200ca
+ 0x070300cb
+ 0x0704003e
+ 0x070500f0
+ 0x07060160
+ 0x0707006c >;
+ linux,input-no-autorepeat;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 04cbbcb..e78a1f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -296,4 +296,9 @@
ti,hwmods = "dmic";
};
};
+
+ keypad {
+ compatible = "ti,omap4-keypad";
+ ti,hwmods = "kbd";
+ };
};
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-07-20 10:38 ` Sourav Poddar
@ 2012-08-14 6:23 ` Poddar, Sourav
-1 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-14 6:23 UTC (permalink / raw)
To: tony, devicetree-discuss
Cc: linux-omap, linux-arm-kernel, kishon, Sourav Poddar,
Benoit Cousson, Rob Herring, Grant Likely, Felipe Balbi
Hi,
On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> Add keypad data node in omap4 device tree file.
> Also fill the device tree binding parameters
> with the required value in "omap4-sdp" dts file.
>
> Tested on omap4430 sdp with 3.5-rc6 kernel.
>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> Changes since v6:
> -remove address from the node since reg property
> is not used.
> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 5 +++
> 2 files changed, 75 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 72216e9..80cd016 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -113,6 +113,76 @@
> "DMic", "Digital Mic",
> "Digital Mic", "Digital Mic1 Bias";
> };
> +
> + keypad {
> + keypad,num-rows = <8>;
> + keypad,num-columns = <8>;
> + linux,keymap = < 0x00000012
> + 0x00010013
> + 0x00020014
> + 0x00030066
> + 0x0004003f
> + 0x000500f0
> + 0x00060017
> + 0x0007002a
> + 0x01000020
> + 0x01010021
> + 0x01020022
> + 0x010300e7
> + 0x01040040
> + 0x010500f0
> + 0x01060025
> + 0x0107001c
> + 0x0200002d
> + 0x0201002e
> + 0x0202002f
> + 0x0203006b
> + 0x02040041
> + 0x020500f0
> + 0x02060034
> + 0x0207003a
> + 0x0300002c
> + 0x0301004e
> + 0x03020030
> + 0x0303003b
> + 0x03040042
> + 0x030500f0
> + 0x03060018
> + 0x03070039
> + 0x04000011
> + 0x04010015
> + 0x04020016
> + 0x0403003c
> + 0x04040073
> + 0x040500f0
> + 0x04060026
> + 0x04070069
> + 0x0500001f
> + 0x05010023
> + 0x05020024
> + 0x0503003d
> + 0x05040043
> + 0x05050072
> + 0x05060032
> + 0x0507006a
> + 0x06000010
> + 0x0601001e
> + 0x06020031
> + 0x0603009e
> + 0x0604000e
> + 0x060500f0
> + 0x06060019
> + 0x06070067
> + 0x07000094
> + 0x07010095
> + 0x070200ca
> + 0x070300cb
> + 0x0704003e
> + 0x070500f0
> + 0x07060160
> + 0x0707006c >;
> + linux,input-no-autorepeat;
> + };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 04cbbcb..e78a1f1 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -296,4 +296,9 @@
> ti,hwmods = "dmic";
> };
> };
> +
> + keypad {
> + compatible = "ti,omap4-keypad";
> + ti,hwmods = "kbd";
> + };
> };
> --
> 1.7.1
>
Any more comments on this patch?
~Sourav
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 6:23 ` Poddar, Sourav
0 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-14 6:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> Add keypad data node in omap4 device tree file.
> Also fill the device tree binding parameters
> with the required value in "omap4-sdp" dts file.
>
> Tested on omap4430 sdp with 3.5-rc6 kernel.
>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> Changes since v6:
> -remove address from the node since reg property
> is not used.
> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 5 +++
> 2 files changed, 75 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 72216e9..80cd016 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -113,6 +113,76 @@
> "DMic", "Digital Mic",
> "Digital Mic", "Digital Mic1 Bias";
> };
> +
> + keypad {
> + keypad,num-rows = <8>;
> + keypad,num-columns = <8>;
> + linux,keymap = < 0x00000012
> + 0x00010013
> + 0x00020014
> + 0x00030066
> + 0x0004003f
> + 0x000500f0
> + 0x00060017
> + 0x0007002a
> + 0x01000020
> + 0x01010021
> + 0x01020022
> + 0x010300e7
> + 0x01040040
> + 0x010500f0
> + 0x01060025
> + 0x0107001c
> + 0x0200002d
> + 0x0201002e
> + 0x0202002f
> + 0x0203006b
> + 0x02040041
> + 0x020500f0
> + 0x02060034
> + 0x0207003a
> + 0x0300002c
> + 0x0301004e
> + 0x03020030
> + 0x0303003b
> + 0x03040042
> + 0x030500f0
> + 0x03060018
> + 0x03070039
> + 0x04000011
> + 0x04010015
> + 0x04020016
> + 0x0403003c
> + 0x04040073
> + 0x040500f0
> + 0x04060026
> + 0x04070069
> + 0x0500001f
> + 0x05010023
> + 0x05020024
> + 0x0503003d
> + 0x05040043
> + 0x05050072
> + 0x05060032
> + 0x0507006a
> + 0x06000010
> + 0x0601001e
> + 0x06020031
> + 0x0603009e
> + 0x0604000e
> + 0x060500f0
> + 0x06060019
> + 0x06070067
> + 0x07000094
> + 0x07010095
> + 0x070200ca
> + 0x070300cb
> + 0x0704003e
> + 0x070500f0
> + 0x07060160
> + 0x0707006c >;
> + linux,input-no-autorepeat;
> + };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 04cbbcb..e78a1f1 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -296,4 +296,9 @@
> ti,hwmods = "dmic";
> };
> };
> +
> + keypad {
> + compatible = "ti,omap4-keypad";
> + ti,hwmods = "kbd";
> + };
> };
> --
> 1.7.1
>
Any more comments on this patch?
~Sourav
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-14 6:23 ` Poddar, Sourav
@ 2012-08-14 9:20 ` Benoit Cousson
-1 siblings, 0 replies; 20+ messages in thread
From: Benoit Cousson @ 2012-08-14 9:20 UTC (permalink / raw)
To: Poddar, Sourav
Cc: tony, devicetree-discuss, linux-omap, linux-arm-kernel, kishon,
Rob Herring, Grant Likely, Felipe Balbi
Hi Sourav
On 08/14/2012 08:23 AM, Poddar, Sourav wrote:
> Hi,
>
> On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>> Add keypad data node in omap4 device tree file.
>> Also fill the device tree binding parameters
>> with the required value in "omap4-sdp" dts file.
>>
>> Tested on omap4430 sdp with 3.5-rc6 kernel.
>>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>> ---
>> Changes since v6:
>> -remove address from the node since reg property
>> is not used.
>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>> index 72216e9..80cd016 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -113,6 +113,76 @@
>> "DMic", "Digital Mic",
>> "Digital Mic", "Digital Mic1 Bias";
>> };
>> +
>> + keypad {
>> + keypad,num-rows = <8>;
>> + keypad,num-columns = <8>;
>> + linux,keymap = < 0x00000012
>> + 0x00010013
>> + 0x00020014
>> + 0x00030066
>> + 0x0004003f
>> + 0x000500f0
>> + 0x00060017
>> + 0x0007002a
>> + 0x01000020
>> + 0x01010021
>> + 0x01020022
>> + 0x010300e7
>> + 0x01040040
>> + 0x010500f0
>> + 0x01060025
>> + 0x0107001c
>> + 0x0200002d
>> + 0x0201002e
>> + 0x0202002f
>> + 0x0203006b
>> + 0x02040041
>> + 0x020500f0
>> + 0x02060034
>> + 0x0207003a
>> + 0x0300002c
>> + 0x0301004e
>> + 0x03020030
>> + 0x0303003b
>> + 0x03040042
>> + 0x030500f0
>> + 0x03060018
>> + 0x03070039
>> + 0x04000011
>> + 0x04010015
>> + 0x04020016
>> + 0x0403003c
>> + 0x04040073
>> + 0x040500f0
>> + 0x04060026
>> + 0x04070069
>> + 0x0500001f
>> + 0x05010023
>> + 0x05020024
>> + 0x0503003d
>> + 0x05040043
>> + 0x05050072
>> + 0x05060032
>> + 0x0507006a
>> + 0x06000010
>> + 0x0601001e
>> + 0x06020031
>> + 0x0603009e
>> + 0x0604000e
>> + 0x060500f0
>> + 0x06060019
>> + 0x06070067
>> + 0x07000094
>> + 0x07010095
>> + 0x070200ca
>> + 0x070300cb
>> + 0x0704003e
>> + 0x070500f0
>> + 0x07060160
>> + 0x0707006c >;
I know that the hex value are faster to parse than the explicit
information, but maybe you could at least comment each entry?
Otherwise is looks fine to me.
Thanks,
Benoit
>> + linux,input-no-autorepeat;
>> + };
>> };
>>
>> &i2c1 {
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 04cbbcb..e78a1f1 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -296,4 +296,9 @@
>> ti,hwmods = "dmic";
>> };
>> };
>> +
>> + keypad {
>> + compatible = "ti,omap4-keypad";
>> + ti,hwmods = "kbd";
>> + };
>> };
>> --
>> 1.7.1
>>
> Any more comments on this patch?
>
> ~Sourav
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 9:20 ` Benoit Cousson
0 siblings, 0 replies; 20+ messages in thread
From: Benoit Cousson @ 2012-08-14 9:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sourav
On 08/14/2012 08:23 AM, Poddar, Sourav wrote:
> Hi,
>
> On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>> Add keypad data node in omap4 device tree file.
>> Also fill the device tree binding parameters
>> with the required value in "omap4-sdp" dts file.
>>
>> Tested on omap4430 sdp with 3.5-rc6 kernel.
>>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>> ---
>> Changes since v6:
>> -remove address from the node since reg property
>> is not used.
>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>> index 72216e9..80cd016 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -113,6 +113,76 @@
>> "DMic", "Digital Mic",
>> "Digital Mic", "Digital Mic1 Bias";
>> };
>> +
>> + keypad {
>> + keypad,num-rows = <8>;
>> + keypad,num-columns = <8>;
>> + linux,keymap = < 0x00000012
>> + 0x00010013
>> + 0x00020014
>> + 0x00030066
>> + 0x0004003f
>> + 0x000500f0
>> + 0x00060017
>> + 0x0007002a
>> + 0x01000020
>> + 0x01010021
>> + 0x01020022
>> + 0x010300e7
>> + 0x01040040
>> + 0x010500f0
>> + 0x01060025
>> + 0x0107001c
>> + 0x0200002d
>> + 0x0201002e
>> + 0x0202002f
>> + 0x0203006b
>> + 0x02040041
>> + 0x020500f0
>> + 0x02060034
>> + 0x0207003a
>> + 0x0300002c
>> + 0x0301004e
>> + 0x03020030
>> + 0x0303003b
>> + 0x03040042
>> + 0x030500f0
>> + 0x03060018
>> + 0x03070039
>> + 0x04000011
>> + 0x04010015
>> + 0x04020016
>> + 0x0403003c
>> + 0x04040073
>> + 0x040500f0
>> + 0x04060026
>> + 0x04070069
>> + 0x0500001f
>> + 0x05010023
>> + 0x05020024
>> + 0x0503003d
>> + 0x05040043
>> + 0x05050072
>> + 0x05060032
>> + 0x0507006a
>> + 0x06000010
>> + 0x0601001e
>> + 0x06020031
>> + 0x0603009e
>> + 0x0604000e
>> + 0x060500f0
>> + 0x06060019
>> + 0x06070067
>> + 0x07000094
>> + 0x07010095
>> + 0x070200ca
>> + 0x070300cb
>> + 0x0704003e
>> + 0x070500f0
>> + 0x07060160
>> + 0x0707006c >;
I know that the hex value are faster to parse than the explicit
information, but maybe you could at least comment each entry?
Otherwise is looks fine to me.
Thanks,
Benoit
>> + linux,input-no-autorepeat;
>> + };
>> };
>>
>> &i2c1 {
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 04cbbcb..e78a1f1 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -296,4 +296,9 @@
>> ti,hwmods = "dmic";
>> };
>> };
>> +
>> + keypad {
>> + compatible = "ti,omap4-keypad";
>> + ti,hwmods = "kbd";
>> + };
>> };
>> --
>> 1.7.1
>>
> Any more comments on this patch?
>
> ~Sourav
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-14 9:20 ` Benoit Cousson
@ 2012-08-14 9:23 ` Poddar, Sourav
-1 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-14 9:23 UTC (permalink / raw)
To: Benoit Cousson
Cc: tony, devicetree-discuss, linux-omap, linux-arm-kernel, kishon,
Rob Herring, Grant Likely, Felipe Balbi
Hi Benoit,
On Tue, Aug 14, 2012 at 2:50 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> Hi Sourav
>
> On 08/14/2012 08:23 AM, Poddar, Sourav wrote:
>> Hi,
>>
>> On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>> Add keypad data node in omap4 device tree file.
>>> Also fill the device tree binding parameters
>>> with the required value in "omap4-sdp" dts file.
>>>
>>> Tested on omap4430 sdp with 3.5-rc6 kernel.
>>>
>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: Felipe Balbi <balbi@ti.com>
>>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>>> ---
>>> Changes since v6:
>>> -remove address from the node since reg property
>>> is not used.
>>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>>> index 72216e9..80cd016 100644
>>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>>> @@ -113,6 +113,76 @@
>>> "DMic", "Digital Mic",
>>> "Digital Mic", "Digital Mic1 Bias";
>>> };
>>> +
>>> + keypad {
>>> + keypad,num-rows = <8>;
>>> + keypad,num-columns = <8>;
>>> + linux,keymap = < 0x00000012
>>> + 0x00010013
>>> + 0x00020014
>>> + 0x00030066
>>> + 0x0004003f
>>> + 0x000500f0
>>> + 0x00060017
>>> + 0x0007002a
>>> + 0x01000020
>>> + 0x01010021
>>> + 0x01020022
>>> + 0x010300e7
>>> + 0x01040040
>>> + 0x010500f0
>>> + 0x01060025
>>> + 0x0107001c
>>> + 0x0200002d
>>> + 0x0201002e
>>> + 0x0202002f
>>> + 0x0203006b
>>> + 0x02040041
>>> + 0x020500f0
>>> + 0x02060034
>>> + 0x0207003a
>>> + 0x0300002c
>>> + 0x0301004e
>>> + 0x03020030
>>> + 0x0303003b
>>> + 0x03040042
>>> + 0x030500f0
>>> + 0x03060018
>>> + 0x03070039
>>> + 0x04000011
>>> + 0x04010015
>>> + 0x04020016
>>> + 0x0403003c
>>> + 0x04040073
>>> + 0x040500f0
>>> + 0x04060026
>>> + 0x04070069
>>> + 0x0500001f
>>> + 0x05010023
>>> + 0x05020024
>>> + 0x0503003d
>>> + 0x05040043
>>> + 0x05050072
>>> + 0x05060032
>>> + 0x0507006a
>>> + 0x06000010
>>> + 0x0601001e
>>> + 0x06020031
>>> + 0x0603009e
>>> + 0x0604000e
>>> + 0x060500f0
>>> + 0x06060019
>>> + 0x06070067
>>> + 0x07000094
>>> + 0x07010095
>>> + 0x070200ca
>>> + 0x070300cb
>>> + 0x0704003e
>>> + 0x070500f0
>>> + 0x07060160
>>> + 0x0707006c >;
>
> I know that the hex value are faster to parse than the explicit
> information, but maybe you could at least comment each entry?
>
Yes, will add the comment and post a new version.
Thanks,
Sourav
> Otherwise is looks fine to me.
>
> Thanks,
> Benoit
>
>>> + linux,input-no-autorepeat;
>>> + };
>>> };
>>>
>>> &i2c1 {
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 04cbbcb..e78a1f1 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -296,4 +296,9 @@
>>> ti,hwmods = "dmic";
>>> };
>>> };
>>> +
>>> + keypad {
>>> + compatible = "ti,omap4-keypad";
>>> + ti,hwmods = "kbd";
>>> + };
>>> };
>>> --
>>> 1.7.1
>>>
>> Any more comments on this patch?
>>
>> ~Sourav
>>
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 9:23 ` Poddar, Sourav
0 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-14 9:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Benoit,
On Tue, Aug 14, 2012 at 2:50 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> Hi Sourav
>
> On 08/14/2012 08:23 AM, Poddar, Sourav wrote:
>> Hi,
>>
>> On Fri, Jul 20, 2012 at 4:08 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>> Add keypad data node in omap4 device tree file.
>>> Also fill the device tree binding parameters
>>> with the required value in "omap4-sdp" dts file.
>>>
>>> Tested on omap4430 sdp with 3.5-rc6 kernel.
>>>
>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: Felipe Balbi <balbi@ti.com>
>>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>>> ---
>>> Changes since v6:
>>> -remove address from the node since reg property
>>> is not used.
>>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>>> index 72216e9..80cd016 100644
>>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>>> @@ -113,6 +113,76 @@
>>> "DMic", "Digital Mic",
>>> "Digital Mic", "Digital Mic1 Bias";
>>> };
>>> +
>>> + keypad {
>>> + keypad,num-rows = <8>;
>>> + keypad,num-columns = <8>;
>>> + linux,keymap = < 0x00000012
>>> + 0x00010013
>>> + 0x00020014
>>> + 0x00030066
>>> + 0x0004003f
>>> + 0x000500f0
>>> + 0x00060017
>>> + 0x0007002a
>>> + 0x01000020
>>> + 0x01010021
>>> + 0x01020022
>>> + 0x010300e7
>>> + 0x01040040
>>> + 0x010500f0
>>> + 0x01060025
>>> + 0x0107001c
>>> + 0x0200002d
>>> + 0x0201002e
>>> + 0x0202002f
>>> + 0x0203006b
>>> + 0x02040041
>>> + 0x020500f0
>>> + 0x02060034
>>> + 0x0207003a
>>> + 0x0300002c
>>> + 0x0301004e
>>> + 0x03020030
>>> + 0x0303003b
>>> + 0x03040042
>>> + 0x030500f0
>>> + 0x03060018
>>> + 0x03070039
>>> + 0x04000011
>>> + 0x04010015
>>> + 0x04020016
>>> + 0x0403003c
>>> + 0x04040073
>>> + 0x040500f0
>>> + 0x04060026
>>> + 0x04070069
>>> + 0x0500001f
>>> + 0x05010023
>>> + 0x05020024
>>> + 0x0503003d
>>> + 0x05040043
>>> + 0x05050072
>>> + 0x05060032
>>> + 0x0507006a
>>> + 0x06000010
>>> + 0x0601001e
>>> + 0x06020031
>>> + 0x0603009e
>>> + 0x0604000e
>>> + 0x060500f0
>>> + 0x06060019
>>> + 0x06070067
>>> + 0x07000094
>>> + 0x07010095
>>> + 0x070200ca
>>> + 0x070300cb
>>> + 0x0704003e
>>> + 0x070500f0
>>> + 0x07060160
>>> + 0x0707006c >;
>
> I know that the hex value are faster to parse than the explicit
> information, but maybe you could at least comment each entry?
>
Yes, will add the comment and post a new version.
Thanks,
Sourav
> Otherwise is looks fine to me.
>
> Thanks,
> Benoit
>
>>> + linux,input-no-autorepeat;
>>> + };
>>> };
>>>
>>> &i2c1 {
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 04cbbcb..e78a1f1 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -296,4 +296,9 @@
>>> ti,hwmods = "dmic";
>>> };
>>> };
>>> +
>>> + keypad {
>>> + compatible = "ti,omap4-keypad";
>>> + ti,hwmods = "kbd";
>>> + };
>>> };
>>> --
>>> 1.7.1
>>>
>> Any more comments on this patch?
>>
>> ~Sourav
>>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 11:15 ` Sourav Poddar
0 siblings, 0 replies; 20+ messages in thread
From: Sourav Poddar @ 2012-08-14 11:15 UTC (permalink / raw)
To: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel
Cc: Sourav Poddar, Tony Lindgren, Benoit Cousson, Rob Herring,
Grant Likely, Felipe Balbi
Add keypad data node in omap4 device tree file.
Also fill the device tree binding parameters
with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v6->v7
Add key name as a comment.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 5 +++
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 72216e9..8e200f4 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -113,6 +113,76 @@
"DMic", "Digital Mic",
"Digital Mic", "Digital Mic1 Bias";
};
+
+ keypad {
+ keypad,num-rows = <8>;
+ keypad,num-columns = <8>;
+ linux,keymap = < 0x00000012 /* KEY_E */
+ 0x00010013 /* KEY_R */
+ 0x00020014 /* KEY_T */
+ 0x00030066 /* KEY_HOME */
+ 0x0004003f /* KEY_F5 */
+ 0x000500f0 /* KEY_UNKNOWN */
+ 0x00060017 /* KEY_I */
+ 0x0007002a /* KEY_LEFTSHIFT */
+ 0x01000020 /* KEY_D*/
+ 0x01010021 /* KEY_F */
+ 0x01020022 /* KEY_G */
+ 0x010300e7 /* KEY_SEND */
+ 0x01040040 /* KEY_F6 */
+ 0x010500f0 /* KEY_UNKNOWN */
+ 0x01060025 /* KEY_K */
+ 0x0107001c /* KEY_ENTER */
+ 0x0200002d /* KEY_X */
+ 0x0201002e /* KEY_C */
+ 0x0202002f /* KEY_V */
+ 0x0203006b /* KEY_END */
+ 0x02040041 /* KEY_F7 */
+ 0x020500f0 /* KEY_UNKNOWN */
+ 0x02060034 /* KEY_DOT */
+ 0x0207003a /* KEY_CAPSLOCK */
+ 0x0300002c /* KEY_Z */
+ 0x0301004e /* KEY_KPLUS */
+ 0x03020030 /* KEY_B */
+ 0x0303003b /* KEY_F1 */
+ 0x03040042 /* KEY_F8 */
+ 0x030500f0 /* KEY_UNKNOWN */
+ 0x03060018 /* KEY_O */
+ 0x03070039 /* KEY_SPACE */
+ 0x04000011 /* KEY_W */
+ 0x04010015 /* KEY_Y */
+ 0x04020016 /* KEY_U */
+ 0x0403003c /* KEY_F2 */
+ 0x04040073 /* KEY_VOLUMEUP */
+ 0x040500f0 /* KEY_UNKNOWN */
+ 0x04060026 /* KEY_L */
+ 0x04070069 /* KEY_LEFT */
+ 0x0500001f /* KEY_S */
+ 0x05010023 /* KEY_H */
+ 0x05020024 /* KEY_J */
+ 0x0503003d /* KEY_F3 */
+ 0x05040043 /* KEY_F9 */
+ 0x05050072 /* KEY_VOLUMEDOWN */
+ 0x05060032 /* KEY_M */
+ 0x0507006a /* KEY_RIGHT */
+ 0x06000010 /* KEY_Q */
+ 0x0601001e /* KEY_A */
+ 0x06020031 /* KEY_N */
+ 0x0603009e /* KEY_BACK */
+ 0x0604000e /* KEY_BACKSPACE */
+ 0x060500f0 /* KEY_UNKNOWN */
+ 0x06060019 /* KEY_P */
+ 0x06070067 /* KEY_UP */
+ 0x07000094 /* KEY_PROG1 */
+ 0x07010095 /* KEY_PROG2 */
+ 0x070200ca /* KEY_PROG3 */
+ 0x070300cb /* KEY_PROG4 */
+ 0x0704003e /* KEY_F4 */
+ 0x070500f0 /* KEY_UNKNOWN */
+ 0x07060160 /* KEY_OK */
+ 0x0707006c >; /* KEY_DOWN */
+ linux,input-no-autorepeat;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 04cbbcb..e78a1f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -296,4 +296,9 @@
ti,hwmods = "dmic";
};
};
+
+ keypad {
+ compatible = "ti,omap4-keypad";
+ ti,hwmods = "kbd";
+ };
};
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 11:15 ` Sourav Poddar
0 siblings, 0 replies; 20+ messages in thread
From: Sourav Poddar @ 2012-08-14 11:15 UTC (permalink / raw)
To: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel
Cc: Sourav Poddar, Tony Lindgren, Benoit Cousson, Rob Herring,
Grant Likely, Felipe Balbi
Add keypad data node in omap4 device tree file.
Also fill the device tree binding parameters
with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v6->v7
Add key name as a comment.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 5 +++
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 72216e9..8e200f4 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -113,6 +113,76 @@
"DMic", "Digital Mic",
"Digital Mic", "Digital Mic1 Bias";
};
+
+ keypad {
+ keypad,num-rows = <8>;
+ keypad,num-columns = <8>;
+ linux,keymap = < 0x00000012 /* KEY_E */
+ 0x00010013 /* KEY_R */
+ 0x00020014 /* KEY_T */
+ 0x00030066 /* KEY_HOME */
+ 0x0004003f /* KEY_F5 */
+ 0x000500f0 /* KEY_UNKNOWN */
+ 0x00060017 /* KEY_I */
+ 0x0007002a /* KEY_LEFTSHIFT */
+ 0x01000020 /* KEY_D*/
+ 0x01010021 /* KEY_F */
+ 0x01020022 /* KEY_G */
+ 0x010300e7 /* KEY_SEND */
+ 0x01040040 /* KEY_F6 */
+ 0x010500f0 /* KEY_UNKNOWN */
+ 0x01060025 /* KEY_K */
+ 0x0107001c /* KEY_ENTER */
+ 0x0200002d /* KEY_X */
+ 0x0201002e /* KEY_C */
+ 0x0202002f /* KEY_V */
+ 0x0203006b /* KEY_END */
+ 0x02040041 /* KEY_F7 */
+ 0x020500f0 /* KEY_UNKNOWN */
+ 0x02060034 /* KEY_DOT */
+ 0x0207003a /* KEY_CAPSLOCK */
+ 0x0300002c /* KEY_Z */
+ 0x0301004e /* KEY_KPLUS */
+ 0x03020030 /* KEY_B */
+ 0x0303003b /* KEY_F1 */
+ 0x03040042 /* KEY_F8 */
+ 0x030500f0 /* KEY_UNKNOWN */
+ 0x03060018 /* KEY_O */
+ 0x03070039 /* KEY_SPACE */
+ 0x04000011 /* KEY_W */
+ 0x04010015 /* KEY_Y */
+ 0x04020016 /* KEY_U */
+ 0x0403003c /* KEY_F2 */
+ 0x04040073 /* KEY_VOLUMEUP */
+ 0x040500f0 /* KEY_UNKNOWN */
+ 0x04060026 /* KEY_L */
+ 0x04070069 /* KEY_LEFT */
+ 0x0500001f /* KEY_S */
+ 0x05010023 /* KEY_H */
+ 0x05020024 /* KEY_J */
+ 0x0503003d /* KEY_F3 */
+ 0x05040043 /* KEY_F9 */
+ 0x05050072 /* KEY_VOLUMEDOWN */
+ 0x05060032 /* KEY_M */
+ 0x0507006a /* KEY_RIGHT */
+ 0x06000010 /* KEY_Q */
+ 0x0601001e /* KEY_A */
+ 0x06020031 /* KEY_N */
+ 0x0603009e /* KEY_BACK */
+ 0x0604000e /* KEY_BACKSPACE */
+ 0x060500f0 /* KEY_UNKNOWN */
+ 0x06060019 /* KEY_P */
+ 0x06070067 /* KEY_UP */
+ 0x07000094 /* KEY_PROG1 */
+ 0x07010095 /* KEY_PROG2 */
+ 0x070200ca /* KEY_PROG3 */
+ 0x070300cb /* KEY_PROG4 */
+ 0x0704003e /* KEY_F4 */
+ 0x070500f0 /* KEY_UNKNOWN */
+ 0x07060160 /* KEY_OK */
+ 0x0707006c >; /* KEY_DOWN */
+ linux,input-no-autorepeat;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 04cbbcb..e78a1f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -296,4 +296,9 @@
ti,hwmods = "dmic";
};
};
+
+ keypad {
+ compatible = "ti,omap4-keypad";
+ ti,hwmods = "kbd";
+ };
};
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-14 11:15 ` Sourav Poddar
0 siblings, 0 replies; 20+ messages in thread
From: Sourav Poddar @ 2012-08-14 11:15 UTC (permalink / raw)
To: linux-arm-kernel
Add keypad data node in omap4 device tree file.
Also fill the device tree binding parameters
with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
v6->v7
Add key name as a comment.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 5 +++
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 72216e9..8e200f4 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -113,6 +113,76 @@
"DMic", "Digital Mic",
"Digital Mic", "Digital Mic1 Bias";
};
+
+ keypad {
+ keypad,num-rows = <8>;
+ keypad,num-columns = <8>;
+ linux,keymap = < 0x00000012 /* KEY_E */
+ 0x00010013 /* KEY_R */
+ 0x00020014 /* KEY_T */
+ 0x00030066 /* KEY_HOME */
+ 0x0004003f /* KEY_F5 */
+ 0x000500f0 /* KEY_UNKNOWN */
+ 0x00060017 /* KEY_I */
+ 0x0007002a /* KEY_LEFTSHIFT */
+ 0x01000020 /* KEY_D*/
+ 0x01010021 /* KEY_F */
+ 0x01020022 /* KEY_G */
+ 0x010300e7 /* KEY_SEND */
+ 0x01040040 /* KEY_F6 */
+ 0x010500f0 /* KEY_UNKNOWN */
+ 0x01060025 /* KEY_K */
+ 0x0107001c /* KEY_ENTER */
+ 0x0200002d /* KEY_X */
+ 0x0201002e /* KEY_C */
+ 0x0202002f /* KEY_V */
+ 0x0203006b /* KEY_END */
+ 0x02040041 /* KEY_F7 */
+ 0x020500f0 /* KEY_UNKNOWN */
+ 0x02060034 /* KEY_DOT */
+ 0x0207003a /* KEY_CAPSLOCK */
+ 0x0300002c /* KEY_Z */
+ 0x0301004e /* KEY_KPLUS */
+ 0x03020030 /* KEY_B */
+ 0x0303003b /* KEY_F1 */
+ 0x03040042 /* KEY_F8 */
+ 0x030500f0 /* KEY_UNKNOWN */
+ 0x03060018 /* KEY_O */
+ 0x03070039 /* KEY_SPACE */
+ 0x04000011 /* KEY_W */
+ 0x04010015 /* KEY_Y */
+ 0x04020016 /* KEY_U */
+ 0x0403003c /* KEY_F2 */
+ 0x04040073 /* KEY_VOLUMEUP */
+ 0x040500f0 /* KEY_UNKNOWN */
+ 0x04060026 /* KEY_L */
+ 0x04070069 /* KEY_LEFT */
+ 0x0500001f /* KEY_S */
+ 0x05010023 /* KEY_H */
+ 0x05020024 /* KEY_J */
+ 0x0503003d /* KEY_F3 */
+ 0x05040043 /* KEY_F9 */
+ 0x05050072 /* KEY_VOLUMEDOWN */
+ 0x05060032 /* KEY_M */
+ 0x0507006a /* KEY_RIGHT */
+ 0x06000010 /* KEY_Q */
+ 0x0601001e /* KEY_A */
+ 0x06020031 /* KEY_N */
+ 0x0603009e /* KEY_BACK */
+ 0x0604000e /* KEY_BACKSPACE */
+ 0x060500f0 /* KEY_UNKNOWN */
+ 0x06060019 /* KEY_P */
+ 0x06070067 /* KEY_UP */
+ 0x07000094 /* KEY_PROG1 */
+ 0x07010095 /* KEY_PROG2 */
+ 0x070200ca /* KEY_PROG3 */
+ 0x070300cb /* KEY_PROG4 */
+ 0x0704003e /* KEY_F4 */
+ 0x070500f0 /* KEY_UNKNOWN */
+ 0x07060160 /* KEY_OK */
+ 0x0707006c >; /* KEY_DOWN */
+ linux,input-no-autorepeat;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 04cbbcb..e78a1f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -296,4 +296,9 @@
ti,hwmods = "dmic";
};
};
+
+ keypad {
+ compatible = "ti,omap4-keypad";
+ ti,hwmods = "kbd";
+ };
};
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-14 11:15 ` Sourav Poddar
@ 2012-08-20 11:19 ` Poddar, Sourav
-1 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-20 11:19 UTC (permalink / raw)
To: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel
Cc: Sourav Poddar, Tony Lindgren, Benoit Cousson, Rob Herring,
Grant Likely, Felipe Balbi
Hi All,
On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> Add keypad data node in omap4 device tree file.
> Also fill the device tree binding parameters
> with the required value in "omap4-sdp" dts file.
>
> Tested on omap4430 sdp.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> v6->v7
> Add key name as a comment.
> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 5 +++
> 2 files changed, 75 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 72216e9..8e200f4 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -113,6 +113,76 @@
> "DMic", "Digital Mic",
> "Digital Mic", "Digital Mic1 Bias";
> };
> +
> + keypad {
> + keypad,num-rows = <8>;
> + keypad,num-columns = <8>;
> + linux,keymap = < 0x00000012 /* KEY_E */
> + 0x00010013 /* KEY_R */
> + 0x00020014 /* KEY_T */
> + 0x00030066 /* KEY_HOME */
> + 0x0004003f /* KEY_F5 */
> + 0x000500f0 /* KEY_UNKNOWN */
> + 0x00060017 /* KEY_I */
> + 0x0007002a /* KEY_LEFTSHIFT */
> + 0x01000020 /* KEY_D*/
> + 0x01010021 /* KEY_F */
> + 0x01020022 /* KEY_G */
> + 0x010300e7 /* KEY_SEND */
> + 0x01040040 /* KEY_F6 */
> + 0x010500f0 /* KEY_UNKNOWN */
> + 0x01060025 /* KEY_K */
> + 0x0107001c /* KEY_ENTER */
> + 0x0200002d /* KEY_X */
> + 0x0201002e /* KEY_C */
> + 0x0202002f /* KEY_V */
> + 0x0203006b /* KEY_END */
> + 0x02040041 /* KEY_F7 */
> + 0x020500f0 /* KEY_UNKNOWN */
> + 0x02060034 /* KEY_DOT */
> + 0x0207003a /* KEY_CAPSLOCK */
> + 0x0300002c /* KEY_Z */
> + 0x0301004e /* KEY_KPLUS */
> + 0x03020030 /* KEY_B */
> + 0x0303003b /* KEY_F1 */
> + 0x03040042 /* KEY_F8 */
> + 0x030500f0 /* KEY_UNKNOWN */
> + 0x03060018 /* KEY_O */
> + 0x03070039 /* KEY_SPACE */
> + 0x04000011 /* KEY_W */
> + 0x04010015 /* KEY_Y */
> + 0x04020016 /* KEY_U */
> + 0x0403003c /* KEY_F2 */
> + 0x04040073 /* KEY_VOLUMEUP */
> + 0x040500f0 /* KEY_UNKNOWN */
> + 0x04060026 /* KEY_L */
> + 0x04070069 /* KEY_LEFT */
> + 0x0500001f /* KEY_S */
> + 0x05010023 /* KEY_H */
> + 0x05020024 /* KEY_J */
> + 0x0503003d /* KEY_F3 */
> + 0x05040043 /* KEY_F9 */
> + 0x05050072 /* KEY_VOLUMEDOWN */
> + 0x05060032 /* KEY_M */
> + 0x0507006a /* KEY_RIGHT */
> + 0x06000010 /* KEY_Q */
> + 0x0601001e /* KEY_A */
> + 0x06020031 /* KEY_N */
> + 0x0603009e /* KEY_BACK */
> + 0x0604000e /* KEY_BACKSPACE */
> + 0x060500f0 /* KEY_UNKNOWN */
> + 0x06060019 /* KEY_P */
> + 0x06070067 /* KEY_UP */
> + 0x07000094 /* KEY_PROG1 */
> + 0x07010095 /* KEY_PROG2 */
> + 0x070200ca /* KEY_PROG3 */
> + 0x070300cb /* KEY_PROG4 */
> + 0x0704003e /* KEY_F4 */
> + 0x070500f0 /* KEY_UNKNOWN */
> + 0x07060160 /* KEY_OK */
> + 0x0707006c >; /* KEY_DOWN */
> + linux,input-no-autorepeat;
> + };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 04cbbcb..e78a1f1 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -296,4 +296,9 @@
> ti,hwmods = "dmic";
> };
> };
> +
> + keypad {
> + compatible = "ti,omap4-keypad";
> + ti,hwmods = "kbd";
> + };
> };
> --
> 1.7.1
>
Any more comments on this?
~Sourav
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-20 11:19 ` Poddar, Sourav
0 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-20 11:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi All,
On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> Add keypad data node in omap4 device tree file.
> Also fill the device tree binding parameters
> with the required value in "omap4-sdp" dts file.
>
> Tested on omap4430 sdp.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> v6->v7
> Add key name as a comment.
> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 5 +++
> 2 files changed, 75 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 72216e9..8e200f4 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -113,6 +113,76 @@
> "DMic", "Digital Mic",
> "Digital Mic", "Digital Mic1 Bias";
> };
> +
> + keypad {
> + keypad,num-rows = <8>;
> + keypad,num-columns = <8>;
> + linux,keymap = < 0x00000012 /* KEY_E */
> + 0x00010013 /* KEY_R */
> + 0x00020014 /* KEY_T */
> + 0x00030066 /* KEY_HOME */
> + 0x0004003f /* KEY_F5 */
> + 0x000500f0 /* KEY_UNKNOWN */
> + 0x00060017 /* KEY_I */
> + 0x0007002a /* KEY_LEFTSHIFT */
> + 0x01000020 /* KEY_D*/
> + 0x01010021 /* KEY_F */
> + 0x01020022 /* KEY_G */
> + 0x010300e7 /* KEY_SEND */
> + 0x01040040 /* KEY_F6 */
> + 0x010500f0 /* KEY_UNKNOWN */
> + 0x01060025 /* KEY_K */
> + 0x0107001c /* KEY_ENTER */
> + 0x0200002d /* KEY_X */
> + 0x0201002e /* KEY_C */
> + 0x0202002f /* KEY_V */
> + 0x0203006b /* KEY_END */
> + 0x02040041 /* KEY_F7 */
> + 0x020500f0 /* KEY_UNKNOWN */
> + 0x02060034 /* KEY_DOT */
> + 0x0207003a /* KEY_CAPSLOCK */
> + 0x0300002c /* KEY_Z */
> + 0x0301004e /* KEY_KPLUS */
> + 0x03020030 /* KEY_B */
> + 0x0303003b /* KEY_F1 */
> + 0x03040042 /* KEY_F8 */
> + 0x030500f0 /* KEY_UNKNOWN */
> + 0x03060018 /* KEY_O */
> + 0x03070039 /* KEY_SPACE */
> + 0x04000011 /* KEY_W */
> + 0x04010015 /* KEY_Y */
> + 0x04020016 /* KEY_U */
> + 0x0403003c /* KEY_F2 */
> + 0x04040073 /* KEY_VOLUMEUP */
> + 0x040500f0 /* KEY_UNKNOWN */
> + 0x04060026 /* KEY_L */
> + 0x04070069 /* KEY_LEFT */
> + 0x0500001f /* KEY_S */
> + 0x05010023 /* KEY_H */
> + 0x05020024 /* KEY_J */
> + 0x0503003d /* KEY_F3 */
> + 0x05040043 /* KEY_F9 */
> + 0x05050072 /* KEY_VOLUMEDOWN */
> + 0x05060032 /* KEY_M */
> + 0x0507006a /* KEY_RIGHT */
> + 0x06000010 /* KEY_Q */
> + 0x0601001e /* KEY_A */
> + 0x06020031 /* KEY_N */
> + 0x0603009e /* KEY_BACK */
> + 0x0604000e /* KEY_BACKSPACE */
> + 0x060500f0 /* KEY_UNKNOWN */
> + 0x06060019 /* KEY_P */
> + 0x06070067 /* KEY_UP */
> + 0x07000094 /* KEY_PROG1 */
> + 0x07010095 /* KEY_PROG2 */
> + 0x070200ca /* KEY_PROG3 */
> + 0x070300cb /* KEY_PROG4 */
> + 0x0704003e /* KEY_F4 */
> + 0x070500f0 /* KEY_UNKNOWN */
> + 0x07060160 /* KEY_OK */
> + 0x0707006c >; /* KEY_DOWN */
> + linux,input-no-autorepeat;
> + };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 04cbbcb..e78a1f1 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -296,4 +296,9 @@
> ti,hwmods = "dmic";
> };
> };
> +
> + keypad {
> + compatible = "ti,omap4-keypad";
> + ti,hwmods = "kbd";
> + };
> };
> --
> 1.7.1
>
Any more comments on this?
~Sourav
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-20 11:19 ` Poddar, Sourav
@ 2012-08-20 11:34 ` Felipe Balbi
-1 siblings, 0 replies; 20+ messages in thread
From: Felipe Balbi @ 2012-08-20 11:34 UTC (permalink / raw)
To: Poddar, Sourav
Cc: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel,
Tony Lindgren, Benoit Cousson, Rob Herring, Grant Likely,
Felipe Balbi
[-- Attachment #1: Type: text/plain, Size: 5606 bytes --]
On Mon, Aug 20, 2012 at 04:49:36PM +0530, Poddar, Sourav wrote:
> Hi All,
>
> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> > Add keypad data node in omap4 device tree file.
> > Also fill the device tree binding parameters
> > with the required value in "omap4-sdp" dts file.
> >
> > Tested on omap4430 sdp.
> >
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Felipe Balbi <balbi@ti.com>
to me it looks good. you've even added comments on each key for easy
human parsing.
Acked-by: Felipe Balbi <balbi@ti.com>
> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> > ---
> > v6->v7
> > Add key name as a comment.
> > arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/omap4.dtsi | 5 +++
> > 2 files changed, 75 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> > index 72216e9..8e200f4 100644
> > --- a/arch/arm/boot/dts/omap4-sdp.dts
> > +++ b/arch/arm/boot/dts/omap4-sdp.dts
> > @@ -113,6 +113,76 @@
> > "DMic", "Digital Mic",
> > "Digital Mic", "Digital Mic1 Bias";
> > };
> > +
> > + keypad {
> > + keypad,num-rows = <8>;
> > + keypad,num-columns = <8>;
> > + linux,keymap = < 0x00000012 /* KEY_E */
> > + 0x00010013 /* KEY_R */
> > + 0x00020014 /* KEY_T */
> > + 0x00030066 /* KEY_HOME */
> > + 0x0004003f /* KEY_F5 */
> > + 0x000500f0 /* KEY_UNKNOWN */
> > + 0x00060017 /* KEY_I */
> > + 0x0007002a /* KEY_LEFTSHIFT */
> > + 0x01000020 /* KEY_D*/
> > + 0x01010021 /* KEY_F */
> > + 0x01020022 /* KEY_G */
> > + 0x010300e7 /* KEY_SEND */
> > + 0x01040040 /* KEY_F6 */
> > + 0x010500f0 /* KEY_UNKNOWN */
> > + 0x01060025 /* KEY_K */
> > + 0x0107001c /* KEY_ENTER */
> > + 0x0200002d /* KEY_X */
> > + 0x0201002e /* KEY_C */
> > + 0x0202002f /* KEY_V */
> > + 0x0203006b /* KEY_END */
> > + 0x02040041 /* KEY_F7 */
> > + 0x020500f0 /* KEY_UNKNOWN */
> > + 0x02060034 /* KEY_DOT */
> > + 0x0207003a /* KEY_CAPSLOCK */
> > + 0x0300002c /* KEY_Z */
> > + 0x0301004e /* KEY_KPLUS */
> > + 0x03020030 /* KEY_B */
> > + 0x0303003b /* KEY_F1 */
> > + 0x03040042 /* KEY_F8 */
> > + 0x030500f0 /* KEY_UNKNOWN */
> > + 0x03060018 /* KEY_O */
> > + 0x03070039 /* KEY_SPACE */
> > + 0x04000011 /* KEY_W */
> > + 0x04010015 /* KEY_Y */
> > + 0x04020016 /* KEY_U */
> > + 0x0403003c /* KEY_F2 */
> > + 0x04040073 /* KEY_VOLUMEUP */
> > + 0x040500f0 /* KEY_UNKNOWN */
> > + 0x04060026 /* KEY_L */
> > + 0x04070069 /* KEY_LEFT */
> > + 0x0500001f /* KEY_S */
> > + 0x05010023 /* KEY_H */
> > + 0x05020024 /* KEY_J */
> > + 0x0503003d /* KEY_F3 */
> > + 0x05040043 /* KEY_F9 */
> > + 0x05050072 /* KEY_VOLUMEDOWN */
> > + 0x05060032 /* KEY_M */
> > + 0x0507006a /* KEY_RIGHT */
> > + 0x06000010 /* KEY_Q */
> > + 0x0601001e /* KEY_A */
> > + 0x06020031 /* KEY_N */
> > + 0x0603009e /* KEY_BACK */
> > + 0x0604000e /* KEY_BACKSPACE */
> > + 0x060500f0 /* KEY_UNKNOWN */
> > + 0x06060019 /* KEY_P */
> > + 0x06070067 /* KEY_UP */
> > + 0x07000094 /* KEY_PROG1 */
> > + 0x07010095 /* KEY_PROG2 */
> > + 0x070200ca /* KEY_PROG3 */
> > + 0x070300cb /* KEY_PROG4 */
> > + 0x0704003e /* KEY_F4 */
> > + 0x070500f0 /* KEY_UNKNOWN */
> > + 0x07060160 /* KEY_OK */
> > + 0x0707006c >; /* KEY_DOWN */
> > + linux,input-no-autorepeat;
> > + };
> > };
> >
> > &i2c1 {
> > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> > index 04cbbcb..e78a1f1 100644
> > --- a/arch/arm/boot/dts/omap4.dtsi
> > +++ b/arch/arm/boot/dts/omap4.dtsi
> > @@ -296,4 +296,9 @@
> > ti,hwmods = "dmic";
> > };
> > };
> > +
> > + keypad {
> > + compatible = "ti,omap4-keypad";
> > + ti,hwmods = "kbd";
> > + };
> > };
> > --
> > 1.7.1
> >
> Any more comments on this?
>
> ~Sourav
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-20 11:34 ` Felipe Balbi
0 siblings, 0 replies; 20+ messages in thread
From: Felipe Balbi @ 2012-08-20 11:34 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 20, 2012 at 04:49:36PM +0530, Poddar, Sourav wrote:
> Hi All,
>
> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> > Add keypad data node in omap4 device tree file.
> > Also fill the device tree binding parameters
> > with the required value in "omap4-sdp" dts file.
> >
> > Tested on omap4430 sdp.
> >
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Felipe Balbi <balbi@ti.com>
to me it looks good. you've even added comments on each key for easy
human parsing.
Acked-by: Felipe Balbi <balbi@ti.com>
> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> > ---
> > v6->v7
> > Add key name as a comment.
> > arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
> > arch/arm/boot/dts/omap4.dtsi | 5 +++
> > 2 files changed, 75 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> > index 72216e9..8e200f4 100644
> > --- a/arch/arm/boot/dts/omap4-sdp.dts
> > +++ b/arch/arm/boot/dts/omap4-sdp.dts
> > @@ -113,6 +113,76 @@
> > "DMic", "Digital Mic",
> > "Digital Mic", "Digital Mic1 Bias";
> > };
> > +
> > + keypad {
> > + keypad,num-rows = <8>;
> > + keypad,num-columns = <8>;
> > + linux,keymap = < 0x00000012 /* KEY_E */
> > + 0x00010013 /* KEY_R */
> > + 0x00020014 /* KEY_T */
> > + 0x00030066 /* KEY_HOME */
> > + 0x0004003f /* KEY_F5 */
> > + 0x000500f0 /* KEY_UNKNOWN */
> > + 0x00060017 /* KEY_I */
> > + 0x0007002a /* KEY_LEFTSHIFT */
> > + 0x01000020 /* KEY_D*/
> > + 0x01010021 /* KEY_F */
> > + 0x01020022 /* KEY_G */
> > + 0x010300e7 /* KEY_SEND */
> > + 0x01040040 /* KEY_F6 */
> > + 0x010500f0 /* KEY_UNKNOWN */
> > + 0x01060025 /* KEY_K */
> > + 0x0107001c /* KEY_ENTER */
> > + 0x0200002d /* KEY_X */
> > + 0x0201002e /* KEY_C */
> > + 0x0202002f /* KEY_V */
> > + 0x0203006b /* KEY_END */
> > + 0x02040041 /* KEY_F7 */
> > + 0x020500f0 /* KEY_UNKNOWN */
> > + 0x02060034 /* KEY_DOT */
> > + 0x0207003a /* KEY_CAPSLOCK */
> > + 0x0300002c /* KEY_Z */
> > + 0x0301004e /* KEY_KPLUS */
> > + 0x03020030 /* KEY_B */
> > + 0x0303003b /* KEY_F1 */
> > + 0x03040042 /* KEY_F8 */
> > + 0x030500f0 /* KEY_UNKNOWN */
> > + 0x03060018 /* KEY_O */
> > + 0x03070039 /* KEY_SPACE */
> > + 0x04000011 /* KEY_W */
> > + 0x04010015 /* KEY_Y */
> > + 0x04020016 /* KEY_U */
> > + 0x0403003c /* KEY_F2 */
> > + 0x04040073 /* KEY_VOLUMEUP */
> > + 0x040500f0 /* KEY_UNKNOWN */
> > + 0x04060026 /* KEY_L */
> > + 0x04070069 /* KEY_LEFT */
> > + 0x0500001f /* KEY_S */
> > + 0x05010023 /* KEY_H */
> > + 0x05020024 /* KEY_J */
> > + 0x0503003d /* KEY_F3 */
> > + 0x05040043 /* KEY_F9 */
> > + 0x05050072 /* KEY_VOLUMEDOWN */
> > + 0x05060032 /* KEY_M */
> > + 0x0507006a /* KEY_RIGHT */
> > + 0x06000010 /* KEY_Q */
> > + 0x0601001e /* KEY_A */
> > + 0x06020031 /* KEY_N */
> > + 0x0603009e /* KEY_BACK */
> > + 0x0604000e /* KEY_BACKSPACE */
> > + 0x060500f0 /* KEY_UNKNOWN */
> > + 0x06060019 /* KEY_P */
> > + 0x06070067 /* KEY_UP */
> > + 0x07000094 /* KEY_PROG1 */
> > + 0x07010095 /* KEY_PROG2 */
> > + 0x070200ca /* KEY_PROG3 */
> > + 0x070300cb /* KEY_PROG4 */
> > + 0x0704003e /* KEY_F4 */
> > + 0x070500f0 /* KEY_UNKNOWN */
> > + 0x07060160 /* KEY_OK */
> > + 0x0707006c >; /* KEY_DOWN */
> > + linux,input-no-autorepeat;
> > + };
> > };
> >
> > &i2c1 {
> > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> > index 04cbbcb..e78a1f1 100644
> > --- a/arch/arm/boot/dts/omap4.dtsi
> > +++ b/arch/arm/boot/dts/omap4.dtsi
> > @@ -296,4 +296,9 @@
> > ti,hwmods = "dmic";
> > };
> > };
> > +
> > + keypad {
> > + compatible = "ti,omap4-keypad";
> > + ti,hwmods = "kbd";
> > + };
> > };
> > --
> > 1.7.1
> >
> Any more comments on this?
>
> ~Sourav
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120820/446433a5/attachment.sig>
^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <CAKdam57n1jA5_7EOLcsB=u5X4wX6hPVXoZ2HLrnpEKS3kLZ=OQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-20 11:19 ` Poddar, Sourav
(?)
@ 2012-08-20 11:53 ` Benoit Cousson
-1 siblings, 0 replies; 20+ messages in thread
From: Benoit Cousson @ 2012-08-20 11:53 UTC (permalink / raw)
To: Poddar, Sourav
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Felipe Balbi,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Sourav,
On 08/20/2012 01:19 PM, Poddar, Sourav wrote:
> Hi All,
>
> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org> wrote:
>> Add keypad data node in omap4 device tree file.
>> Also fill the device tree binding parameters
>> with the required value in "omap4-sdp" dts file.
>>
>> Tested on omap4430 sdp.
>>
>> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>> Cc: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>
>> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>> Signed-off-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
>> ---
>> v6->v7
>> Add key name as a comment.
>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>> index 72216e9..8e200f4 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -113,6 +113,76 @@
>> "DMic", "Digital Mic",
>> "Digital Mic", "Digital Mic1 Bias";
>> };
>> +
>> + keypad {
>> + keypad,num-rows = <8>;
>> + keypad,num-columns = <8>;
>> + linux,keymap = < 0x00000012 /* KEY_E */
>> + 0x00010013 /* KEY_R */
>> + 0x00020014 /* KEY_T */
>> + 0x00030066 /* KEY_HOME */
>> + 0x0004003f /* KEY_F5 */
>> + 0x000500f0 /* KEY_UNKNOWN */
>> + 0x00060017 /* KEY_I */
>> + 0x0007002a /* KEY_LEFTSHIFT */
>> + 0x01000020 /* KEY_D*/
>> + 0x01010021 /* KEY_F */
>> + 0x01020022 /* KEY_G */
>> + 0x010300e7 /* KEY_SEND */
>> + 0x01040040 /* KEY_F6 */
>> + 0x010500f0 /* KEY_UNKNOWN */
>> + 0x01060025 /* KEY_K */
>> + 0x0107001c /* KEY_ENTER */
>> + 0x0200002d /* KEY_X */
>> + 0x0201002e /* KEY_C */
>> + 0x0202002f /* KEY_V */
>> + 0x0203006b /* KEY_END */
>> + 0x02040041 /* KEY_F7 */
>> + 0x020500f0 /* KEY_UNKNOWN */
>> + 0x02060034 /* KEY_DOT */
>> + 0x0207003a /* KEY_CAPSLOCK */
>> + 0x0300002c /* KEY_Z */
>> + 0x0301004e /* KEY_KPLUS */
>> + 0x03020030 /* KEY_B */
>> + 0x0303003b /* KEY_F1 */
>> + 0x03040042 /* KEY_F8 */
>> + 0x030500f0 /* KEY_UNKNOWN */
>> + 0x03060018 /* KEY_O */
>> + 0x03070039 /* KEY_SPACE */
>> + 0x04000011 /* KEY_W */
>> + 0x04010015 /* KEY_Y */
>> + 0x04020016 /* KEY_U */
>> + 0x0403003c /* KEY_F2 */
>> + 0x04040073 /* KEY_VOLUMEUP */
>> + 0x040500f0 /* KEY_UNKNOWN */
>> + 0x04060026 /* KEY_L */
>> + 0x04070069 /* KEY_LEFT */
>> + 0x0500001f /* KEY_S */
>> + 0x05010023 /* KEY_H */
>> + 0x05020024 /* KEY_J */
>> + 0x0503003d /* KEY_F3 */
>> + 0x05040043 /* KEY_F9 */
>> + 0x05050072 /* KEY_VOLUMEDOWN */
>> + 0x05060032 /* KEY_M */
>> + 0x0507006a /* KEY_RIGHT */
>> + 0x06000010 /* KEY_Q */
>> + 0x0601001e /* KEY_A */
>> + 0x06020031 /* KEY_N */
>> + 0x0603009e /* KEY_BACK */
>> + 0x0604000e /* KEY_BACKSPACE */
>> + 0x060500f0 /* KEY_UNKNOWN */
>> + 0x06060019 /* KEY_P */
>> + 0x06070067 /* KEY_UP */
>> + 0x07000094 /* KEY_PROG1 */
>> + 0x07010095 /* KEY_PROG2 */
>> + 0x070200ca /* KEY_PROG3 */
>> + 0x070300cb /* KEY_PROG4 */
>> + 0x0704003e /* KEY_F4 */
>> + 0x070500f0 /* KEY_UNKNOWN */
>> + 0x07060160 /* KEY_OK */
>> + 0x0707006c >; /* KEY_DOWN */
>> + linux,input-no-autorepeat;
>> + };
>> };
>>
>> &i2c1 {
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 04cbbcb..e78a1f1 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -296,4 +296,9 @@
>> ti,hwmods = "dmic";
>> };
>> };
>> +
>> + keypad {
>> + compatible = "ti,omap4-keypad";
>> + ti,hwmods = "kbd";
>> + };
>> };
>> --
>> 1.7.1
>>
> Any more comments on this?
That's perfect.
I'll take it and send it with other DT patches to Tony.
Regards,
Benoit
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-20 11:53 ` Benoit Cousson
0 siblings, 0 replies; 20+ messages in thread
From: Benoit Cousson @ 2012-08-20 11:53 UTC (permalink / raw)
To: Poddar, Sourav
Cc: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel,
Tony Lindgren, Rob Herring, Grant Likely, Felipe Balbi
Hi Sourav,
On 08/20/2012 01:19 PM, Poddar, Sourav wrote:
> Hi All,
>
> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>> Add keypad data node in omap4 device tree file.
>> Also fill the device tree binding parameters
>> with the required value in "omap4-sdp" dts file.
>>
>> Tested on omap4430 sdp.
>>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>> ---
>> v6->v7
>> Add key name as a comment.
>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>> index 72216e9..8e200f4 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -113,6 +113,76 @@
>> "DMic", "Digital Mic",
>> "Digital Mic", "Digital Mic1 Bias";
>> };
>> +
>> + keypad {
>> + keypad,num-rows = <8>;
>> + keypad,num-columns = <8>;
>> + linux,keymap = < 0x00000012 /* KEY_E */
>> + 0x00010013 /* KEY_R */
>> + 0x00020014 /* KEY_T */
>> + 0x00030066 /* KEY_HOME */
>> + 0x0004003f /* KEY_F5 */
>> + 0x000500f0 /* KEY_UNKNOWN */
>> + 0x00060017 /* KEY_I */
>> + 0x0007002a /* KEY_LEFTSHIFT */
>> + 0x01000020 /* KEY_D*/
>> + 0x01010021 /* KEY_F */
>> + 0x01020022 /* KEY_G */
>> + 0x010300e7 /* KEY_SEND */
>> + 0x01040040 /* KEY_F6 */
>> + 0x010500f0 /* KEY_UNKNOWN */
>> + 0x01060025 /* KEY_K */
>> + 0x0107001c /* KEY_ENTER */
>> + 0x0200002d /* KEY_X */
>> + 0x0201002e /* KEY_C */
>> + 0x0202002f /* KEY_V */
>> + 0x0203006b /* KEY_END */
>> + 0x02040041 /* KEY_F7 */
>> + 0x020500f0 /* KEY_UNKNOWN */
>> + 0x02060034 /* KEY_DOT */
>> + 0x0207003a /* KEY_CAPSLOCK */
>> + 0x0300002c /* KEY_Z */
>> + 0x0301004e /* KEY_KPLUS */
>> + 0x03020030 /* KEY_B */
>> + 0x0303003b /* KEY_F1 */
>> + 0x03040042 /* KEY_F8 */
>> + 0x030500f0 /* KEY_UNKNOWN */
>> + 0x03060018 /* KEY_O */
>> + 0x03070039 /* KEY_SPACE */
>> + 0x04000011 /* KEY_W */
>> + 0x04010015 /* KEY_Y */
>> + 0x04020016 /* KEY_U */
>> + 0x0403003c /* KEY_F2 */
>> + 0x04040073 /* KEY_VOLUMEUP */
>> + 0x040500f0 /* KEY_UNKNOWN */
>> + 0x04060026 /* KEY_L */
>> + 0x04070069 /* KEY_LEFT */
>> + 0x0500001f /* KEY_S */
>> + 0x05010023 /* KEY_H */
>> + 0x05020024 /* KEY_J */
>> + 0x0503003d /* KEY_F3 */
>> + 0x05040043 /* KEY_F9 */
>> + 0x05050072 /* KEY_VOLUMEDOWN */
>> + 0x05060032 /* KEY_M */
>> + 0x0507006a /* KEY_RIGHT */
>> + 0x06000010 /* KEY_Q */
>> + 0x0601001e /* KEY_A */
>> + 0x06020031 /* KEY_N */
>> + 0x0603009e /* KEY_BACK */
>> + 0x0604000e /* KEY_BACKSPACE */
>> + 0x060500f0 /* KEY_UNKNOWN */
>> + 0x06060019 /* KEY_P */
>> + 0x06070067 /* KEY_UP */
>> + 0x07000094 /* KEY_PROG1 */
>> + 0x07010095 /* KEY_PROG2 */
>> + 0x070200ca /* KEY_PROG3 */
>> + 0x070300cb /* KEY_PROG4 */
>> + 0x0704003e /* KEY_F4 */
>> + 0x070500f0 /* KEY_UNKNOWN */
>> + 0x07060160 /* KEY_OK */
>> + 0x0707006c >; /* KEY_DOWN */
>> + linux,input-no-autorepeat;
>> + };
>> };
>>
>> &i2c1 {
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 04cbbcb..e78a1f1 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -296,4 +296,9 @@
>> ti,hwmods = "dmic";
>> };
>> };
>> +
>> + keypad {
>> + compatible = "ti,omap4-keypad";
>> + ti,hwmods = "kbd";
>> + };
>> };
>> --
>> 1.7.1
>>
> Any more comments on this?
That's perfect.
I'll take it and send it with other DT patches to Tony.
Regards,
Benoit
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-20 11:53 ` Benoit Cousson
0 siblings, 0 replies; 20+ messages in thread
From: Benoit Cousson @ 2012-08-20 11:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sourav,
On 08/20/2012 01:19 PM, Poddar, Sourav wrote:
> Hi All,
>
> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>> Add keypad data node in omap4 device tree file.
>> Also fill the device tree binding parameters
>> with the required value in "omap4-sdp" dts file.
>>
>> Tested on omap4430 sdp.
>>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>> ---
>> v6->v7
>> Add key name as a comment.
>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>> index 72216e9..8e200f4 100644
>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>> @@ -113,6 +113,76 @@
>> "DMic", "Digital Mic",
>> "Digital Mic", "Digital Mic1 Bias";
>> };
>> +
>> + keypad {
>> + keypad,num-rows = <8>;
>> + keypad,num-columns = <8>;
>> + linux,keymap = < 0x00000012 /* KEY_E */
>> + 0x00010013 /* KEY_R */
>> + 0x00020014 /* KEY_T */
>> + 0x00030066 /* KEY_HOME */
>> + 0x0004003f /* KEY_F5 */
>> + 0x000500f0 /* KEY_UNKNOWN */
>> + 0x00060017 /* KEY_I */
>> + 0x0007002a /* KEY_LEFTSHIFT */
>> + 0x01000020 /* KEY_D*/
>> + 0x01010021 /* KEY_F */
>> + 0x01020022 /* KEY_G */
>> + 0x010300e7 /* KEY_SEND */
>> + 0x01040040 /* KEY_F6 */
>> + 0x010500f0 /* KEY_UNKNOWN */
>> + 0x01060025 /* KEY_K */
>> + 0x0107001c /* KEY_ENTER */
>> + 0x0200002d /* KEY_X */
>> + 0x0201002e /* KEY_C */
>> + 0x0202002f /* KEY_V */
>> + 0x0203006b /* KEY_END */
>> + 0x02040041 /* KEY_F7 */
>> + 0x020500f0 /* KEY_UNKNOWN */
>> + 0x02060034 /* KEY_DOT */
>> + 0x0207003a /* KEY_CAPSLOCK */
>> + 0x0300002c /* KEY_Z */
>> + 0x0301004e /* KEY_KPLUS */
>> + 0x03020030 /* KEY_B */
>> + 0x0303003b /* KEY_F1 */
>> + 0x03040042 /* KEY_F8 */
>> + 0x030500f0 /* KEY_UNKNOWN */
>> + 0x03060018 /* KEY_O */
>> + 0x03070039 /* KEY_SPACE */
>> + 0x04000011 /* KEY_W */
>> + 0x04010015 /* KEY_Y */
>> + 0x04020016 /* KEY_U */
>> + 0x0403003c /* KEY_F2 */
>> + 0x04040073 /* KEY_VOLUMEUP */
>> + 0x040500f0 /* KEY_UNKNOWN */
>> + 0x04060026 /* KEY_L */
>> + 0x04070069 /* KEY_LEFT */
>> + 0x0500001f /* KEY_S */
>> + 0x05010023 /* KEY_H */
>> + 0x05020024 /* KEY_J */
>> + 0x0503003d /* KEY_F3 */
>> + 0x05040043 /* KEY_F9 */
>> + 0x05050072 /* KEY_VOLUMEDOWN */
>> + 0x05060032 /* KEY_M */
>> + 0x0507006a /* KEY_RIGHT */
>> + 0x06000010 /* KEY_Q */
>> + 0x0601001e /* KEY_A */
>> + 0x06020031 /* KEY_N */
>> + 0x0603009e /* KEY_BACK */
>> + 0x0604000e /* KEY_BACKSPACE */
>> + 0x060500f0 /* KEY_UNKNOWN */
>> + 0x06060019 /* KEY_P */
>> + 0x06070067 /* KEY_UP */
>> + 0x07000094 /* KEY_PROG1 */
>> + 0x07010095 /* KEY_PROG2 */
>> + 0x070200ca /* KEY_PROG3 */
>> + 0x070300cb /* KEY_PROG4 */
>> + 0x0704003e /* KEY_F4 */
>> + 0x070500f0 /* KEY_UNKNOWN */
>> + 0x07060160 /* KEY_OK */
>> + 0x0707006c >; /* KEY_DOWN */
>> + linux,input-no-autorepeat;
>> + };
>> };
>>
>> &i2c1 {
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 04cbbcb..e78a1f1 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -296,4 +296,9 @@
>> ti,hwmods = "dmic";
>> };
>> };
>> +
>> + keypad {
>> + compatible = "ti,omap4-keypad";
>> + ti,hwmods = "kbd";
>> + };
>> };
>> --
>> 1.7.1
>>
> Any more comments on this?
That's perfect.
I'll take it and send it with other DT patches to Tony.
Regards,
Benoit
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCHv7] arm/dts: omap4-sdp: Add keypad data
2012-08-20 11:53 ` Benoit Cousson
@ 2012-08-20 11:56 ` Poddar, Sourav
-1 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-20 11:56 UTC (permalink / raw)
To: Benoit Cousson
Cc: devicetree-discuss, linux-arm-kernel, linux-omap, linux-kernel,
Tony Lindgren, Rob Herring, Grant Likely, Felipe Balbi
On Mon, Aug 20, 2012 at 5:23 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> Hi Sourav,
>
> On 08/20/2012 01:19 PM, Poddar, Sourav wrote:
>> Hi All,
>>
>> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>> Add keypad data node in omap4 device tree file.
>>> Also fill the device tree binding parameters
>>> with the required value in "omap4-sdp" dts file.
>>>
>>> Tested on omap4430 sdp.
>>>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: Felipe Balbi <balbi@ti.com>
>>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>>> ---
>>> v6->v7
>>> Add key name as a comment.
>>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>>> index 72216e9..8e200f4 100644
>>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>>> @@ -113,6 +113,76 @@
>>> "DMic", "Digital Mic",
>>> "Digital Mic", "Digital Mic1 Bias";
>>> };
>>> +
>>> + keypad {
>>> + keypad,num-rows = <8>;
>>> + keypad,num-columns = <8>;
>>> + linux,keymap = < 0x00000012 /* KEY_E */
>>> + 0x00010013 /* KEY_R */
>>> + 0x00020014 /* KEY_T */
>>> + 0x00030066 /* KEY_HOME */
>>> + 0x0004003f /* KEY_F5 */
>>> + 0x000500f0 /* KEY_UNKNOWN */
>>> + 0x00060017 /* KEY_I */
>>> + 0x0007002a /* KEY_LEFTSHIFT */
>>> + 0x01000020 /* KEY_D*/
>>> + 0x01010021 /* KEY_F */
>>> + 0x01020022 /* KEY_G */
>>> + 0x010300e7 /* KEY_SEND */
>>> + 0x01040040 /* KEY_F6 */
>>> + 0x010500f0 /* KEY_UNKNOWN */
>>> + 0x01060025 /* KEY_K */
>>> + 0x0107001c /* KEY_ENTER */
>>> + 0x0200002d /* KEY_X */
>>> + 0x0201002e /* KEY_C */
>>> + 0x0202002f /* KEY_V */
>>> + 0x0203006b /* KEY_END */
>>> + 0x02040041 /* KEY_F7 */
>>> + 0x020500f0 /* KEY_UNKNOWN */
>>> + 0x02060034 /* KEY_DOT */
>>> + 0x0207003a /* KEY_CAPSLOCK */
>>> + 0x0300002c /* KEY_Z */
>>> + 0x0301004e /* KEY_KPLUS */
>>> + 0x03020030 /* KEY_B */
>>> + 0x0303003b /* KEY_F1 */
>>> + 0x03040042 /* KEY_F8 */
>>> + 0x030500f0 /* KEY_UNKNOWN */
>>> + 0x03060018 /* KEY_O */
>>> + 0x03070039 /* KEY_SPACE */
>>> + 0x04000011 /* KEY_W */
>>> + 0x04010015 /* KEY_Y */
>>> + 0x04020016 /* KEY_U */
>>> + 0x0403003c /* KEY_F2 */
>>> + 0x04040073 /* KEY_VOLUMEUP */
>>> + 0x040500f0 /* KEY_UNKNOWN */
>>> + 0x04060026 /* KEY_L */
>>> + 0x04070069 /* KEY_LEFT */
>>> + 0x0500001f /* KEY_S */
>>> + 0x05010023 /* KEY_H */
>>> + 0x05020024 /* KEY_J */
>>> + 0x0503003d /* KEY_F3 */
>>> + 0x05040043 /* KEY_F9 */
>>> + 0x05050072 /* KEY_VOLUMEDOWN */
>>> + 0x05060032 /* KEY_M */
>>> + 0x0507006a /* KEY_RIGHT */
>>> + 0x06000010 /* KEY_Q */
>>> + 0x0601001e /* KEY_A */
>>> + 0x06020031 /* KEY_N */
>>> + 0x0603009e /* KEY_BACK */
>>> + 0x0604000e /* KEY_BACKSPACE */
>>> + 0x060500f0 /* KEY_UNKNOWN */
>>> + 0x06060019 /* KEY_P */
>>> + 0x06070067 /* KEY_UP */
>>> + 0x07000094 /* KEY_PROG1 */
>>> + 0x07010095 /* KEY_PROG2 */
>>> + 0x070200ca /* KEY_PROG3 */
>>> + 0x070300cb /* KEY_PROG4 */
>>> + 0x0704003e /* KEY_F4 */
>>> + 0x070500f0 /* KEY_UNKNOWN */
>>> + 0x07060160 /* KEY_OK */
>>> + 0x0707006c >; /* KEY_DOWN */
>>> + linux,input-no-autorepeat;
>>> + };
>>> };
>>>
>>> &i2c1 {
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 04cbbcb..e78a1f1 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -296,4 +296,9 @@
>>> ti,hwmods = "dmic";
>>> };
>>> };
>>> +
>>> + keypad {
>>> + compatible = "ti,omap4-keypad";
>>> + ti,hwmods = "kbd";
>>> + };
>>> };
>>> --
>>> 1.7.1
>>>
>> Any more comments on this?
>
> That's perfect.
>
> I'll take it and send it with other DT patches to Tony.
>
Thanks Benoit !!
> Regards,
> Benoit
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCHv7] arm/dts: omap4-sdp: Add keypad data
@ 2012-08-20 11:56 ` Poddar, Sourav
0 siblings, 0 replies; 20+ messages in thread
From: Poddar, Sourav @ 2012-08-20 11:56 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 20, 2012 at 5:23 PM, Benoit Cousson <b-cousson@ti.com> wrote:
> Hi Sourav,
>
> On 08/20/2012 01:19 PM, Poddar, Sourav wrote:
>> Hi All,
>>
>> On Tue, Aug 14, 2012 at 4:45 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
>>> Add keypad data node in omap4 device tree file.
>>> Also fill the device tree binding parameters
>>> with the required value in "omap4-sdp" dts file.
>>>
>>> Tested on omap4430 sdp.
>>>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Cc: Benoit Cousson <b-cousson@ti.com>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: Felipe Balbi <balbi@ti.com>
>>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>>> ---
>>> v6->v7
>>> Add key name as a comment.
>>> arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/omap4.dtsi | 5 +++
>>> 2 files changed, 75 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
>>> index 72216e9..8e200f4 100644
>>> --- a/arch/arm/boot/dts/omap4-sdp.dts
>>> +++ b/arch/arm/boot/dts/omap4-sdp.dts
>>> @@ -113,6 +113,76 @@
>>> "DMic", "Digital Mic",
>>> "Digital Mic", "Digital Mic1 Bias";
>>> };
>>> +
>>> + keypad {
>>> + keypad,num-rows = <8>;
>>> + keypad,num-columns = <8>;
>>> + linux,keymap = < 0x00000012 /* KEY_E */
>>> + 0x00010013 /* KEY_R */
>>> + 0x00020014 /* KEY_T */
>>> + 0x00030066 /* KEY_HOME */
>>> + 0x0004003f /* KEY_F5 */
>>> + 0x000500f0 /* KEY_UNKNOWN */
>>> + 0x00060017 /* KEY_I */
>>> + 0x0007002a /* KEY_LEFTSHIFT */
>>> + 0x01000020 /* KEY_D*/
>>> + 0x01010021 /* KEY_F */
>>> + 0x01020022 /* KEY_G */
>>> + 0x010300e7 /* KEY_SEND */
>>> + 0x01040040 /* KEY_F6 */
>>> + 0x010500f0 /* KEY_UNKNOWN */
>>> + 0x01060025 /* KEY_K */
>>> + 0x0107001c /* KEY_ENTER */
>>> + 0x0200002d /* KEY_X */
>>> + 0x0201002e /* KEY_C */
>>> + 0x0202002f /* KEY_V */
>>> + 0x0203006b /* KEY_END */
>>> + 0x02040041 /* KEY_F7 */
>>> + 0x020500f0 /* KEY_UNKNOWN */
>>> + 0x02060034 /* KEY_DOT */
>>> + 0x0207003a /* KEY_CAPSLOCK */
>>> + 0x0300002c /* KEY_Z */
>>> + 0x0301004e /* KEY_KPLUS */
>>> + 0x03020030 /* KEY_B */
>>> + 0x0303003b /* KEY_F1 */
>>> + 0x03040042 /* KEY_F8 */
>>> + 0x030500f0 /* KEY_UNKNOWN */
>>> + 0x03060018 /* KEY_O */
>>> + 0x03070039 /* KEY_SPACE */
>>> + 0x04000011 /* KEY_W */
>>> + 0x04010015 /* KEY_Y */
>>> + 0x04020016 /* KEY_U */
>>> + 0x0403003c /* KEY_F2 */
>>> + 0x04040073 /* KEY_VOLUMEUP */
>>> + 0x040500f0 /* KEY_UNKNOWN */
>>> + 0x04060026 /* KEY_L */
>>> + 0x04070069 /* KEY_LEFT */
>>> + 0x0500001f /* KEY_S */
>>> + 0x05010023 /* KEY_H */
>>> + 0x05020024 /* KEY_J */
>>> + 0x0503003d /* KEY_F3 */
>>> + 0x05040043 /* KEY_F9 */
>>> + 0x05050072 /* KEY_VOLUMEDOWN */
>>> + 0x05060032 /* KEY_M */
>>> + 0x0507006a /* KEY_RIGHT */
>>> + 0x06000010 /* KEY_Q */
>>> + 0x0601001e /* KEY_A */
>>> + 0x06020031 /* KEY_N */
>>> + 0x0603009e /* KEY_BACK */
>>> + 0x0604000e /* KEY_BACKSPACE */
>>> + 0x060500f0 /* KEY_UNKNOWN */
>>> + 0x06060019 /* KEY_P */
>>> + 0x06070067 /* KEY_UP */
>>> + 0x07000094 /* KEY_PROG1 */
>>> + 0x07010095 /* KEY_PROG2 */
>>> + 0x070200ca /* KEY_PROG3 */
>>> + 0x070300cb /* KEY_PROG4 */
>>> + 0x0704003e /* KEY_F4 */
>>> + 0x070500f0 /* KEY_UNKNOWN */
>>> + 0x07060160 /* KEY_OK */
>>> + 0x0707006c >; /* KEY_DOWN */
>>> + linux,input-no-autorepeat;
>>> + };
>>> };
>>>
>>> &i2c1 {
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 04cbbcb..e78a1f1 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -296,4 +296,9 @@
>>> ti,hwmods = "dmic";
>>> };
>>> };
>>> +
>>> + keypad {
>>> + compatible = "ti,omap4-keypad";
>>> + ti,hwmods = "kbd";
>>> + };
>>> };
>>> --
>>> 1.7.1
>>>
>> Any more comments on this?
>
> That's perfect.
>
> I'll take it and send it with other DT patches to Tony.
>
Thanks Benoit !!
> Regards,
> Benoit
>
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2012-08-20 11:56 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 10:38 [PATCHv7] arm/dts: omap4-sdp: Add keypad data Sourav Poddar
2012-07-20 10:38 ` Sourav Poddar
2012-08-14 6:23 ` Poddar, Sourav
2012-08-14 6:23 ` Poddar, Sourav
2012-08-14 9:20 ` Benoit Cousson
2012-08-14 9:20 ` Benoit Cousson
2012-08-14 9:23 ` Poddar, Sourav
2012-08-14 9:23 ` Poddar, Sourav
-- strict thread matches above, loose matches on Subject: below --
2012-08-14 11:15 Sourav Poddar
2012-08-14 11:15 ` Sourav Poddar
2012-08-14 11:15 ` Sourav Poddar
2012-08-20 11:19 ` Poddar, Sourav
2012-08-20 11:19 ` Poddar, Sourav
2012-08-20 11:34 ` Felipe Balbi
2012-08-20 11:34 ` Felipe Balbi
[not found] ` <CAKdam57n1jA5_7EOLcsB=u5X4wX6hPVXoZ2HLrnpEKS3kLZ=OQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-20 11:53 ` Benoit Cousson
2012-08-20 11:53 ` Benoit Cousson
2012-08-20 11:53 ` Benoit Cousson
2012-08-20 11:56 ` Poddar, Sourav
2012-08-20 11:56 ` Poddar, Sourav
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.