From: Tabi Timur-B04825 <B04825@freescale.com>
To: Zhao Chenhui-B35336 <B35336@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang-R58472 <r58472@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Zhao Chenhui-B35336 <B35336@freescale.com>
Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source
Date: Tue, 14 Aug 2012 12:27:17 +0000 [thread overview]
Message-ID: <502A4424.80000@freescale.com> (raw)
In-Reply-To: <20120814100141.GB21028@localhost.localdomain>
Zhao Chenhui wrote:
>>> > >+#ifdef CONFIG_FSL_PMC
>>> > >+extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable);
>>> > >+extern void mpc85xx_pmc_set_lossless_ethernet(int enable);
>> >
>> >Don't use 'extern' for functions.
>> >
> Why? I think there is no difference.
It's unnecessary, and it makes the line longer.
--=20
Timur Tabi
Linux kernel developer at Freescale=
WARNING: multiple messages have this Message-ID (diff)
From: Tabi Timur-B04825 <B04825@freescale.com>
To: Zhao Chenhui-B35336 <B35336@freescale.com>
Cc: Zhao Chenhui-B35336 <B35336@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"galak@kernel.crashing.org" <galak@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang-R58472 <r58472@freescale.com>,
Li Yang-R58472 <r58472@freescale.com>
Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source
Date: Tue, 14 Aug 2012 12:27:17 +0000 [thread overview]
Message-ID: <502A4424.80000@freescale.com> (raw)
In-Reply-To: <20120814100141.GB21028@localhost.localdomain>
Zhao Chenhui wrote:
>>> > >+#ifdef CONFIG_FSL_PMC
>>> > >+extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable);
>>> > >+extern void mpc85xx_pmc_set_lossless_ethernet(int enable);
>> >
>> >Don't use 'extern' for functions.
>> >
> Why? I think there is no difference.
It's unnecessary, and it makes the line longer.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-08-14 12:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 8:43 [PATCH 1/4] powerpc/85xx: add sleep and deep sleep support Zhao Chenhui
2012-08-07 8:43 ` Zhao Chenhui
2012-08-07 8:43 ` [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source Zhao Chenhui
2012-08-07 8:43 ` Zhao Chenhui
2012-08-11 13:19 ` Tabi Timur-B04825
2012-08-11 13:19 ` Tabi Timur-B04825
2012-08-14 9:58 ` Zhao Chenhui
2012-08-14 9:58 ` Zhao Chenhui
2012-08-14 10:01 ` Zhao Chenhui
2012-08-14 10:01 ` Zhao Chenhui
2012-08-14 12:27 ` Tabi Timur-B04825 [this message]
2012-08-14 12:27 ` Tabi Timur-B04825
2012-08-07 8:43 ` [PATCH 3/4] cpu: export cpu hotplug disable/enable functions as global functions Zhao Chenhui
2012-08-07 8:43 ` Zhao Chenhui
2012-08-07 17:51 ` Kumar Gala
2012-08-07 17:51 ` Kumar Gala
2012-08-08 6:13 ` Srivatsa S. Bhat
2012-08-08 6:13 ` Srivatsa S. Bhat
2012-08-08 7:11 ` Zhao Chenhui
2012-08-08 7:11 ` Zhao Chenhui
2012-08-10 9:41 ` Zhao Chenhui
2012-08-10 9:41 ` Zhao Chenhui
2012-08-07 8:43 ` [PATCH 4/4] powerpc/85xx: add support to JOG feature using cpufreq interface Zhao Chenhui
2012-08-07 8:43 ` Zhao Chenhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A4424.80000@freescale.com \
--to=b04825@freescale.com \
--cc=B35336@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.