From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, karl-michael.schindler@web.de,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris
Date: Tue, 14 Aug 2012 16:51:55 +0200 [thread overview]
Message-ID: <502A660B.9010204@suse.de> (raw)
In-Reply-To: <1344954934-928-1-git-send-email-peter.maydell@linaro.org>
Am 14.08.2012 16:35, schrieb Peter Maydell:
> Both MacOS and Solaris have special case handling for the CPU
> type, because the check_define probes will return i386 even if
> the hardware is 64 bit and x86_64 would be preferable. Move
> these checks earlier in the configure probing so that we can
> do them only if the user didn't specify a CPU with --cpu. This
> fixes a bug where the user's command line argument was being
> ignored.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The per-OS checks are broken for cross compilation, but this isn't
> a change introduced by this patch -- they were broken before; I've
> merely added a comment noting the fact and the workaround...
Reviewed-by: Andreas Färber <afaerber@suse.de>
Looks okay as far as I can see. We should probably do the __APPLE__ ->
Darwin dance as a followup (ignoring the iOS, which can't JIT).
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-08-14 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:35 [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris Peter Maydell
2012-08-14 14:51 ` Andreas Färber [this message]
2012-08-14 22:48 ` Schindler Karl-Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A660B.9010204@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=karl-michael.schindler@web.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.