All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cole Robinson <crobinso@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Avi Kivity <avi@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"aik@ozlabs.ru" <aik@ozlabs.ru>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Alex Graf <agraf@suse.de>
Subject: Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2
Date: Tue, 14 Aug 2012 11:28:45 -0400	[thread overview]
Message-ID: <502A6EAD.4080700@redhat.com> (raw)
In-Reply-To: <502A68F4.1080009@siemens.com>

On 08/14/2012 11:04 AM, Jan Kiszka wrote:
> On 2012-08-14 16:53, Cole Robinson wrote:
>> On 08/13/2012 03:31 PM, Anthony Liguori wrote:
>>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>>
>>>> On 2012-08-13 15:58, Avi Kivity wrote:
>>>>> On 08/13/2012 04:27 PM, Anthony Liguori wrote:
>>>>>
>>>>>> Thanks for pushing this forward!  Hopefully this will finally kill off
>>>>>> qemu-kvm.git for good.
>>>>>
>>>>> No, it won't.  vfio requires a 3.6 kernel, which we cannot assume anyone
>>>>> has.  We'll need the original device assignment code side-by-side.
>>>>
>>>> ...which is on my to-do list for 1.3.
>>>
>>> Is there a deprecation plan for the old device assignment code?
>>>
>>> I'm not really against the idea of requiring a new kernel for new
>>> features.
>>>
>>> From a Fedora/OpenSUSE point of view, would supporting old kernels be a
>>> requirement to stop shipping qemu-kvm.git over qemu.git?
>>>
>>
>> Speaking as a Fedora maintainer, compatibility with old kernels isn't that
>> important to us, provided the functionality of the new way is comparable to
>> the old way.
>>
>> As far as switching over to qemu.git, I assume there will eventually be a day
>> when the fork would 'end' and qemu-kvm would stop getting its own releases,
>> which is when we'd switch. Maybe that assumption is wrong or over simplifying
>> the trade offs, but if merge work is ongoing I don't see a very compelling
>> reason to switch.
> 
> If you sit and wait, you may find out on that specific day that someone
> forget to port over feature X and Y, and now QEMU does not fit your
> needs and qemu-kvm is dead.
> 

My head isn't entirely in the sand here, I've watched the patches go by and
feel pretty confident that you and co. wouldn't drop qemu-kvm if there was
something missing that left qemu.git substantially lacking, at least not
without announcing it clearly. I know certain defaults will change and certain
cli options will go away but that just requires user education.

And qemu-kvm won't really 'die', the code isn't going to disappear. If we
switch to qemu.git and discover some vital piece is missing, we can
temporarily carry the relevant qemu-kvm bits and try to get the issue resolved
upstream. If upstream doesn't want to change, then we are back to user education.

- Cole

WARNING: multiple messages have this Message-ID (diff)
From: Cole Robinson <crobinso@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"aik@ozlabs.ru" <aik@ozlabs.ru>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Alex Graf <agraf@suse.de>,
	Alex Williamson <alex.williamson@redhat.com>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2
Date: Tue, 14 Aug 2012 11:28:45 -0400	[thread overview]
Message-ID: <502A6EAD.4080700@redhat.com> (raw)
In-Reply-To: <502A68F4.1080009@siemens.com>

On 08/14/2012 11:04 AM, Jan Kiszka wrote:
> On 2012-08-14 16:53, Cole Robinson wrote:
>> On 08/13/2012 03:31 PM, Anthony Liguori wrote:
>>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>>
>>>> On 2012-08-13 15:58, Avi Kivity wrote:
>>>>> On 08/13/2012 04:27 PM, Anthony Liguori wrote:
>>>>>
>>>>>> Thanks for pushing this forward!  Hopefully this will finally kill off
>>>>>> qemu-kvm.git for good.
>>>>>
>>>>> No, it won't.  vfio requires a 3.6 kernel, which we cannot assume anyone
>>>>> has.  We'll need the original device assignment code side-by-side.
>>>>
>>>> ...which is on my to-do list for 1.3.
>>>
>>> Is there a deprecation plan for the old device assignment code?
>>>
>>> I'm not really against the idea of requiring a new kernel for new
>>> features.
>>>
>>> From a Fedora/OpenSUSE point of view, would supporting old kernels be a
>>> requirement to stop shipping qemu-kvm.git over qemu.git?
>>>
>>
>> Speaking as a Fedora maintainer, compatibility with old kernels isn't that
>> important to us, provided the functionality of the new way is comparable to
>> the old way.
>>
>> As far as switching over to qemu.git, I assume there will eventually be a day
>> when the fork would 'end' and qemu-kvm would stop getting its own releases,
>> which is when we'd switch. Maybe that assumption is wrong or over simplifying
>> the trade offs, but if merge work is ongoing I don't see a very compelling
>> reason to switch.
> 
> If you sit and wait, you may find out on that specific day that someone
> forget to port over feature X and Y, and now QEMU does not fit your
> needs and qemu-kvm is dead.
> 

My head isn't entirely in the sand here, I've watched the patches go by and
feel pretty confident that you and co. wouldn't drop qemu-kvm if there was
something missing that left qemu.git substantially lacking, at least not
without announcing it clearly. I know certain defaults will change and certain
cli options will go away but that just requires user education.

And qemu-kvm won't really 'die', the code isn't going to disappear. If we
switch to qemu.git and discover some vital piece is missing, we can
temporarily carry the relevant qemu-kvm bits and try to get the issue resolved
upstream. If upstream doesn't want to change, then we are back to user education.

- Cole

  reply	other threads:[~2012-08-14 15:28 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01  5:18 [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2 Alex Williamson
2012-08-01  5:18 ` [Qemu-devel] " Alex Williamson
2012-08-01  5:18 ` [PATCH 1/3] vfio: Import vfio kernel header Alex Williamson
2012-08-01  5:18   ` [Qemu-devel] " Alex Williamson
2012-08-01  7:13   ` Jan Kiszka
2012-08-01  7:13     ` [Qemu-devel] " Jan Kiszka
2012-08-01 18:09     ` Alex Williamson
2012-08-01 18:09       ` [Qemu-devel] " Alex Williamson
2012-08-02  9:02       ` Jan Kiszka
2012-08-02  9:02         ` [Qemu-devel] " Jan Kiszka
2012-08-02 16:37         ` Alex Williamson
2012-08-02 16:37           ` [Qemu-devel] " Alex Williamson
2012-08-02 16:45           ` Jan Kiszka
2012-08-02 16:45             ` [Qemu-devel] " Jan Kiszka
2012-08-01  5:18 ` [PATCH 2/3] vfio: vfio-pci device assignment driver Alex Williamson
2012-08-01  5:18   ` [Qemu-devel] " Alex Williamson
2012-08-13 22:18   ` Anthony Liguori
2012-08-13 22:18     ` [Qemu-devel] " Anthony Liguori
2012-08-14  5:25     ` Alex Williamson
2012-08-14  5:25       ` [Qemu-devel] " Alex Williamson
2012-08-14  7:12   ` Stefan Hajnoczi
2012-08-14  7:12     ` [Qemu-devel] " Stefan Hajnoczi
2012-08-14 13:51     ` Alex Williamson
2012-08-14 13:51       ` [Qemu-devel] " Alex Williamson
2012-08-14 15:53   ` Avi Kivity
2012-08-14 15:53     ` [Qemu-devel] " Avi Kivity
2012-08-14 17:23     ` Alex Williamson
2012-08-14 17:23       ` [Qemu-devel] " Alex Williamson
2012-08-15  8:56       ` Avi Kivity
2012-08-15  8:56         ` [Qemu-devel] " Avi Kivity
2012-08-01  5:18 ` [PATCH 3/3] vfio: Enable vfio-pci and mark supported Alex Williamson
2012-08-01  5:18   ` [Qemu-devel] " Alex Williamson
2012-08-01  7:15   ` Jan Kiszka
2012-08-01  7:15     ` [Qemu-devel] " Jan Kiszka
2012-08-01 18:14     ` Alex Williamson
2012-08-01 18:14       ` [Qemu-devel] " Alex Williamson
2012-08-01 19:40       ` Alex Williamson
2012-08-01 19:40         ` [Qemu-devel] " Alex Williamson
2012-08-02  9:03         ` Jan Kiszka
2012-08-02  9:03           ` [Qemu-devel] " Jan Kiszka
2012-08-13 22:19     ` Anthony Liguori
2012-08-13 22:19       ` [Qemu-devel] " Anthony Liguori
2012-08-14  5:27       ` Alex Williamson
2012-08-14  5:27         ` [Qemu-devel] " Alex Williamson
2012-08-14 14:35         ` Avi Kivity
2012-08-14 14:35           ` [Qemu-devel] " Avi Kivity
2012-08-13 13:27 ` [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2 Anthony Liguori
2012-08-13 13:27   ` [Qemu-devel] " Anthony Liguori
2012-08-13 13:58   ` Avi Kivity
2012-08-13 13:58     ` [Qemu-devel] " Avi Kivity
2012-08-13 14:04     ` Jan Kiszka
2012-08-13 14:04       ` [Qemu-devel] " Jan Kiszka
2012-08-13 19:31       ` Anthony Liguori
2012-08-13 19:31         ` [Qemu-devel] " Anthony Liguori
2012-08-14  7:19         ` Jan Kiszka
2012-08-14  7:19           ` [Qemu-devel] " Jan Kiszka
2012-08-14 14:42         ` Avi Kivity
2012-08-14 14:42           ` [Qemu-devel] " Avi Kivity
2012-08-14 14:53         ` Cole Robinson
2012-08-14 14:53           ` [Qemu-devel] " Cole Robinson
2012-08-14 15:04           ` Jan Kiszka
2012-08-14 15:04             ` [Qemu-devel] " Jan Kiszka
2012-08-14 15:28             ` Cole Robinson [this message]
2012-08-14 15:28               ` Cole Robinson
2012-08-13 14:23   ` Alex Williamson
2012-08-13 14:23     ` [Qemu-devel] " Alex Williamson
2012-08-13 15:48     ` Andreas Hartmann
2012-08-13 15:48       ` [Qemu-devel] " Andreas Hartmann
2012-08-13 16:14       ` Alex Williamson
2012-08-13 16:14         ` [Qemu-devel] " Alex Williamson
2012-08-13 16:36         ` Andreas Hartmann
2012-08-13 16:36           ` [Qemu-devel] " Andreas Hartmann
2012-08-13 16:57           ` Alex Williamson
2012-08-13 16:57             ` [Qemu-devel] " Alex Williamson
2012-08-13 18:32             ` Andreas Hartmann
2012-08-13 18:32               ` [Qemu-devel] " Andreas Hartmann
2012-08-13 19:33     ` Anthony Liguori
2012-08-13 19:33       ` [Qemu-devel] " Anthony Liguori
2012-08-13 20:48       ` Blue Swirl
2012-08-13 20:48         ` [Qemu-devel] " Blue Swirl
2012-08-13 20:56         ` Alex Williamson
2012-08-13 20:56           ` [Qemu-devel] " Alex Williamson
2012-08-13 20:55       ` VFIO: Call for reviewers (was Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2) Alex Williamson
2012-08-13 20:55         ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A6EAD.4080700@redhat.com \
    --to=crobinso@redhat.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.