From: Timur Tabi <timur@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Andy Fleming <afleming@freescale.com>,
ddaney.cavm@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS
Date: Tue, 14 Aug 2012 18:08:37 -0500 [thread overview]
Message-ID: <502ADA75.7020200@freescale.com> (raw)
In-Reply-To: <502AD9F4.10903@freescale.com>
Scott Wood wrote:
>
> If anything, I'd make the ordering be "wrong" to force that code path to
> be tested -- though ideally there would be a more systematic approach to
> such testing, that doesn't require inefficiency during normal boot.
I can't force the ordering to be wrong, because it's the only entry in the
list. The DPAA entries are not there yet.
This is what I have now:
static const struct of_device_id of_device_ids[] __devinitconst = {
{
.compatible = "simple-bus"
},
{
.compatible = "fsl,srio",
},
{
.compatible = "fsl,p4080-pcie",
},
{
.compatible = "fsl,qoriq-pcie-v2.2",
},
{
.compatible = "fsl,qoriq-pcie-v2.3",
},
{
.compatible = "fsl,qoriq-pcie-v2.4",
},
/* The following two are for the Freescale hypervisor */
{
.name = "hypervisor",
},
{
.name = "handles",
},
{
/*
* Warning: this entry might need to be located before those
* for the Fman Ethernet nodes, although using EPROBE_DEFER
* in the DPAA drivers could fix that.
*/
.compatible = "mdio-mux",
},
{}
};
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
Andy Fleming <afleming@freescale.com>, <ddaney.cavm@gmail.com>,
<linuxppc-dev@ozlabs.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS
Date: Tue, 14 Aug 2012 18:08:37 -0500 [thread overview]
Message-ID: <502ADA75.7020200@freescale.com> (raw)
In-Reply-To: <502AD9F4.10903@freescale.com>
Scott Wood wrote:
>
> If anything, I'd make the ordering be "wrong" to force that code path to
> be tested -- though ideally there would be a more systematic approach to
> such testing, that doesn't require inefficiency during normal boot.
I can't force the ordering to be wrong, because it's the only entry in the
list. The DPAA entries are not there yet.
This is what I have now:
static const struct of_device_id of_device_ids[] __devinitconst = {
{
.compatible = "simple-bus"
},
{
.compatible = "fsl,srio",
},
{
.compatible = "fsl,p4080-pcie",
},
{
.compatible = "fsl,qoriq-pcie-v2.2",
},
{
.compatible = "fsl,qoriq-pcie-v2.3",
},
{
.compatible = "fsl,qoriq-pcie-v2.4",
},
/* The following two are for the Freescale hypervisor */
{
.name = "hypervisor",
},
{
.name = "handles",
},
{
/*
* Warning: this entry might need to be located before those
* for the Fman Ethernet nodes, although using EPROBE_DEFER
* in the DPAA drivers could fix that.
*/
.compatible = "mdio-mux",
},
{}
};
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-08-14 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 22:31 [PATCH 1/2] powerpc/85xx: add the Fman device tree template include files Timur Tabi
2012-08-10 22:31 ` [PATCH 2/2] powerpc/85xx: add Fman MDIO muxing support to the P4080DS Timur Tabi
2012-08-14 21:45 ` Kumar Gala
2012-08-14 21:45 ` Kumar Gala
2012-08-14 21:48 ` Timur Tabi
2012-08-14 21:48 ` Timur Tabi
2012-08-14 21:53 ` Scott Wood
2012-08-14 21:53 ` Scott Wood
2012-08-14 21:58 ` Timur Tabi
2012-08-14 21:58 ` Timur Tabi
2012-08-14 23:06 ` Scott Wood
2012-08-14 23:06 ` Scott Wood
2012-08-14 23:08 ` Timur Tabi [this message]
2012-08-14 23:08 ` Timur Tabi
2012-08-14 23:12 ` Scott Wood
2012-08-14 23:12 ` Scott Wood
2012-08-10 22:34 ` [PATCH 1/2] powerpc/85xx: add the Fman device tree template include files Scott Wood
2012-08-10 22:34 ` Scott Wood
2012-08-10 22:37 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502ADA75.7020200@freescale.com \
--to=timur@freescale.com \
--cc=afleming@freescale.com \
--cc=ddaney.cavm@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.